Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/9] iommu: Move iommu fault data to linux/iommu.h
Thread-Topic: [PATCH 1/9] iommu: Move iommu fault data to linux/iommu.h
Thread-Index: AQHZs5RFjSKO9r3Ol0q1EtvhMNZbRK+0EKaQ
Date:   Tue, 11 Jul 2023 06:05:37 +0000
Message-ID: <BN9PR11MB5276859ED6825C0A496C9C5E8C31A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230711010642.19707-1-baolu.lu@linux.intel.com>
 <20230711010642.19707-2-baolu.lu@linux.intel.com>
In-Reply-To: <20230711010642.19707-2-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fXYVBalMd2TjOb2ZhsWh24I1vqPAJSnzT3KSqXNODUBxokyqHbXqUpEIHUCl?=
 =?us-ascii?Q?EFRteeK0pLsy17OhXTavwwMDBtFrQLjaZmqXn3DL4GdEeg9F08p/u8N5PgVM?=
 =?us-ascii?Q?8RzzhOZAyxP1zG7Rk+r82+CHeLfLN24juTZfyykoLGTLIOVCvLaozf5b3LeT?=
 =?us-ascii?Q?A6CVqQmS+prrFfYILouq0FU2s04Ad9aUurSRnKOQpIfqItmGVvTqYhf453lK?=
 =?us-ascii?Q?G6Zjn85D0oFgbPFAOfrPuovvFdGHIpptTikHxThioArG2M/agMfc7svNwaXV?=
 =?us-ascii?Q?TcLLRgpfT9GmrLtXkBzObwv8CJe7dB/P6JnZ6ghT8r04SubpaIhYD3pi7+fv?=
 =?us-ascii?Q?kA/7l5QoaknilKzXb0rZUkeR/g7qJDMh54ApYngeqgpKcI/2dEz5tBMSC9dd?=
 =?us-ascii?Q?6Z0Px35uHIsRBTrNOkk2XXZT//oVliencIZJ2Te3g+O12/YChIEfaGK3mTAh?=
 =?us-ascii?Q?LsHbCH7+Rzi/434TD6OUWoZNovJ/gXmenujPc572TzadhA+c66Mh/KUA4XRR?=
 =?us-ascii?Q?ufeaFS/GFB9ALBSdYkwZ7Pjr3X5me/aqOyCv1b7lBYlXKC9w8tTR81jL/Arv?=
 =?us-ascii?Q?/Cawl+q7Qin4k65/qigA37z2ku9r5Ur02eNlpgDFzxQYNYI4c4kqaGbUbjWL?=
 =?us-ascii?Q?QX2MaR8PpmMRy0usf/IGT3zuZy6B41mvHwac5Jcr+ixrjuApEcu+8TFji1i/?=
 =?us-ascii?Q?mG68CKQETk0EDJy6vohe49B2HcMsOhp3vx65YSaswTZOTu9nFU7NGeFOPTyN?=
 =?us-ascii?Q?EBGvoefTODV3QfX1mBAiT0SEuZp3neHxNayjaJ1Bh7VsQ2Ctp96TXXv57qLO?=
 =?us-ascii?Q?DBU4fzB+d6ZAfLsaMpbgwnq+Uaa/LJ1ltW+m1RDZBoZzc4vRdQ/adY0ycQtz?=
 =?us-ascii?Q?CKVhTBfOq65JudSpLelq72dJ7Euw5D1rqqH0mjJN/skyxSw+URVlzhtKqMrn?=
 =?us-ascii?Q?2zgGu6AkLE9ax/owJlEtU0Kmrdrledt24gQ5oDW8kC+jjAxkw4O4hZRcfAhK?=
 =?us-ascii?Q?O5uxn8B/IMMpD+WRHevqGqo4PzL0W5YombkKYMWUK9SxjjerW5eY4+5QsD1y?=
 =?us-ascii?Q?jdnmpasJF0ZnYFmpW3D/8/E6wZRVkzgv2UnN8BzhnX/pk76ag0KS9jZgEhJv?=
 =?us-ascii?Q?paf267i/eW/dv/LP6Ep72SbJk1+SuVnXbYzVI0hv+UgClZYPYfkG2DW0W5dP?=
 =?us-ascii?Q?1XETV+RSNGeSiTsi80P5xNuY8s/6Oy+xRFMOrhoOJnfKbkeameMiWuUo0+iU?=
 =?us-ascii?Q?8HcwoPTfDXQLWvfqnWhJQIWkNRQoWsKc/iJzWuiuB7lcMF2McUVsWt5zAEkP?=
 =?us-ascii?Q?rWU7sq0GAo/jsyJ0xIyrg7YMDg7LzhmNMTftvOYVw0wQeoAsnE3PYW+z+haS?=
 =?us-ascii?Q?VsspcXbOPkPQsjGvMJt0Juy0y5Ha8Y/IaS1pKmyvyWYPg7+ruFitykp6T1qu?=
 =?us-ascii?Q?Zd+kD4cPUsSv86f0fOyb1eapWlHWkxhKx3IXgRm0t08M9CuKh07CxcFXa80i?=
 =?us-ascii?Q?1tBG6HWqDXtghJBztQl8jA90o/+Reih3rV5/bUmd5erUPv/QfUDWMp7siBRo?=
 =?us-ascii?Q?fCVaHy5zX9mvxVK4DVsB9d8gFmcfoc61xNgOrq1z?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 391f6fd8-8146-4bd6-fda0-08db81d4d923
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2023 06:05:37.8597
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uYg1ezuR8KcoeKbeHUt0qoJkJdzMhz5wD3eJyiCZ6cB3W3Ag3pdi0Np86h8DhznfX28DSBMjg5bsJF1PTPLg1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7242
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, July 11, 2023 9:07 AM
> +
> +enum iommu_fault_reason {
> +	IOMMU_FAULT_REASON_UNKNOWN =3D 0,
> +
> +	/* Could not access the PASID table (fetch caused external abort) */
> +	IOMMU_FAULT_REASON_PASID_FETCH,
> +
> +	/* PASID entry is invalid or has configuration errors */
> +	IOMMU_FAULT_REASON_BAD_PASID_ENTRY,
> +
> +	/*
> +	 * PASID is out of range (e.g. exceeds the maximum PASID
> +	 * supported by the IOMMU) or disabled.
> +	 */
> +	IOMMU_FAULT_REASON_PASID_INVALID,
> +
> +	/*
> +	 * An external abort occurred fetching (or updating) a translation
> +	 * table descriptor
> +	 */
> +	IOMMU_FAULT_REASON_WALK_EABT,
> +
> +	/*
> +	 * Could not access the page table entry (Bad address),
> +	 * actual translation fault
> +	 */
> +	IOMMU_FAULT_REASON_PTE_FETCH,
> +
> +	/* Protection flag check failed */
> +	IOMMU_FAULT_REASON_PERMISSION,
> +
> +	/* access flag check failed */
> +	IOMMU_FAULT_REASON_ACCESS,
> +
> +	/* Output address of a translation stage caused Address Size fault */
> +	IOMMU_FAULT_REASON_OOR_ADDRESS,
> +};
> +
> +/**
> + * struct iommu_fault_unrecoverable - Unrecoverable fault data
> + * @reason: reason of the fault, from &enum iommu_fault_reason
> + * @flags: parameters of this fault (IOMMU_FAULT_UNRECOV_* values)
> + * @pasid: Process Address Space ID
> + * @perm: requested permission access using by the incoming transaction
> + *        (IOMMU_FAULT_PERM_* values)
> + * @addr: offending page address
> + * @fetch_addr: address that caused a fetch abort, if any
> + */
> +struct iommu_fault_unrecoverable {
> +	__u32	reason;
> +#define IOMMU_FAULT_UNRECOV_PASID_VALID		(1 << 0)
> +#define IOMMU_FAULT_UNRECOV_ADDR_VALID		(1 << 1)
> +#define IOMMU_FAULT_UNRECOV_FETCH_ADDR_VALID	(1 << 2)
> +	__u32	flags;
> +	__u32	pasid;
> +	__u32	perm;
> +	__u64	addr;
> +	__u64	fetch_addr;
> +};

Currently there is no handler for unrecoverable faults.=20

Both Intel/ARM register iommu_queue_iopf() as the device fault handler.
It returns -EOPNOTSUPP for unrecoverable faults.

In your series the common iommu_handle_io_pgfault() also only works
for PRQ.

It kinds of suggest above definitions are dead code, though arm-smmu-v3
does attempt to set them.

Probably it's right time to remove them.

In the future even if there might be a need of forwarding unrecoverable
faults to the user via iommufd, fault reasons reported by the physical
IOMMU doesn't make any sense to the guest. Presumably the vIOMMU
should walk guest configurations to set a fault reason which makes sense
from guest p.o.v.