Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 3/9] iommu: Add common code to handle IO page faults
Thread-Topic: [PATCH 3/9] iommu: Add common code to handle IO page faults
Thread-Index: AQHZs5RGNoDpcYXyIk6nKOb2hc3wzq+0FOwQ
Date:   Tue, 11 Jul 2023 06:12:05 +0000
Message-ID: <BN9PR11MB52761F71BA509501C1766E9A8C31A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230711010642.19707-1-baolu.lu@linux.intel.com>
 <20230711010642.19707-4-baolu.lu@linux.intel.com>
In-Reply-To: <20230711010642.19707-4-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QBEiBfCG1ODS7DOJ54tdTa7fvefs/d+SsqRUR1mF4EKQn84yyicmbXQZwEWR?=
 =?us-ascii?Q?xJgUhUUjahdLFgQCXRnjlnm5Cjo5loJ6LwKDwgy53AKpJJP8ztd1Y3/8Jd0J?=
 =?us-ascii?Q?AvZ0TRN324JtH1eCb1zEUfZ2va/MD3igMNPo3obQMC83n+hfKURcXXfiPf/d?=
 =?us-ascii?Q?Q0LqtF6kwh0DzniRmvYxi/gR17dQGI1uBwiN61V9T2GEbhcv6guojbT3fchH?=
 =?us-ascii?Q?NcjLn+JdDhLoiJft6YvQPkaeTEArkqCPU+wb4sJYqR/8yfIC+DZAViU+GYkq?=
 =?us-ascii?Q?WutyAZFs8EiSY0EqgF0ZrkS+lBB3FDKnTbJeyQ6OKa2Ww+EBJxrqo8qonBoL?=
 =?us-ascii?Q?7rMjJpprqK6nuLuOl2gYzLAe6g4DYvhrxtc38li6o/Yh87QV+cfxrz85XrrC?=
 =?us-ascii?Q?DQUEOvG78O4g218SFBqpJhtPKSg2Vw2qmlP12sAmBS9pNTfoMiFOjzNfu+xJ?=
 =?us-ascii?Q?Hetr4lsDzhDdIotXlJ3ICYAXZytLLgyVRGUtDoseGZR08x5jFr3S9vAegmbH?=
 =?us-ascii?Q?/hUsxLpUIyalmor86/b13hq+R0X//2SJmVlhEJGnnYp1k6m+GqkjvhqftWbk?=
 =?us-ascii?Q?uV4P9lWzGuZFUihKTL9oi1IOEuue8OpLEy9qrddZSmFcitFOpPgGS/b7oEvc?=
 =?us-ascii?Q?Gmzx1uxcB0xQyOxGpX+iwcaCNx8V2b34NkKJL3AK0/0UWDNKZL4Hf6//tYsG?=
 =?us-ascii?Q?F8DmTx3qJh/HT/k7WC7mKh6c4Z8PIkdlM6N6cnLj9frvjzuJmtrzQEMtCAtL?=
 =?us-ascii?Q?vVGDsBZMWfR62S+6HWuhIrucyyqk4Y3o4KtdE/BXLsmBnR0bu80PMIGXskge?=
 =?us-ascii?Q?dcYIHg5KKDnEsNR+Erx3/XuG897fPTBogmTFofucPDHejri/pTobYMYKXAnh?=
 =?us-ascii?Q?PlYqjRjZV/JX17GHAmqpEyys8zBpVURrzQeLrljbJ08BZxXQ6X7bRm63mYM+?=
 =?us-ascii?Q?jxYWM6H94Wl86eEjR6kUx114B1NLRBSyd2Nia6rrdPjBnMUJjnhSeRPbz38E?=
 =?us-ascii?Q?OaYwBo2fyxLElv6zaZzE94diOoApJOQOk/XfUKXDR26585HspIgxcJHcnnbC?=
 =?us-ascii?Q?pVK2acVpe1v6nE0D9qw9SvbVQVzeIl5+Q6UejMmIHWpTjatJA2JHC8yTFriV?=
 =?us-ascii?Q?NpMoLLBxoAmhHYh9MUprPpN3Ierlf0r1IaQhpq9dV1aG5yadu+pzn1qxxqO6?=
 =?us-ascii?Q?/c5G+tHfSFC/gIw6sDGSlPhxD/n+naYIu91XgAJ5YhlJvpX920WscGqj36tT?=
 =?us-ascii?Q?BfGDTtXIQnD6UT6WDBnUBOypF74TMTQ55qHRr718ZO58ZeynfF2tdPvmBRn3?=
 =?us-ascii?Q?zY7+uTIgO1MbAh4fk5fZoCiNMGDk98vFw1XSSYLWOYeUDs+Y72086Lq6e7Mm?=
 =?us-ascii?Q?TOHi8VD6tN8cib/E8V0x4D8frEyBF6gILsdd3JbtXuZLnskDmQ300uE3viUS?=
 =?us-ascii?Q?/XIBDieKfwwHTmXL3tTPZ1jSB2/fvypb7oQUybeBnqvtp/rekmIq58b9J0am?=
 =?us-ascii?Q?ede/YEJc2AogyLVv5KbYOE7y23qQcO3fc76HC3l/LIP47yjZvQbkwVDoF02K?=
 =?us-ascii?Q?8KmcKYLwH98b3q8yZoKFzUzttAE5hB+kQU1dV3+K?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e734049a-c4e3-4e2e-a529-08db81d5bfec
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2023 06:12:05.0590
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 80wRAZNMAXmCwt2mT5tZewGuuQVJ4eIi5Fds1fY4/hURoEFJSnRpkXnqrIYArKrLXpaVMLaxRf8fZD4agAg99w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7242
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, July 11, 2023 9:07 AM
>=20
> +static int iommu_handle_io_pgfault(struct device *dev,
> +				   struct iommu_fault *fault)
> +{
> +	struct iommu_domain *domain;
> +
> +	if (fault->type !=3D IOMMU_FAULT_PAGE_REQ)
> +		return -EINVAL;
> +
> +	if (fault->prm.flags & IOMMU_FAULT_PAGE_REQUEST_PASID_VALID)
> +		domain =3D iommu_get_domain_for_dev_pasid(dev, fault-
> >prm.pasid, 0);
> +	else
> +		domain =3D iommu_get_domain_for_dev(dev);
> +
> +	if (!domain || !domain->iopf_handler)
> +		return -ENODEV;
> +
> +	if (domain->iopf_handler =3D=3D iommu_sva_handle_iopf)
> +		return iommu_queue_iopf(fault, dev);

You can avoid the special check by directly making iommu_queue_iopf
as the iopf_handler for sva domain.

> +
> +	return domain->iopf_handler(fault, dev, domain->fault_data);
> +}

btw is there value of moving the group handling logic from
iommu_queue_iopf() to this common function?

I wonder whether there is any correctness issue if not forwarding
partial request to iommufd. If not this can also help reduce
notifications to the user until the group is ready.