Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0c17e548-cca2-2f6b-b9c5-a534f5886e03@intel.com>
Date:   Tue, 11 Jul 2023 14:23:05 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH 0/5] iommu/vt-d: debugfs: Enhancements to IOMMU debugfs
Content-Language: en-US
To:     Baolu Lu <baolu.lu@linux.intel.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20230625150442.42197-1-Jingqi.liu@intel.com>
 <BN9PR11MB5276885D6A142BC94D80C2618C29A@BN9PR11MB5276.namprd11.prod.outlook.com>
 <4f18a7ca-3a57-0097-51f0-490f876831dc@intel.com>
 <BN9PR11MB5276ECF766C4F89F5083992F8C2EA@BN9PR11MB5276.namprd11.prod.outlook.com>
 <f2f23ca1-0881-4601-7ea5-c5e42ab83f62@intel.com>
 <e3146447-6af8-9049-e951-915e2770988b@linux.intel.com>
From:   "Liu, Jingqi" <jingqi.liu@intel.com>
In-Reply-To: <e3146447-6af8-9049-e951-915e2770988b@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzFMdnVHd3EvM0FxekU4dHlEbW04NldqRTdqaldMYjV5Mnp6MGRVdStTd1Nt?=
 =?utf-8?B?alc0ZVdLM3NKUkloSkY5UHUvUmVxcytWRmwxdmF6aWVGb3NyN2RGSCtlTDJu?=
 =?utf-8?B?RHdiOStEM1krZDQvUitZZHpObHZlWkNuTzB4a28zWEs4WG96ZG81eWxPYVNv?=
 =?utf-8?B?K1lXelR2TDNaQXM2Q2c0VDB2bXNKQjVFVVl1bVRmeDR4d0pMV2k5dTVVZlpE?=
 =?utf-8?B?YURpby9pWFRrcHF1TjdQTk5KOEVtSlBkNWN2T0c2OTVlQ0prN2tRbVJYZS9E?=
 =?utf-8?B?L0FVUHVzNyt2bDhtVCsrT0V1Unc2bHJPVjhpOUc2UHpqb2xaZnJ2aHdhcGdU?=
 =?utf-8?B?VUFsTFB5eW0vWmpNOHhWTS8relJhZGxMOTd6VTBaWURUSEZJNzljcFdEcGxN?=
 =?utf-8?B?Wm0zOUN4b3dIcGZWaE1UcnBGNXZwMUVaaHFXN0plcFpYOXJNVVpLVWIrZndQ?=
 =?utf-8?B?V1hpYkJWWFFSYzdxdktTMVdadm55U0psZHRVTTZaY3l5R3VBUVZ1TXo0UWNZ?=
 =?utf-8?B?djhoUGlZUWFBMGRZcnArbUtaUnh2d1cwMEpEd0c5QzZITFlIdU5GYitmSGlI?=
 =?utf-8?B?RloyR3NVV050Z0ZGT1l6STBHbGlCd1NZdkJXMFlUWE5DN3FhbTNucTF6c1dp?=
 =?utf-8?B?c0hTQnBqbGtQY2pvb0dpaWp0Z0xNcXg2U1E0NU9tSGE3aHh4MUhhc2hlNklD?=
 =?utf-8?B?am1IekUxL3FyQUR6Z3IzUHpNWnloL3dzcHFvZXBHQlRJV3pqQlNPUnBCdDRJ?=
 =?utf-8?B?TXM0L2F6WGQ2UWFHVUxpWm5qelBMWFVkZjRhWE0xTkJnN0oxT0tEaGY3YXFy?=
 =?utf-8?B?aWVSemx0RFJOOEh6aU9WWElSN3VRUmpFZzN5VGdRU3lFWW9zOWE3QlhYc3hK?=
 =?utf-8?B?djFldytsNWNiTkpsU1dnWE00Y3EvQmVraG9mSXJiVDlZSTZnZjVFaUxMSldI?=
 =?utf-8?B?VHJ6cVk4WHQ4Y3R0NGRWeENiK1BIbXI4enF1eStpN1dxQ2tpZUErWVRkTTlo?=
 =?utf-8?B?N09VR3o0VXFNU0pwVU9NTEFBOGZBZlVnK1lDUUtDZ2IzWkdib1RGaDcyc3ph?=
 =?utf-8?B?eHVvS0dsaE1yOWJDa2lUTVllWTkyY2hNVXBuNUpySWdEYXJBY09KYmxHUWNn?=
 =?utf-8?B?U2dGQmUvYUtYWWZqN09mM21YQUUvOWpwYk1FWVBtUCsrOHNDdkdGSzREbkRh?=
 =?utf-8?B?blF3Z0ZTaTFIM3pQVUVHdDZWNkE1TGx5aWE4OU9Ib1QvMy83UllhNkNuSWlG?=
 =?utf-8?B?YjZMK3NqUWgrT0UrUGsrUHd2NEpDUmE4WHFaYjRENktRU0t4ZzdVL2FvV29t?=
 =?utf-8?B?QlFrbEVibG9SRWFaci82ZkltMjg2ZDFIQVc2bmZGUHFyT056ZElPd0htUjBo?=
 =?utf-8?B?SHo1TjhhSW9oaVRQUDFqUmJNR1Z6L2ttUUluVjZmTzM0TGUwOEl3WFZ5aHUr?=
 =?utf-8?B?aG1TRWxWTXFPa3hrSE5DQkJkcnhVRnFvY0I0QXVQOW5Pbm55aUVreThhMVRM?=
 =?utf-8?B?dWFXQlhibGJBSldXNElhMHpkeG9hUnZFbGY2OVNobmhBTkg4a0pzZEdVV3FG?=
 =?utf-8?B?RHR0c2xKRzZ2Tis2WmZqMzNSUmlZZ29yNmZ4eGpYZGZTODcvUWR1NTc0R3F3?=
 =?utf-8?B?bk55Vjdsc2NuWFFveGQxMXpGQzRuMElTR1A4VldhMGQyeXF4NEtVcEdkUTE2?=
 =?utf-8?B?QXJQMStKdXkzU0dRNVBwOUVFTHNqeDdVOVFLZUpZWksyYkRGc0hnTHFhK0dq?=
 =?utf-8?B?cjB2ZStaa1NLd2VUWlE4MHVWdWpzUVFkU1c4QUtyMGR1UWVqZ3lvWFQwTEpB?=
 =?utf-8?B?MTRMVnRRb3Q3U2h6RDUyQldJTmZIR2lCcC8xbDVJSTNLZkptb0p2YTVZWjZz?=
 =?utf-8?B?bE5maEhQYkpoY2tFZWJ2VU5MQ1I2UWErbnhERjQ4Rk9WZkFrZDFFWEtHN0o4?=
 =?utf-8?B?bzhNaEpaRm1jWTRhNVVobGR2ZDY2UG0xVmdvTWMrWFM0UHFFK2ZXeGhrUThv?=
 =?utf-8?B?MDNUZXpsc3RZWi9wY3hia2I0MmxISkZIanVVdEpiL2djM2swTUJ1OUMyRmFy?=
 =?utf-8?B?cjFIM2p0d0d2eWhIVnBySjRwdWEvYU5IZUQyQXROaDRpMEpzci96MWJmeHhq?=
 =?utf-8?Q?rlJtaBuoQmzSfaSTXQTCY0khL?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6511984e-93c7-462c-f9a7-08db81d74f51
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5462.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 06:23:15.5373
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xG1N/IHbfdCQYlZzQU/rNzjswDgJEcoPzfxLOTYkD6DtQb+4IOMk1WMRXIB50h0gh4eb0pVKd0a8v+NpKZquyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6433
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/11/2023 10:52 AM, Baolu Lu wrote:
> On 2023/7/11 9:40, Liu, Jingqi wrote:
>> On 7/4/2023 3:54 PM, Tian, Kevin wrote:
>>>> From: Liu, Jingqi <jingqi.liu@intel.com>
>>>> Sent: Monday, July 3, 2023 10:37 PM
>>>>
>>>> On 7/3/2023 3:15 PM, Tian, Kevin wrote:
>>>>>> From: Liu, Jingqi <jingqi.liu@intel.com>
>>>>>> Sent: Sunday, June 25, 2023 11:05 PM
>>>>>>
>>>>>> The original debugfs only dumps all IOMMU page tables without pasid
>>>>>> supported. It traverses all devices on the pci bus, then dumps 
>>>>>> all page
>>>>>> tables based on device domains. This traversal is from software
>>>>>> perspective.
>>>>>>
>>>>>> This series dumps page tables by traversing root tables, context 
>>>>>> tables,
>>>>>> pasid directories and pasid tables from hardware perspective. By
>>>>>> specifying source identifier and PASID, it supports dumping 
>>>>>> specified
>>>>>> page table or all page tables in legacy mode or scalable mode.
>>>>>>
>>>>>> For a device that only supports legacy mode, specify the source
>>>>>> identifier, and search the root table and context table to dump its
>>>>>> page table. It does not support to specify PASID.
>>>>>>
>>>>>> For a device that supports scalable mode, specify a
>>>>>> {source identifier, PASID} pair and search the root table, 
>>>>>> context table
>>>>>> and pasid table to dump its page table.  If the pasid is not 
>>>>>> specified,
>>>>>> it is set to RID_PASID.
>>>>>>
>>>>>> Switch to dump all page tables by specifying "auto".
>>>>>>
>>>>>> Examples are as follows:
>>>>>> 1) Dump the page table of device "00:1f.0" that only supports legacy
>>>>>> mode.
>>>>>>
>>>>>> $ sudo echo 00:1f.0 >
>>>>>> /sys/kernel/debug/iommu/intel/domain_translation_struct
>>>>>> $ sudo cat /sys/kernel/debug/iommu/intel/domain_translation_struct
>>>>>> Device 0000:00:1f.0 @0x105407000
>>>>>> IOVA_PFN                PML5E                   PML4E
>>>>>> 0x0000000000000 |       0x0000000000000000 0x0000000105408003
>>>>>> 0x0000000000001 |       0x0000000000000000 0x0000000105408003
>>>>>> 0x0000000000002 |       0x0000000000000000 0x0000000105408003
>>>>>> 0x0000000000003 |       0x0000000000000000 0x0000000105408003
>>>>>>
>>>>>> PDPE                    PDE                     PTE
>>>>>> 0x0000000105409003      0x000000010540a003 0x0000000000000003
>>>>>> 0x0000000105409003      0x000000010540a003 0x0000000000001003
>>>>>> 0x0000000105409003      0x000000010540a003 0x0000000000002003
>>>>>> 0x0000000105409003      0x000000010540a003 0x0000000000003003
>>>>>>
>>>>>> [...]
>>>>>>
>>>>>> 2) Dump the page table of device "00:0a.0" with pasid "2".
>>>>>>
>>>>>> $ sudo echo 00:0a.0,2 >
>>>>>> /sys/kernel/debug/iommu/intel/domain_translation_struct
>>>>>> $ sudo cat /sys/kernel/debug/iommu/intel/domain_translation_struct
>>>>> What about creating a directory layout per {dev, pasid} so the 
>>>>> user can
>>>>> easily figure out and dump?
>>>>>
>>>>> e.g.
>>>>>
>>>>> /sys/kernel/debug/iommu/intel/00:0a.0/0/domain_translation_struct
>>>>> /sys/kernel/debug/iommu/intel/00:0a.0/2/domain_translation_struct
>>>> Thanks.
>>>>
>>>> Do you mean create a directory for each device, whether it supports
>>>> PASID or not ?
>>> every device has PASID#0 valid, i.e. RID2PASID.
>> Sorry for the late response.
>> Got it. Thanks.
>>>> Seems the PASID can be assigned at runtime.
>>>> So it needs to support creating debugfs file at runtime in IOMMU 
>>>> driver.
>>>> Looks like this requires modifying IOMMU driver.
>>>>
>>> Isn't this patch trying to modify the driver?
>> I just tried not to modify the driver except debugfs.
>> I'll try this implementation. [
>
> I'd second Kevin's suggestion.
>
> If you check how usb xhci dumps its contexts for devices, you can see
> the similar scheme.
>
> # ls /sys/kernel/debug/usb/xhci/0000:00:14.0/devices
> 01  02  03  04  05
>
> In our case, pasid 0 is special which denotes the domain attached to the
> RID.
Thanks for your info.
This implementation is more friendly for user.
I'll implement it as such.

BR,
Jingqi