Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36399176rwd; Mon, 10 Jul 2023 23:57:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlETAkNvhtMNyMonmsDDMoK2oLAupPAek5kNtapf5LfLBGyjh6aMoencW3w1ehU41s9AQRPN X-Received: by 2002:a37:b484:0:b0:763:d495:1810 with SMTP id d126-20020a37b484000000b00763d4951810mr13845068qkf.37.1689058663567; Mon, 10 Jul 2023 23:57:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689058663; cv=none; d=google.com; s=arc-20160816; b=PmKrfyuhnFAT5jrrVE9uJosj9k0Wasw6iUqo2OpIPMnjAWv7PwfSRDWtE6oxaqOb/P QHG4Nd1Jx+KdUK2WuUDAwonkNFLJKGb20VoDDtO4wlh+IfFLH94o19zCIY+9fmnbrmO0 dAgqAJgcLJvfD+bQHkRO77aYzOKkVsItZjU1nIYyFyNSDIPwMgJw+q1/YmY6VNWhMkxu gG3D6EgCip06OubAMM0lODtxiAT05yaHwst5+QpBG0+7VC+TBYqMdlKT2bQEKtVFS2LN p6L+uKilZyaCep/uubzv1IWJjLdqF799slj+WE/LtBe+mmWP9V0gAA4SiGFWDl4Na7Rv 0ckQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pu57NWzdt05Q9NHJCtP6p+KgylR9dt5WK1iwNeomKyo=; fh=55uCnFGfGw/SxyQCKhIsZINflvsn1d/ditHtt6sCqcE=; b=S/FuSqbhlVM1hYwROxtEUXd7ALVZ2emNPo2oyatnY5mXUycUbTIaxsqdmBb5cfLyEA jco0Qa2ujZ6zPEmUF5M5LluzgRydf7pDnCuSz97s5vsK53kibKw2kKEtKcmc5dAK621q 0whRgabzXQfrYFGYkOEE0guhrb71LmrALU2vaN5wIHFwrtbqLkgOmaimTW7jjV8RzR8s FV6EyLZw9iWUWDsNhMp4FZ0KYbdjnNTrpI7lp2nXKVYwPtsvNAMXjB7QQHNFh7QohXK4 iLTogutQG0nHHHzZMM5IykQE2xZX6YnkrxC9x2UE7KHoYgAVTXFbExUL0OeY6J7uJqnC cjmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=brPXcBjo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y1-20020a1709027c8100b001b665d8d63asi1076172pll.356.2023.07.10.23.57.31; Mon, 10 Jul 2023 23:57:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=brPXcBjo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231520AbjGKGbd (ORCPT + 99 others); Tue, 11 Jul 2023 02:31:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjGKGbc (ORCPT ); Tue, 11 Jul 2023 02:31:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6BC93B8 for ; Mon, 10 Jul 2023 23:31:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0A68361325 for ; Tue, 11 Jul 2023 06:31:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CA75C433C8; Tue, 11 Jul 2023 06:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689057090; bh=qu1pd3b272tPo8ITAHMdIXv+6whUB9sDBn0ZFcwWQkA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=brPXcBjoP+slwSVt0HXm6purXk9H9Ym82SraRQtgIczKBKhPyGcO1FqMKMCU4AkuA tYmJjh8RhHZub5hKpB4g2jLRO2MDbGD8ql5nl3EOamC0/Pc96x16+aqOrilbW6Tv/S XNz8Be2FtWMAOlLbT+Zm6kCVXNjmiNgDj7GrgznglK0pELVE0BpnaVy1ty7rUJoadT kCFVEYjxfYsdgX088XjIXR7EueoKXX7MStYFINNKqXHvFzyg8/gEG1ti029LqtPm/7 xgx3QHPPa2kVwSKq6eVsDe6SU+Fzt0/vSs7MBp/BzNYlzxEtobfLdR94sbNwMsXGDU FVzgXH5D6KcwA== Date: Sun, 9 Jul 2023 12:35:05 +0300 From: Leon Romanovsky To: Suman Ghosh Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4] octeontx2-pf: Add additional check for MCAM rules Message-ID: <20230709093505.GB7619@unreal> References: <20230706173723.2226030-1-sumang@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230706173723.2226030-1-sumang@marvell.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DATE_IN_PAST_24_48, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 06, 2023 at 11:07:23PM +0530, Suman Ghosh wrote: > Due to hardware limitation, MCAM drop rule with > ether_type == 802.1Q and vlan_id == 0 is not supported. Hence rejecting > such rules. > > Fixes: dce677da57c0 ("octeontx2-pf: Add vlan-etype to ntuple filters") > Signed-off-by: Suman Ghosh > --- > Changes since v3: > - moved assignment of vlan_etype before the if check And what were changes in previous versions? Also you should write the target net or net-next in the patch subject. Thanks