Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        "Will Deacon" <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        "Jason Gunthorpe" <jgg@ziepe.ca>,
        Jean-Philippe Brucker <jean-philippe@linaro.org>,
        Nicolin Chen <nicolinc@nvidia.com>
CC:     "Liu, Yi L" <yi.l.liu@intel.com>,
        Jacob Pan <jacob.jun.pan@linux.intel.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 5/9] iommu: Make fault_param generic
Thread-Topic: [PATCH 5/9] iommu: Make fault_param generic
Thread-Index: AQHZs5RHv1DdatEmukqpigeHJWriGq+0FnVQ
Date:   Tue, 11 Jul 2023 06:14:42 +0000
Message-ID: <BN9PR11MB52763F7A1433C73CF6589F2E8C31A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230711010642.19707-1-baolu.lu@linux.intel.com>
 <20230711010642.19707-6-baolu.lu@linux.intel.com>
In-Reply-To: <20230711010642.19707-6-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Yfw/rNkClyF5HvethVKMCjkS550pltRj20iP4m4TxwvOsD//CJs2cOrIpedR?=
 =?us-ascii?Q?AYKcdwkrRICWvTn61zrgV7ZywrbWiWqpjArtZL9iz8A1Kqf3V3nrwiCFXsLv?=
 =?us-ascii?Q?po14f4Hi/fVd0uls7LyphxA04zrVf5wIx/ey2fsIqyVoJ+d7E2LmGjzd3npa?=
 =?us-ascii?Q?rTXWd3u01HtDk7cWdBcw4sawcM6Naty54gHgiaArut8Y7LSf0R0pGbIEpUb4?=
 =?us-ascii?Q?0uOdAKQm0F2XYuahP7fXLU4gyfyhagsZZzuB6zBbof8ED6lhSTbSCDLqJnnD?=
 =?us-ascii?Q?V5DQogSFGUfq2YSeTCVf1ElRUtGaPP5w6YSdaWXLzuAIg6G60DmPbSdcVaRA?=
 =?us-ascii?Q?KtyoktbipjmwWj6arOlIsjphvpq/YwlrFb1XRPBcBK8F2vyzwNe6vM7oM1iH?=
 =?us-ascii?Q?Px2rEZ7ZzrZudDv8cBtV8ay9kfLyVa6rKFcqESTjoP+vgKnCAsmI470RPIrW?=
 =?us-ascii?Q?2/WVaUoUimUtHJ1ILIdag5542ad6JH5X7GIZCrZrqg3QD4+DKhvplL8xN6wu?=
 =?us-ascii?Q?Cb+F0E0aX7wG+phqgpH6MMO1VME5VeMSQFSpZHyamZo9eVYeg8oRDd2rQ0AT?=
 =?us-ascii?Q?ogtxCbWUHKU7+TH6/y5wAEe2NJkZn9/y9bEUBRgdY4Ad2XMeyEmtobTzYw9A?=
 =?us-ascii?Q?yF5GYebEoTnZyoOtANnIA0lxS+bLp7cdwF9WPxd72d4QPOWc+gM9+ON0Mdg8?=
 =?us-ascii?Q?tf+pbROF74Ew4Js6PG5FRh5QFwpnAp16N23WPIGma18ZKjkOVDRXaZU7FMDF?=
 =?us-ascii?Q?l5nVsgkbsOCa64lzzUulU9jBKnz7XP1muQARoaho5aOcRFarR5PIb3GFLtTe?=
 =?us-ascii?Q?KuKcBbCMw5u+xnPJXFwHIEU/2VFE8ATLQQaiub10y7dOgldsrewV43QU8V3o?=
 =?us-ascii?Q?QiGSOi0Su0XpArjCbh4ZeymM5uAtKiv348+9zl7RDYKPED8Wc/gCmJ1FeE/X?=
 =?us-ascii?Q?gTKU+RKUqZLt4eYSIov7mbRiFEZtbiXOB0ObJ0SBAzw9s5sST9qaL+uBb/2K?=
 =?us-ascii?Q?GwFD3j3SEtCowN4HN3bftpnr4jIBDVy+CosxfGsGbW/X3nmSNKJO0DhVzORz?=
 =?us-ascii?Q?HZ/GOsieucB95w+YzhiCmjUQZgSGs0I79rZK+LXHTZ/7a9Yl0XBeQxUiCz70?=
 =?us-ascii?Q?PTSsn2KH8sN3asZISaBrZ/aElYw7bR5JFQYdsCqJACLF5hStuYf/Dl9+D3ll?=
 =?us-ascii?Q?C0YGygGhewG9NaArI2SEQfg0dj3EbvERvQQ5huv1IdZ0a4m5D40niQjOl9BG?=
 =?us-ascii?Q?76jaSjn8ox5bxI6JGe0HbMmgeeTMYdAFn4FLWaYr62TbftspKyg7kVDHSggy?=
 =?us-ascii?Q?QQiEAp5iri84wS9rCs1FvDmFH7KslP4SQNByL1lZbOdNL8pnvDqMlmS7i5+A?=
 =?us-ascii?Q?DpKf2T9aV8A3sd3OFuJFJKjKs76JnU8h+JzUQhqPzC43U414+U0emDUoBDVg?=
 =?us-ascii?Q?HOozRY1mvkGmvkfbFdlXdraKZhThrBww4eLFhynlmSdiPNRW756Mw7yqJNcA?=
 =?us-ascii?Q?C1U7MmHc7mYcrYbaEFWnAF6TKs4EOkW07J/icAjnGpPGRgeEKAuRWBWDRRd7?=
 =?us-ascii?Q?cXxegUxEdVSUBQKACODicg/fLcddSbCJC44gKs90?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84d65bbb-afa8-4458-a02d-08db81d61de7
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2023 06:14:42.7737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NcGo4E6hIkNomILy2MN/BPS0Anl4PfChC2yservpMKrfQhX9mRMKByLCT4RI0XlALc0n2RHF/3Lzw9DYTEOQgA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6847
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Tuesday, July 11, 2023 9:07 AM
>=20
> @@ -299,7 +299,15 @@ static int dev_iommu_get(struct device *dev)
>  		return -ENOMEM;
>=20
>  	mutex_init(&param->lock);
> +	param->fault_param =3D kzalloc(sizeof(*param->fault_param),
> GFP_KERNEL);
> +	if (!param->fault_param) {
> +		kfree(param);
> +		return -ENOMEM;
> +	}
> +	mutex_init(&param->fault_param->lock);
> +	INIT_LIST_HEAD(&param->fault_param->faults);
>  	dev->iommu =3D param;
> +
>  	return 0;
>  }

Upon above changes is it slightly cleaner to call it dev_iommu_init()
to better pair with dev_iommu_free()?