Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36406200rwd; Tue, 11 Jul 2023 00:03:53 -0700 (PDT) X-Google-Smtp-Source: APBJJlElPLfxDFk81pxg58oB2ACgbKVqH8hQ8oK+zmu5WUKgHXoU0B1QHlcZkpkqGb5qNpjwSC38 X-Received: by 2002:a17:902:d4cd:b0:1b8:17e8:5472 with SMTP id o13-20020a170902d4cd00b001b817e85472mr19151234plg.1.1689059033012; Tue, 11 Jul 2023 00:03:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689059032; cv=none; d=google.com; s=arc-20160816; b=lX12m8wHzv1d421kfJwJa4zvxoihoK+pztYPqKARpJfyDYUvissqD3/5/7AMpQM7JG slbjlKpD6z8xM93j31MQlFBFzqw+6QqTH3MaatDDTWGg1iQRyvtCtrMbE2DuQcBtRaBw xzUoFIALfzLI1Y+oNgV6HE0upxQ6qP8WZcSilT8L4uNPd4Lg2PbM6rHSR8Xchh/7BqAw 8CFJ4oGcSCjqUc7wTQemqFufnMUQ9NAZVzp/OiaXKNEo5xcyBH2gtgiY9IVodVUOhEee RuOyAnmMPjVvhNcGx8ByP5Fl3+fYKj6TaEPpeK9wg0DaKKV8wBEcXEyMlBter7+Uzcb9 GDvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=c9/kc0WI4dyKjuN5Qa/0au7x7i982DP622DiLhJgr3M=; fh=SfqW8oIKOo+s8mAa2ljMC4SffZm62kp1p7N6HOwjWQg=; b=GOcO8mjqS67t6JTsZIykyJgz9tjp52Nna9IYiNAgfXQTKzwyDNNqJyWBWxnKiOg9/9 hi106HHvDF/tf5QRvwAa+h7TQg6smNsIXcvuypiJGiVa/wg5M9X8rocwvdBTcD1K6ln3 pTMR/VJn8D+AM4uLbF8cvMnwr3hjJNTkbru2YP2MoyUg3MimIpubqLZNQ57rzikXoTPP tKtGRT7kO52hslh32o3b+Ki4dNonZQMTtckrq9oH80JREwaa1yYF+4O6hOzEtoZdGsgY tCSZQD+Oblq0EFGVKnb5Fi7kr704ujJx/zmkncaKJUOpeTFnptwGTdSagJjNG0IN/CUO X75w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L4ahMrCF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y1-20020a1709027c8100b001b665d8d63asi1076172pll.356.2023.07.11.00.03.40; Tue, 11 Jul 2023 00:03:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=L4ahMrCF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231540AbjGKGbi (ORCPT + 99 others); Tue, 11 Jul 2023 02:31:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbjGKGbg (ORCPT ); Tue, 11 Jul 2023 02:31:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8AC4116 for ; Mon, 10 Jul 2023 23:31:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4D3B861336 for ; Tue, 11 Jul 2023 06:31:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA2FFC433C8; Tue, 11 Jul 2023 06:31:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689057094; bh=rLCq6il+gOpNtxEJbxzI2Ce9xDoda14FwO05ImMBhQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L4ahMrCFfuMkTa+Noeh5oeBU+FwgSXZFMkytOsnNYj0XPzgEjioWFbsE3NsaLpWIE 6rZRtrqRB4HpkrLArsvuSeuBSDsQmJIVKHtGghV8CI001WPGBBF347q6dnwBDsbWka MeRgeU33J5rpr8FNKa3Bdmn6OI6vu2j6RpJfCvyghYvPiI6z+GWvgVxOQRxTuucJhk 5FGjxeAniw/KPT380IvmYz4Ql2wdKU70i5Q8J+puPv/8was0T93byQq2GPJbZ71Ztj poJ1exuBZBnm1Wy8osnSja63wqAoi6rYkDaJntaIhV3p7QxDGjzFFTGcKPPX7gYzKh xGqlMxbkdwQyA== Date: Tue, 11 Jul 2023 09:31:25 +0300 From: Leon Romanovsky To: menglong8.dong@gmail.com Cc: michael.chan@broadcom.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Menglong Dong Subject: Re: [PATCH RESEND net-next] bnxt_en: use dev_consume_skb_any() in bnxt_tx_int Message-ID: <20230711063125.GA41919@unreal> References: <20230710094747.943782-1-imagedong@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710094747.943782-1-imagedong@tencent.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2023 at 05:47:47PM +0800, menglong8.dong@gmail.com wrote: > From: Menglong Dong > > Replace dev_kfree_skb_any() with dev_consume_skb_any() in bnxt_tx_int() > to clear the unnecessary noise of "kfree_skb" event. Can you please be more specific in the commit message what "unnecessary noise" you reduced? > > Signed-off-by: Menglong Dong > --- > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks, Reviewed-by: Leon Romanovsky