Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <665fac58-f258-6824-5eb0-c185deac33de@gmail.com>
Date:   Tue, 11 Jul 2023 15:09:40 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
From:   John Sanpe <sanpeqf@gmail.com>
Subject: Re: [PATCH v2 2/2] libbpf: fix some typo of hashmap init
To:     Andrii Nakryiko <andrii.nakryiko@gmail.com>,
        Stanislav Fomichev <sdf@google.com>
Cc:     daniel@iogearbox.net, ast@kernel.org, andrii@kernel.org,
        martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, haoluo@google.com,
        jolsa@kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230710055614.1030300-1-sanpeqf@gmail.com>
 <ZKw+6edWZJoSPGdn@google.com>
 <CAEf4Bzb-xSmpVFM_nCX7DgLuT=tR2GRCDHa0mw8FwO-rpy3xoA@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAEf4Bzb-xSmpVFM_nCX7DgLuT=tR2GRCDHa0mw8FwO-rpy3xoA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/11/23 05:12, Andrii Nakryiko wrote:

> On Mon, Jul 10, 2023 at 10:25 AM Stanislav Fomichev<sdf@google.com>  wrote:
>> On 07/10, John Sanpe wrote:
>>> Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
>>>
>>> Signed-off-by: John Sanpe<sanpeqf@gmail.com>
>> Acked-by: Stanislav Fomichev<sdf@google.com>
>>
>> Doesn't look like it was ever used.
> Ack for the change, but the subject doesn't correspond to the change
> itself. You are not fixing typo, you are removing static
> initialization helper.

Thanks for your suggestion, I have merged the two commits and used a 
more reasonable subject in v3:

https://lore.kernel.org/all/20230711070712.2064144-1-sanpeqf@gmail.com