Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Jul 2023 09:16:44 +0200
From:   Willy Tarreau <w@1wt.eu>
To:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>
Cc:     linux-kernel@vger.kernel.org, Zhangjin Wu <falcon@tinylab.org>
Subject: Re: [PATCH v2] tools/nolibc: completely remove optional environ
 support
Message-ID: <ZK0B3Ekik+rKEyDj@1wt.eu>
References: <20230710-nolibc-environ-v2-1-78b0c465338f@weissschuh.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230710-nolibc-environ-v2-1-78b0c465338f@weissschuh.net>
Precedence: bulk

On Mon, Jul 10, 2023 at 08:01:34PM +0200, Thomas Wei?schuh wrote:
> In commit 52e423f5b93e ("tools/nolibc: export environ as a weak symbol on i386")
> and friends the asm startup logic was extended to directly populate the
> "environ" array.
> 
> This makes it impossible for "environ" to be dropped by the linker.
> Therefore also drop the other logic to handle non-present "environ".
> 
> Also add a testcase to validate the initialization of environ.

Thank you Thomas, now pushed to the same branch.

Willy