Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eafa31d1-9ead-75eb-a715-9012c233daa9@oracle.com>
Date:   Tue, 11 Jul 2023 12:50:15 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] cgroup: put cgroup_tryget_css() inside
 CONFIG_CGROUP_SCHED
Content-Language: en-US
To:     Miaohe Lin <linmiaohe@huawei.com>, tj@kernel.org,
        hannes@cmpxchg.org, sfr@canb.auug.org.au, lizefan.x@bytedance.com
Cc:     cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-next@vger.kernel.org
References: <20230711023820.3854596-1-linmiaohe@huawei.com>
From:   Kamalesh Babulal <kamalesh.babulal@oracle.com>
In-Reply-To: <20230711023820.3854596-1-linmiaohe@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0pXbCtuM1NheHBBWGJQWjdpTU1mcTMyeUhvb0pPa2hmSnQ4UjlpRi9NRUNs?=
 =?utf-8?B?aEkrMDRsRmt5bzYyOStnSld1NzRhWW9xWkp6SnhqdndUYytnQlpYNzlJMDZN?=
 =?utf-8?B?WDFVSGV1U05ueFNTejZ0em9BR0F4MXR2MXB1bmFtQjNLUmJUdlJoZ1N4TlZt?=
 =?utf-8?B?U1hpSmovYzdrMk8yVlVHL0U2ckFXclpwbWJOR1N0T2tZL2FVRXlxWldnMUVS?=
 =?utf-8?B?UHNvRzk5V2RuNXpIeXM2em91UThwY3kvNDhrcU95L0MwdCtscFFlUVI2RnBJ?=
 =?utf-8?B?Z2lQNC93L3VtZmFkdkVUMzZxVXovTHd6UW54MkZYcE9FYmlINXJUbk9ZcEFo?=
 =?utf-8?B?cXhFc1g0Q09pa0dwU3VyWVNaSWU2OXViSDdxRnRtSm1wUkNGSnB5QjhLSDEr?=
 =?utf-8?B?TGtMb1BFM25jZmZIR2hNV1NpNjRwUG0xNDc1T2tkZUh0cWYrdElDRzJKdTNk?=
 =?utf-8?B?cTZGcHRKREgwaWxTUURyMW5ONnJPb2xqa1BrZEhFaXNtcUlHZDkrcVlMUUVU?=
 =?utf-8?B?WjlyVEd3U1Z2WmpiTnVERmtyeTBoWXl1dlRhRXZUN0xFdlhNekNIdjJ5UlUr?=
 =?utf-8?B?OE01K0gvSHB6bHE5VEliM003UjRrSkRvcDhvUWl5YlBxZk02cUVoYmxjdHRs?=
 =?utf-8?B?enBpcGdIdjdGRk8vUGRkL2tTZUdlb3ppUEEwc3VrM3VMcUlxa1Roc2w2dXVx?=
 =?utf-8?B?bGZnbEtXOUREK3UvMW1KR0swazFyVE1weUFON1dBWVljMFFEcGh4aTVaR0c1?=
 =?utf-8?B?bjA5OXR1dDdiYUMrQ2I0MmtGbUtBd3Jwc0VaeHpRazMveFZ6bEd6M01USnhZ?=
 =?utf-8?B?SHJvTkI5ZlVpNkhCVXc0UlRaTFlLbUFaR3ZVV3ZzOHJnVTBqWlk5TDNYVnpU?=
 =?utf-8?B?RTBkVTBTRlVLeWlrMnZXZzFTNm02R2lTMGh5Sk5waUpzRkVzQ2UvWjhsT3Fx?=
 =?utf-8?B?YVc0RFBKN1hiZ0VSSUhXQnhsc1RQeHBBSmJ0bWhmMFRWZXFVMEFlQ2tLUndM?=
 =?utf-8?B?VzhaZnF1Y1libkRGUWZpTHAxYWxnUCtDdklXTmZWM2VjQUFTQkNlaDBWOEk4?=
 =?utf-8?B?djlyN3VLL0pzTGV6cFN6KzlhczZ1RDVQYkJTSDU1ZHdhOGVUYllZZlBJQTM2?=
 =?utf-8?B?VkZLZXZlOHZDTUhoWWQvSXMxZDJIV3d4V0d0Z2orYTVvZzhzdThjYmpLVm0x?=
 =?utf-8?B?eTYvYlNRcWtaNXJkNUxXMGM3dlhRSlZhNEs4OTZWTjA2Z2owaXViaFRhTUJ6?=
 =?utf-8?B?OGhZUHgyNzBBVEplTVcrbjBQRGRkUkVWZWdKK3IzU2RkUFRwczJQeGs1dGxr?=
 =?utf-8?B?MDVUNXUrVVh5ZkZrNzJNcWdWdGtDa1lUSThUSW9EWUpnbmRuMHpYOFMrMWlW?=
 =?utf-8?B?NWoxSmdBME1Ta1RkVnE2Z0dVc2JwTFZIaHMwbGh3RTN2elBhelBSQ3pvcGp2?=
 =?utf-8?B?Z0FodUJWUWtwa2ZvSzVEWVdyMWZQaTJ6cmVXNmpmd1BTNWpVOW9MTWRCWEZk?=
 =?utf-8?B?MXJlL2hnNDNxSmRyUzFIbDNkTVcxOFBveGdIaktrazVoalJYemJ6c29oUE1E?=
 =?utf-8?B?ekRwV3F2aFpGeXBhb0dCcU5PejkzcFVNTzRFZ0JSOWF4bVVrUW05VCtBMUpt?=
 =?utf-8?B?YUtadUZmOHUvb3NlTG9nYS9yYnVLdWZPakc5N0lRTWgrdFJLL085eTJLSUE0?=
 =?utf-8?B?aW5BenNzMVRGVVJQRUZIQWNBSDNaOXFTV0NuY2hjK1QwVzBHZW9NRUR5SEUr?=
 =?utf-8?B?ZUhMMlQxODZWZkRQb1dWbEFkMTlBUUZJb2hxRXk2Rm9IMVBENlBySnlMRkVN?=
 =?utf-8?B?azExd2c3VUdkdkVZOENRMDlUVDBnYWRSUzRFTzZvQXQvdXU1NExNN20vQlVE?=
 =?utf-8?B?a1VwT3djVm1vNXg1Ti9oZnZwc2FjRHFyK09mQ0t1RlFqSkhVRDh2Znh4WEVq?=
 =?utf-8?B?YmFWWHlvc29zTGZoWEtWZ1ZLeXEvdFJiOGhFMkhtSFpNS09KVlRVRXd0c2FB?=
 =?utf-8?B?MEMvaEVHYXBXT1FGRVo3ZDBnWlRmWjNqaFNHZXJ2UUM3dXZzR2YrREpwOEFF?=
 =?utf-8?B?dlZaUEhXbzRVNVJlaG5EVFBJZ0J6dnZoRHJ4bGYwRmdRRnZvQzB0S0NOMmQw?=
 =?utf-8?B?QkZIalhqZWN2WE9iZ0J0OU4zL1c5aTl3QjEyWmwweW16L0dyV2xzZGpEUVcr?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?VC84OFBPemtxL1U3Zm1oMlJvaG01UnhzSHRnemdlTGN4NFJValBOVytEcmNO?=
 =?utf-8?B?SEhpVDRla0QyQjY3ei8wWWdRN3d6c0lweE56K3R1NFNuRXA5VEpCRGpZbWkv?=
 =?utf-8?B?ZFNqUWY4SXVQRlVRLytnaWxDSXlSdDZHaUpzTllJK0hFRWRoaVYwYzh5VFV0?=
 =?utf-8?B?QmdiWHd3cFkzdTJNTm9tU2VnV1pBUGJxOUlUTEo0WG9kd1lsdEoxR1FZYjlI?=
 =?utf-8?B?QnBNR1ZnTTRoKzVRM211R1FNdHozRU9FUWtGVk53K2RhWFgvQmdNMENUTVla?=
 =?utf-8?B?SElyd2pBWVpGUnMyOTl4TmtaR0xQdzY5NWkyTHZlcFVlT21GSlJUdlVydFFQ?=
 =?utf-8?B?R0F4L0lxS3RucWlENHZTQyt1bXlzbklqWENYSlpUbms4ME92SDFJV1BMOUs0?=
 =?utf-8?B?VVY1NXB5NGlNbnhyTGRxZ2ZQVTB5KzRaMUx5MG9VdnhpVXVGTVJWcUdDWlBH?=
 =?utf-8?B?R2I0Y0VmaXl2MXhUR1h1bUVIcFZUVHoxNVJrOVRmbGxIVGtnVlN6RC80UG56?=
 =?utf-8?B?OW9Ob3NDQUxiQmhCVXNCS3pTMUVSOHd6ZzRRbGlvbWVHWU9veE92UUt3ZEJ5?=
 =?utf-8?B?b3JoNWl6bWtxUUxkbWYyN1hQZ0ZLUG1oMTc3VkVmK3Ftam1MMHVwcXZUOGtE?=
 =?utf-8?B?bUdld0I4L1BVTU1qeDZXbTBOT3I5K1JqbWxnZGtYU2UwRlkrT3RERkpYQnpx?=
 =?utf-8?B?L1FBK0t3WkhQZXZDWEtIRjVpU1c5MEJobXNpeFpJQ2dPcEkvVTFnWTVmQzd1?=
 =?utf-8?B?dnM4cTAxc2tDUER4VHg4M1lrbURNWVduQzl6T3JqUXpNd2dEN09pdFN0QWkw?=
 =?utf-8?B?azBLM0RvcngxTk9pVFJYSlI5a1RvUDR0MDZkRGxLaktPdWJQL0ZHVk1iY0l4?=
 =?utf-8?B?bGFEeFRWN0k2c2h0dXlYV215YUpZN1NRelF1QTlSUkVJZzZEWFg0emp1TjlY?=
 =?utf-8?B?bnplQlhnbHJENzEwZCtlOUkvY0lZeVZkaUZPU2phdG1NU2dUV25tZGJVclAy?=
 =?utf-8?B?OVFnbktUa0Y3VmYyV1ZHMm1LeGJFTXJJUXd3RFM5SnY4NXg4bTNMMWFvZjdP?=
 =?utf-8?B?MVVneEp1b1RDYlRzU0tEcTNZUFRBeVVmSjdHTmdFK3grRDVjRVlUeW51ZHFy?=
 =?utf-8?B?NkxhR0tqNDU0ZVlCcmFTUTFEVTB1ZmlyZ1dZZXVGb1ZTTGRSS0JNOTJzZ3BX?=
 =?utf-8?B?eFJwUlczTnltd0ZUR1RuK0hWdTR1N1VSRE5TOFRQUmhKKzZ3Mkg5dnM2WEty?=
 =?utf-8?Q?d9RaEi5XOgGqdkr?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93218d7f-bf4d-41b8-337e-08db81df4c67
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3001.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 07:20:26.6979
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ycp0BGjxgMPWVPKSdW+qKCD03sGoviRZekXkmMpmVYNJzuvohvn91jjqhNWoympPRFZHeqb3ztRITZvw0zV7xMRUErTvskDrv2wp4EHO8Bg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6673
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-11_04,2023-07-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 adultscore=0 mlxscore=0 spamscore=0 phishscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2307110064
X-Proofpoint-GUID: 6CTx5ruR6T3sU6D4CqNcNvOCDVA193sU
X-Proofpoint-ORIG-GUID: 6CTx5ruR6T3sU6D4CqNcNvOCDVA193sU
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/11/23 08:08, Miaohe Lin wrote:
> Put cgroup_tryget_css() inside CONFIG_CGROUP_SCHED to fix the warning
> of 'cgroup_tryget_css' defined but not used [-Wunused-function] when
> CONFIG_CGROUP_SCHED is disabled.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  kernel/cgroup/cgroup.c | 44 +++++++++++++++++++++---------------------
>  1 file changed, 22 insertions(+), 22 deletions(-)

Looks good to me, given that the only caller cgroup_extra_stat_show() is
guarded within CONFIG_CGROUP_SCHED (linux-next tree), it makes sense to,
also move cgroup_tryget_css() within the same ifdef block.

Reviewed-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>