Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2] samples/bpf: Fix compilation failure for samples/bpf
 on LoongArch Fedora
To:     Huacai Chen <chenhuacai@kernel.org>,
        Haoran Jiang <jianghaoran@kylinos.cn>
Cc:     andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
        haoluo@google.com, john.fastabend@gmail.com, jolsa@kernel.org,
        kernel@xen0n.name, kpsingh@kernel.org,
        linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
        loongarch@lists.linux.dev, martin.lau@linux.dev, nathan@kernel.org,
        ndesaulniers@google.com, sdf@google.com, song@kernel.org,
        trix@redhat.com, yangtiezhu@loongson.cn, yhs@fb.com
References: <CAAhV-H6s3N=-brDz24PfrtEKNFjvnLjbDR2NpOVDF_fN7rA53A@mail.gmail.com>
 <20230710052750.259595-1-jianghaoran@kylinos.cn>
 <CAAhV-H7orsUHDZuwcTUeWYbizcWRG4k_BPy53W7PT_MQ_2SXgw@mail.gmail.com>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <7ecc42aa-4a0f-77f7-a2ad-236270137b6e@iogearbox.net>
Date:   Tue, 11 Jul 2023 09:39:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <CAAhV-H7orsUHDZuwcTUeWYbizcWRG4k_BPy53W7PT_MQ_2SXgw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 7/10/23 7:54 AM, Huacai Chen wrote:
> Reviewed-by: Huacai Chen <chenhuacai@loongson.cn>
> 
> On Mon, Jul 10, 2023 at 1:34 PM Haoran Jiang <jianghaoran@kylinos.cn> wrote:
>>
>> When building the latest samples/bpf on LoongArch Fedora
>>
>>       make M=samples/bpf
>>
>> There are compilation errors as follows:
>>
>> In file included from ./linux/samples/bpf/sockex2_kern.c:2:
>> In file included from ./include/uapi/linux/in.h:25:
>> In file included from ./include/linux/socket.h:8:
>> In file included from ./include/linux/uio.h:9:
>> In file included from ./include/linux/thread_info.h:60:
>> In file included from ./arch/loongarch/include/asm/thread_info.h:15:
>> In file included from ./arch/loongarch/include/asm/processor.h:13:
>> In file included from ./arch/loongarch/include/asm/cpu-info.h:11:
>> ./arch/loongarch/include/asm/loongarch.h:13:10: fatal error: 'larchintrin.h' file not found
>>           ^~~~~~~~~~~~~~~
>> 1 error generated.
>>
>> larchintrin.h is included in /usr/lib64/clang/14.0.6/include,
>> and the header file location is specified at compile time.
>>
>> Test on LoongArch Fedora:
>> https://github.com/fedora-remix-loongarch/releases-info
>>
>> Signed-off-by: Haoran Jiang <jianghaoran@kylinos.cn>
>>
>> ---
>> v2:
>> use LoongArch instead of Loongarch in the title and commit message.
>> ---
>>   samples/bpf/Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile
>> index 615f24ebc49c..b301796a3862 100644
>> --- a/samples/bpf/Makefile
>> +++ b/samples/bpf/Makefile
>> @@ -434,7 +434,7 @@ $(obj)/%.o: $(src)/%.c
>>          @echo "  CLANG-bpf " $@
>>          $(Q)$(CLANG) $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(BPF_EXTRA_CFLAGS) \
>>                  -I$(obj) -I$(srctree)/tools/testing/selftests/bpf/ \
>> -               -I$(LIBBPF_INCLUDE) \
>> +               -I$(LIBBPF_INCLUDE) $(CLANG_SYS_INCLUDES) \

There's still one location in XDP_SAMPLE_CFLAGS, do we need the $(CLANG_SYS_INCLUDES)
there as well?

>>                  -D__KERNEL__ -D__BPF_TRACING__ -Wno-unused-value -Wno-pointer-sign \
>>                  -D__TARGET_ARCH_$(SRCARCH) -Wno-compare-distinct-pointer-types \
>>                  -Wno-gnu-variable-sized-type-not-at-end \
>> --
>> 2.27.0
>>
>>