Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da09fbe5-17e6-bea4-80dd-be4a0394541e@intel.com>
Date:   Tue, 11 Jul 2023 10:35:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [Intel-wired-lan] [PATCH net-next v2 06/10] ice: remove
 unnecessary (void*) conversions
To:     Su Hui <suhui@nfschina.com>, <jesse.brandeburg@intel.com>,
        <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>
CC:     <netdev@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>,
        wuych <yunchuan@nfschina.com>
References: <20230710064105.173647-1-suhui@nfschina.com>
Content-Language: en-US
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20230710064105.173647-1-suhui@nfschina.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0NTNnhPSXVLQWVmUHlpcVBHd1RBWGEyWHRQR2lGeExvQjVGbnAwbUJXcEVR?=
 =?utf-8?B?czE3TnBpZksvdGRrdEM2dW5BTk5ZZDNEVHV4eVlDbU9MOGpEQlVDT1QwUlhQ?=
 =?utf-8?B?Yis3US9waUdFVkZPRktXemxRWWR2bTV5clVPTndTRzRhNTR3SzlWbWJvU2FY?=
 =?utf-8?B?ZW9hakhzUlVWTjRDV003TGVtbEVMVzlWSTMwRGh2L3FES2tTK0hHZE16SDU3?=
 =?utf-8?B?Umw1UVVEU1l5S3RTcVZ6aE9pSXZGYkh1Z1FlYzBoNyt4eXBnRjBIYkdVVXB3?=
 =?utf-8?B?M0xWQ2s5ZHF6MDA2dzVUK3FnZmgrLzZoT2k0a0RsTWdRTFgzcGZCVUNYVzMx?=
 =?utf-8?B?K3daZUJYVUdIZUJqUWlPUlNsZTFEWFdMSXBqdGhmY3plelhONS9pSEk1M0pT?=
 =?utf-8?B?bWl2YUp2YkNSSStpcmJSODAwRksrMXpLc2czWTlsTmtLWEVEeEc0MERNZlJL?=
 =?utf-8?B?b1pSanBLYzBBa01tOWZYZmxlR1N4b2kzR1J2N1JpTjJZSXU3Skg3SU5xZVkr?=
 =?utf-8?B?SUMxdUw4Wlg3bmN0UE4rWVVIc0xaOElWOFduU2dnN2JLbW1UWmlXdHEyc0dH?=
 =?utf-8?B?NCs5RlVzQmlRSHhhSklyOXFjTC9lN21pdzVyQW9lTTVjNklhRXpMNDE1OFV6?=
 =?utf-8?B?aTNUTHcwZWxielZUcmxJMGdPeUFBTTI3dFBuRmZlK2NQTDV0MFJ6RGJrandG?=
 =?utf-8?B?RGFaUXVpUTlabjA0eU10WEY3bGhqZ1BBVWF6dU42UDRVM3Q5c0RvTDhDdG56?=
 =?utf-8?B?TG1tbk1qQTM1U2xuaFVXRzNPRHFUckpoY2tKVmhxbmVSeXptd21OZTh6L0pV?=
 =?utf-8?B?WllNNFFLR3Nyb2JkQmFZVzYyTGRYYlJYNndRaVhYbXdYdkY4QWxham9lNVBJ?=
 =?utf-8?B?SzhOVFpKSHh6OWNJK0dpVFR5MXR4WFdSL1dHTmlXM3J0YUs0SXQrOG50SFhZ?=
 =?utf-8?B?Z2k3aFkxcTgrV25QNFlxZ1NhcHhUTmRZRDQwSnI3V3NzNXpLQ0VLd3oraTl4?=
 =?utf-8?B?SDZua2NaSGMvZjZpNmZOakZ1RUtDVnBqR1ZJUFg5VU9TdDJBMTF3YUpGSXdO?=
 =?utf-8?B?Q3o0ODlxeWErRzkyU0MxSWw1dlZBNUQwZWN5VzdDeDR2RlhPMUtkdnRoZDlw?=
 =?utf-8?B?R3RMVDYyeGJiSnUxV05nd0ZtMFRlcGt4a0tZSkppZHZqelJLYlIrMjFFM2hr?=
 =?utf-8?B?RzNOZ1pBclc5ZkRiTm9TV1VhU2xNWEIyUnp4SFdUamhMTmFUaGFEN2c1Yitp?=
 =?utf-8?B?NnZGc1FTdDhCeTRxT2VJZ2JmaDkrQ2VJSTNrSmRObktBcXVjTlhkZmlHTU92?=
 =?utf-8?B?MTNCaXFHM2tmcFZMQmlTNmF5NTdCT2NjN3FNYXVDTS9pdml5SFEvRmxEQ3RG?=
 =?utf-8?B?N1hSNHRsZlRpUHZERGp0Zmhyd1RNRC9Eb01JZVIrUkN3Z0xOSUl5ZWY5eERG?=
 =?utf-8?B?MmdWWjM1STJKMXpURTVkVWI0cEdlZFZaaUpZMXp5SlIyK3Yyc1NsWFZUdjFC?=
 =?utf-8?B?ZHlvd1h4VlBsbXg4Z04yV3RwOEVMQkdvVGtYNEIzMGVYL2dSbTBua2RuQWoz?=
 =?utf-8?B?dXhlanMvaGhHSThOT3JMWGdnTjNJQXJCQlB4dzIyVWRjNEFrWVBpNkJaenpj?=
 =?utf-8?B?SWJFb21IRGVjallyLzVMUTlJa1kxbFlrd054UDJxVlhoa0orSGt0cnY5aXBo?=
 =?utf-8?B?TTNGYXNzaHlPWEZENzRqakg2VE1sK2haV0RoVGRHMzVXaGJVT3R0eDJCTE9s?=
 =?utf-8?B?Y2hKaUQzbzlZejFtcWFMU2JOVDAwR0VrVDZaQXhvM2pOajVvVm90NlIwSEtC?=
 =?utf-8?B?MHBUallTNjNIWm9oMHZ5c0F1YkFZZEF6VFBKZWV6REppeGFUbEJIZ3VIakpu?=
 =?utf-8?B?UURkZzV4elFoR0g4QWd1ekhIODdqdUFWUGFxV2VvcUg4OVJxeW5xZW81ZkNW?=
 =?utf-8?B?ZzBhV1k0ekdYSnFBN3BWQ3o2d0NRQ21SSVJuRGtNMDZJVFBXbkRDMThFOG0y?=
 =?utf-8?B?eXBsdDJWMzZZMVIyVjQ1NTI1elc4T045U0Y3WjFQUWszM0V6Z3Q4cC9CeG12?=
 =?utf-8?B?bU1zSG0vZ2wzSnF2enFEUUZ4eDNJdEpMMWdnRTVUQmQ3aGxJM3NlV3ZFbWxK?=
 =?utf-8?B?dmp3cWFpc0FvRDNKd3cwemkxdzg3a2toRkk2SzVPMk12Q1Bvbk9yelJlRjda?=
 =?utf-8?B?OWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e849f8fe-087a-4dd4-6efe-08db81e9d7f6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 08:35:55.7793
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: E38DDWA64YMqaEBtr+sUP0DxIkRU7VSBcCgfqEs4X2V55G1mkNx3Q88y9b1l8F9Yo6YX9A/uzTVE8hYsIOtaNzia0DoRhdhqzDrw2vJh6wY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6767
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/10/23 08:41, Su Hui wrote:
> From: wuych <yunchuan@nfschina.com>
> 
> Pointer variables of void * type do not require type cast.

You should rather tell what are you doing here, perhaps:
Drop casts on dim->priv access, which is "void *".

> 
> Signed-off-by: wuych <yunchuan@nfschina.com>

You have to provide your own Sign-off when sending patches of other devs.

Also, preferable format is "Name Surname <email>", not a nickname/corpo-id.

> ---
>   drivers/net/ethernet/intel/ice/ice_main.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 93979ab18bc1..52af3bd80868 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -6242,7 +6242,7 @@ static void ice_tx_dim_work(struct work_struct *work)
>   	u16 itr;
>   
>   	dim = container_of(work, struct dim, work);
> -	rc = (struct ice_ring_container *)dim->priv;
> +	rc = dim->priv;
>   
>   	WARN_ON(dim->profile_ix >= ARRAY_SIZE(tx_profile));
>   
> @@ -6262,7 +6262,7 @@ static void ice_rx_dim_work(struct work_struct *work)
>   	u16 itr;
>   
>   	dim = container_of(work, struct dim, work);
> -	rc = (struct ice_ring_container *)dim->priv;
> +	rc = dim->priv;
>   
>   	WARN_ON(dim->profile_ix >= ARRAY_SIZE(rx_profile));
>   

Code per-se looks ok