Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d9c9d8d0-3b1f-8f8e-5fbf-84448c3a20e5@redhat.com>
Date:   Tue, 11 Jul 2023 11:44:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] platform/x86: int3472/discrete: set variable
 skl_int3472_regulator_second_sensor storage-class-specifier to static
Content-Language: en-US, nl
To:     Tom Rix <trix@redhat.com>, djrscally@gmail.com,
        markgross@kernel.org
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230702134419.3438361-1-trix@redhat.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20230702134419.3438361-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 7/2/23 15:44, Tom Rix wrote:
> smatch reports
> drivers/platform/x86/intel/int3472/clk_and_regulator.c:263:28: warning: symbol
>   'skl_int3472_regulator_second_sensor' was not declared. Should it be static?
> 
> This variable is only used in its defining file, so it should be static.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>  drivers/platform/x86/intel/int3472/clk_and_regulator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/int3472/clk_and_regulator.c b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> index 61aeca804ba2..ef4b3141efcd 100644
> --- a/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> +++ b/drivers/platform/x86/intel/int3472/clk_and_regulator.c
> @@ -260,7 +260,7 @@ static_assert(ARRAY_SIZE(skl_int3472_regulator_map_supplies) ==
>   * This DMI table contains the name of the second sensor. This is used to add
>   * entries for the second sensor to the supply_map.
>   */
> -const struct dmi_system_id skl_int3472_regulator_second_sensor[] = {
> +static const struct dmi_system_id skl_int3472_regulator_second_sensor[] = {
>  	{
>  		/* Lenovo Miix 510-12IKB */
>  		.matches = {


Thank you for your patch, I've applied this patch to my fixes
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes

Note it will show up in my fixes branch once I've pushed my
local branch there, which might take a while.

I will include this patch in my next fixes pull-req to Linus
for the current kernel development cycle.

Regards,

Hans