Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>
To:     Jiri Pirko <jiri@resnulli.us>
CC:     "kuba@kernel.org" <kuba@kernel.org>,
        "vadfed@meta.com" <vadfed@meta.com>,
        "jonathan.lemon@gmail.com" <jonathan.lemon@gmail.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "vadfed@fb.com" <vadfed@fb.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "M, Saeed" <saeedm@nvidia.com>,
        "leon@kernel.org" <leon@kernel.org>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "sj@kernel.org" <sj@kernel.org>,
        "javierm@redhat.com" <javierm@redhat.com>,
        "ricardo.canuelo@collabora.com" <ricardo.canuelo@collabora.com>,
        "mst@redhat.com" <mst@redhat.com>,
        "tzimmermann@suse.de" <tzimmermann@suse.de>,
        "Michalik, Michal" <michal.michalik@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "jacek.lawrynowicz@linux.intel.com" 
        <jacek.lawrynowicz@linux.intel.com>,
        "airlied@redhat.com" <airlied@redhat.com>,
        "ogabbay@kernel.org" <ogabbay@kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "nipun.gupta@amd.com" <nipun.gupta@amd.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "linux@zary.sk" <linux@zary.sk>,
        "masahiroy@kernel.org" <masahiroy@kernel.org>,
        "benjamin.tissoires@redhat.com" <benjamin.tissoires@redhat.com>,
        "geert+renesas@glider.be" <geert+renesas@glider.be>,
        "Olech, Milena" <milena.olech@intel.com>,
        "kuniyu@amazon.com" <kuniyu@amazon.com>,
        "liuhangbin@gmail.com" <liuhangbin@gmail.com>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "andy.ren@getcruise.com" <andy.ren@getcruise.com>,
        "razor@blackwall.org" <razor@blackwall.org>,
        "idosch@nvidia.com" <idosch@nvidia.com>,
        "lucien.xin@gmail.com" <lucien.xin@gmail.com>,
        "nicolas.dichtel@6wind.com" <nicolas.dichtel@6wind.com>,
        "phil@nwl.cc" <phil@nwl.cc>,
        "claudiajkang@gmail.com" <claudiajkang@gmail.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>, poros <poros@redhat.com>,
        mschmidt <mschmidt@redhat.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "vadim.fedorenko@linux.dev" <vadim.fedorenko@linux.dev>
Subject: RE: [RFC PATCH v9 00/10] Create common DPLL configuration API
Thread-Topic: [RFC PATCH v9 00/10] Create common DPLL configuration API
Thread-Index: AQHZpc/u2XBvfmJQckCFu+3HjTH4RK+edcOAgAF/xCCAACKYgIASxLqggAAmaYCAAXNRwA==
Date:   Tue, 11 Jul 2023 10:34:11 +0000
Message-ID: <DM6PR11MB46575D14FFE115546FDC9DEB9B31A@DM6PR11MB4657.namprd11.prod.outlook.com>
References: <20230623123820.42850-1-arkadiusz.kubalewski@intel.com>
 <ZJq3a6rl6dnPMV17@nanopsycho>
 <DM6PR11MB4657084DDD7554663F86C1C19B24A@DM6PR11MB4657.namprd11.prod.outlook.com>
 <ZJwWXZmZe4lQ04iK@nanopsycho>
 <DM6PR11MB4657751607C36FC711271D639B30A@DM6PR11MB4657.namprd11.prod.outlook.com>
 <ZKv1FRTXWLnLGRRS@nanopsycho>
In-Reply-To: <ZKv1FRTXWLnLGRRS@nanopsycho>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GQFARaUlA4dnWFQgOcDFjzfBZPrBBjZpaiEz7UifZQcyvec++JpYCvZ0tVHG?=
 =?us-ascii?Q?C8rf8iJ5GCIGxntO17n+k9aaKWBtS4e43gNaSOpA9Pz/Yo6WY7HuEphPUz2o?=
 =?us-ascii?Q?zJufeNUPSnqvVj8fFA8kqkxHbQfr4kpgbJBkNB8sHQh4P6KCWOduoz+8w0v7?=
 =?us-ascii?Q?/BmBjkmEoubdBpBxt9wsqG3YmQlFy2fmgqL+aWnEYw4UC3jMh+AOW8aZtm2A?=
 =?us-ascii?Q?BfL8BJrWP3fnpUbw0jkLIXwMStL7wnHG66aT6VxS28YGFBYI3SbRhGyC/Q5Q?=
 =?us-ascii?Q?ei1fyyaIxQ4KMbmA7ggvvkWGK0B9cLJZgKQCb5sE/+P/6RmZ7+DzDsB0ODH2?=
 =?us-ascii?Q?igi4flh/y1WGpNIi4XF6oOO9T6snnqKrNneRt3dvzeVXgYKNUU7e3emuCurr?=
 =?us-ascii?Q?bqkkfuVDsEI7hRMJw8rPg5AuCqQ7ctCacjtSCoSi85cXmI7laMPQ2V6vlf6H?=
 =?us-ascii?Q?DxleD5jhJ878tJm3bhbDF2iQX68YsD+0Kfaq33kBau1ojdevA2yrL+0sz7MX?=
 =?us-ascii?Q?rl5peE24cHmbzBpxbjNdII0yvfoYC1r3KXEk6+8irwc0aJy8797mw1Mhcqu7?=
 =?us-ascii?Q?vx6o0hPrg8LeXCIVpojDuNMcycRc0S28tMFxpxI1p0YTTDXPUd1KFro5k58I?=
 =?us-ascii?Q?VfUbsZN4J6VrjqVkgzqnDs4ua/WqTdonYxhP8FXXLZBQWWrm0EYpswoynebz?=
 =?us-ascii?Q?4wgMULo8eYNqOL9wsOgF4LgNH7K5CLaJ3QORks0Ein8hginN1xj8RRvi5Nce?=
 =?us-ascii?Q?gB5BtjcHD/7M1ZV2juFr0hIyK+JTRsR4MYvCdzB4zh/OV5zjiUjYjGWTDMR5?=
 =?us-ascii?Q?KIwt6UjxsQgeVfSnNwgiiotnV5JYwpuKd4oumzDVOifiR67IVIP3f0uVDSeQ?=
 =?us-ascii?Q?F9MC22w2hOg44W6rfEjWcD8hkln76dx2+xTha9wHkggh0J4x4mPxZz/+ObDn?=
 =?us-ascii?Q?iPrwQrdQgCza3d7A22ZDTIn/1iYdkvByZ5r2pcuVa2zAg1bvzPjCaGtT8GzA?=
 =?us-ascii?Q?Lmwu2EFuwzhf0Br2ZdlQDggBN04AGZ8dBouo2s57yfkMid4Cs1XVrHI/vIX+?=
 =?us-ascii?Q?sfd+RKNOA+6fNVuXzlaLg6hm4p1DZyp5vBWspJv+7vj7OLb1p4BTc9LX8Vqo?=
 =?us-ascii?Q?nRYLxm2qf8Ncyy0LNHf+nePVkmcL86NgsTP5OV6iUyyIQ14j5fg1FuBx1DVI?=
 =?us-ascii?Q?LxluNe8TNQXmXE5NWxXwOA+3+VcZugLchdrSW0HESK8EHw3axxszGpBeGyut?=
 =?us-ascii?Q?8TtGsFepcyH0BE16AZLeV1K9LV+DEFZkQwg9NNMouqmDZlTcTBus7IdgbnKe?=
 =?us-ascii?Q?wb27kyP8uDGNd/+vniKL1PkqSFBtnuBWSrmQ4qHruhcvjD6VsQGZpzuhfpMr?=
 =?us-ascii?Q?lo19keozT/MuCfezQSQ8Je5hSB37yfgr9SmQAVMsFaT3KXk8XCCD2W/XM0tq?=
 =?us-ascii?Q?it3IBpaKAvKo8TtUzmSlAN+et0KKo/vt5MZkAuTsva+kY9VFhwKLxuz5g42t?=
 =?us-ascii?Q?eXyMpHxxc89tY2wSFvE5HkHXvhth95MDy5GXBxUg3+66JKZMt1K/0gUR9Bpa?=
 =?us-ascii?Q?10UrL3THB+/sNRpDhMkl5b8LN7RWKKKmBRfWqtoUUz1gw+1AINYmm3Nt837t?=
 =?us-ascii?Q?Vw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4657.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d5655db-b162-4e42-b562-08db81fa5dd6
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2023 10:34:11.8867
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +mn3lcps4nOfjj+VkMPcaRnJSl5eODLKYaiNB0UjKT3AC/hYnb+vwSbip7sFSTaF1vI6Dzm/BSr1Va9VrmcmzXFaUHSEemAtrO24Gu3Nz3k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4873
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>From: Jiri Pirko <jiri@resnulli.us>
>Sent: Monday, July 10, 2023 2:10 PM
>
>Mon, Jul 10, 2023 at 12:07:30PM CEST, arkadiusz.kubalewski@intel.com wrote=
:
>>>From: Jiri Pirko <jiri@resnulli.us>
>>>Sent: Wednesday, June 28, 2023 1:16 PM
>>>Wed, Jun 28, 2023 at 11:15:11AM CEST, arkadiusz.kubalewski@intel.com
>wrote:
>>>>>From: Jiri Pirko <jiri@resnulli.us>
>>>>>Sent: Tuesday, June 27, 2023 12:18 PM
>>>>>
>>>>>Fri, Jun 23, 2023 at 02:38:10PM CEST, arkadiusz.kubalewski@intel.com
>>>>>wrote:
>>>>>
>>>>>>v8 -> v9:
>>>>>
>>>>>Could you please address all the unresolved issues from v8 and send v1=
0?
>>>>>I'm not reviewing this one.
>>>>>
>>>>>Thanks!
>>>>
>>>>Sure, will do, but first missing to-do/discuss list:
>>>>1) remove mode_set as not used by any driver
>>
>>I have implemented in ice (also added back the DPLL_MODE_FREERUN).
>
>Uh :/ Why exactly is it needed in this initial submission?
>

Without mode-set there is no need for device-set at all, right?
So it is better to implement at least one set command, so we don't
need remove device-set command entirely.

>
>>
>>>>2) remove "no-added-value" static functions descriptions in
>>>>   dpll_core/dpll_netlink
>>
>>Removed.
>>
>>>>3) merge patches [ 03/10, 04/10, 05/10 ] into patches that are compilin=
g
>>>>   after each patch apply
>>
>>Hope Vadim will decide on this, the thing is merging in two patches
>>doesn't make much sense as there won't be any linking until both patches
>>are there, so most sense it would be if 3 are merged into one, but
>>then we will be back to one big blob patch issue.
>>
>>>>4) remove function return values descriptions/lists
>>
>>Fixed.
>>
>>>>5) Fix patch [05/10]:
>>>>   - status Supported
>>>>   - additional maintainers
>>>>   - remove callback:
>>>>     int (*source_pin_idx_get)(...) from `struct dpll_device_ops`
>>>>6) Fix patch [08/10]: rethink ice mutex locking scheme
>>
>>Fixed.
>>
>>>>7) Fix patch [09/10]: multiple comments on
>>>>https://lore.kernel.org/netdev/ZIQu+%2Fo4J0ZBspVg@nanopsycho/#t
>>>>8) add PPS DPLL phase offset to the netlink get-device API
>>>>
>>
>>Added few things on this matter
>>- 1 dpll level attribute:
>>  - phase-shift - measuring the phase difference between dpll input
>>    and it's output
>>- 1 dpll-pin tuple level attribute:
>>  - pin-phase-adjust - set/get phase adjust of a pin on a dpll
>>- 2 pin level attributes:
>>  - pin-phase-adjust-min - provide user with min value that can be set
>>  - pin-phase-adjust-max - provide user with max value that can be set
>>- a constant:
>>  - DPLL_PHASE_SHIFT_DIVIDER similar to DPLL_TEMP_DIVIDER for producing
>>    fraction value of measured DPLL_A_PHASE_SHIFT
>
>Again, why do we need this in this initial submission? Why it can't be a
>follow-up patchset to extend this? This way we never converge :/
>Please focus on what we have now and bring it in. Let the extensions to
>be addressed later on, please.
>

Well AFAIK, RHEL is doing some monitoring software, so the end-users need t=
his.

>
>
>>- implemented in dpll netlink and in ice
>>
>>>
>>>You are missing removal of pin->prop.package_label =3D dev_name(dev); in
>>>ice.
>>>
>>
>>I didn't touch it, as we still need to discuss it, Jakub didn't respond
>>on v8 thread.
>>I don't see why we shall not name it the way. This is most meaningful
>>label for those pins for the user right now.
>
>This is not meaningful, at all. dev_name() changes upon which pci slot
>you plug the card into. package_label should be an actual label on a
>silicon package. Why you think this two are related in aby way, makes me
>really wonder. Could you elaborate the meaningfulness of this?
>

Without this, from end-user perspective, it would be very confusing.
As in ice without any label there would 4 pins which differs only with id.
What names would you suggest?

Thank you!
Arkadiusz

>
>>
>>Thank you!
>>Arkadiusz
>>
>>>
>>>>Thank you!
>>>>Arkadiusz