Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Wang Ming <machel@vivo.com>
To:     Wang Ming <machel@vivo.com>, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
Subject: [PATCH v2] lib:Fix more error checking for debugfs_create_dir()
Date:   Tue, 11 Jul 2023 19:16:58 +0800
Message-Id: <20230711111727.2672-1-machel@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?o6Ra4tm2dDwYEu6qJzB1K9E/GF1tD9XGNpyU7Nj5GmebGQLS745O+XJJoqyU?=
 =?us-ascii?Q?Q0umEXM17ZMB335loddyrM+3skmX2CbgXqfTb6FBl9+dbCEO8uQ1tB4zrtSk?=
 =?us-ascii?Q?C/Z4i8+XKwSB7HbuiN0e0OQOjULS9FXbKWhuRtBv9lnLwfRzWbckNTjPX59r?=
 =?us-ascii?Q?1mNCIiGC3JJMYjOTpVa+SOOdACRyW28/gQEh0u5zSOAX+tETmMw+O2khGx/e?=
 =?us-ascii?Q?OkpLrFOc9TuAjxyF1+HG9zwjXTHpW+hKWg7flDfS0TOexxfs6ONZLsWz7s6x?=
 =?us-ascii?Q?UX8gktm2clEX3FTH0LInzfExqpG6EqyxMG/i2nupMFxg4JQ9Y0ixDd55l9JY?=
 =?us-ascii?Q?P+U6QFGgO0tMoDt5/5mWK9NXjRE+MgZKa9dcC7bu5BdRPhq/ZryT9oza6t4d?=
 =?us-ascii?Q?rz1g7yfDbo0/8D8Ze43jRZHpjm8juB21jP2+3BmCENng3GKypztf/cKTAdkM?=
 =?us-ascii?Q?N31cR0pnQRZj+t8gSxHhZvi8oxJfFVRH99cTqSJ332096fHrz/tcZj+MAXnD?=
 =?us-ascii?Q?Bs0HIzLx21lxePrR1bcHh87/WZOJZ/nHVPIITB+xau8ygRibbvLWfqpO/1iu?=
 =?us-ascii?Q?fM4ZkqA+xq1z3YupF2uKWKRvex1eJWiEBq1sCpiM81sUs4MHZmMFfvFBUGpp?=
 =?us-ascii?Q?HDXeQ7x00p3LU4mypr3xPsbTtHIFMQZ+b1KhPEJ0bb1txYwPvOaAFNDpzYA6?=
 =?us-ascii?Q?JgpE9d5x0g/UJ31b2XUr9K6wY6apmDsQ+CcFMII1fDUZPrcAd1hN95BG1qN6?=
 =?us-ascii?Q?MYfKZ7f3JDexq/dO6jluV+x3mady3OPEkgTim2+h4XG9ZaVrLeqTOBgErucG?=
 =?us-ascii?Q?BbI60qRcZ5anTnWoioXr7yJ/WEefTBa2espUGWfvpS1A6pxpH6Qe8aPH22Hr?=
 =?us-ascii?Q?pngzWAayQp3z/1wOh4/SSpMv9sJG/0DgtiX9BAiQxhLkBpFZ5nUfE8qLsS+Q?=
 =?us-ascii?Q?JW8B59MTWDgJbPrqbntcwW9EGpS+NtUXUOD7wxvhu9Wx6uRm1mucoN1XPxmq?=
 =?us-ascii?Q?g6/z9zP+4B5xDRmI9pHLd1rWsaqZxtWVnlUbORNwlJWi1QjmizQP70YAZ6Do?=
 =?us-ascii?Q?03gmv/zM9RUu+Eu1blo3NmuJkrEoV2VuQ740KkSl38ys43E42N76eqpGToiK?=
 =?us-ascii?Q?YbrLaF2H/asjERx7/IJSUDCVsUBuW8x9jpC58fqNzMatuykLoY0KGJxoXXvE?=
 =?us-ascii?Q?WQ5be00lFjTrkEzKEw1Kghvlbogi9GSpkd8Mkv/FOuJKscBqABhxMGUFzjRz?=
 =?us-ascii?Q?IoNswzeUFrYiRtoLhPKIQifB2IfgTah2dgOV5QoCZyb9r8RBTXlISY/E6xpQ?=
 =?us-ascii?Q?0hScZPBopclEUZCE7hqC8sc25o1lGXN30ZnRLXLgZu6sNfTaUEBLLpvm5BwT?=
 =?us-ascii?Q?t/JyZLgSJdSr+rbP3kKLJ1Rk0vSMzmOSRiVisuM8i5AXB7rTU3U4NwbnpIfK?=
 =?us-ascii?Q?BzPaCp4CZ4M4KSvpVj7xzjHGFJcRw/bsaFGAYna81OzV8TNU4vugcePswAXy?=
 =?us-ascii?Q?y5QuIquTuAxt87+Tl1YGAZCi+QHTA7PbSo+V7WoHYpOkeFZNPanlCbyf31iM?=
 =?us-ascii?Q?P6LcYwgRB6DfVNkOrKHRzNTWwnow2s6CjMl6VUq3?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69100043-87f2-4c31-e664-08db8200786a
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3743.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 11:17:53.6756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y8GAF7v/1vED+XwSvRxBltSSTzx75WI8DnpmPHYeEdYjtIZ1TmgAF8NDcxHfNaKAddHPUBD6y/2gQ7ZE+kSnvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5676
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In case of failure, debugfs_create_dir() does not return NULL,
but an error pointer.  Most incorrect error checks were fixed,
but the one in test_fpu_init() was forgotten.

Fix the remaining error check.

Signed-off-by: Wang Ming <machel@vivo.com>
---
 lib/test_fpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/test_fpu.c b/lib/test_fpu.c
index e82db19fed84..5d6aa4691b4a 100644
--- a/lib/test_fpu.c
+++ b/lib/test_fpu.c
@@ -69,7 +69,7 @@ static struct dentry *selftest_dir;
 static int __init test_fpu_init(void)
 {
 	selftest_dir = debugfs_create_dir("selftest_helpers", NULL);
-	if (!selftest_dir)
+	if (IS_ERR(selftest_dir))
 		return -ENOMEM;
 
 	debugfs_create_file_unsafe("test_fpu", 0444, selftest_dir, NULL,
-- 
2.25.1