Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36745648rwd; Tue, 11 Jul 2023 05:19:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlFBYO6pdK87CjpBvsOOKxbovsjePwSuiOgMxWKE313w64xKLvgnx/GPXo7YNDNUsNiY8RwT X-Received: by 2002:a05:6a00:248d:b0:64f:35c8:8584 with SMTP id c13-20020a056a00248d00b0064f35c88584mr18748151pfv.18.1689077973178; Tue, 11 Jul 2023 05:19:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689077973; cv=none; d=google.com; s=arc-20160816; b=gkxhEiWkBd67v/hzoD5d9bAfSbbUVLWXujsDClCP+SjkOAY/qAYffDhChyPyefJcB2 mQJGhI8qb0qp38Aa64g/hJxqa6N8IvSimVMOeN6J4nblJ/GjRXxlAxxVy8RRYVx7oNI4 acBz2enT5pvE7eyOmYH9YsryYy9ta+oNdYFXJJk09V4OPJU/i/iAQ0qxUj5aihoAafzR xYTUNEVE43osArrizJLlRho1UCE3Xg2ELLUKnXjHfSjQzIoGAH0MF6IBzSmtJA46JDR5 sygUCSu0lgVf67XznyD6s2NYvSVXsGyZ47jOYCGKa5xPozOxnIICYiwYC1LWMRb5Cey+ a2eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=e/QhJnoS7y/ObMp08VxwK92USFAKjQ9FwWsHBgOsoVw=; fh=Y7/wYgh6b1vaqi0sNcEGzziPsr8hGUpigMkldXvXOaM=; b=AHiKQu7OcDDG8B/SpT+ieHv6SQT15Y7yFqOsgPvV/+DW0foV7A5607LxX/zCIdl4+B D1CglTKWxIC/B8L08cwruCtRdGe74lNOgTF3WZFFbdXiVEa/OjeqDPZsFVPI7wiqkWrf u7TwZfO2IBG2laKZz3JPGINsjpdLCier3IuO8AagoL87Z22V3BU/xOxsEanpTRHQLRkw ZfTyPea4eFbobWCR+CbNXQ+tZdPehVtYF0IwmAaLbpY0iC2X/YCbtnOra9VkBUt8PSUC sWRIaHlzyFCSwxWM7I2MmvdVMjjgBYA99RJ0QXZuq4qBGZJc0U/h5LhpTTNrzQvoD1JE VDrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s10-20020a056a00194a00b0068224c12950si1447148pfk.64.2023.07.11.05.18.58; Tue, 11 Jul 2023 05:19:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231534AbjGKMJ2 (ORCPT + 99 others); Tue, 11 Jul 2023 08:09:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231297AbjGKMJM (ORCPT ); Tue, 11 Jul 2023 08:09:12 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DC5010E5; Tue, 11 Jul 2023 05:09:09 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 54F1667373; Tue, 11 Jul 2023 14:09:06 +0200 (CEST) Date: Tue, 11 Jul 2023 14:09:06 +0200 From: Christoph Hellwig To: Chengming Zhou Cc: Christoph Hellwig , axboe@kernel.dk, ming.lei@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: Re: [PATCH 1/2] blk-flush: fix rq->flush.seq for post-flush requests Message-ID: <20230711120906.GA27827@lst.de> References: <20230710064705.1847287-1-chengming.zhou@linux.dev> <20230710133024.GA23157@lst.de> <4431d779-e6e7-aff1-5cf8-4147de974d8d@linux.dev> <20230711113126.GA26978@lst.de> <6825f687-9573-51eb-bb89-17eadb60f71b@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6825f687-9573-51eb-bb89-17eadb60f71b@linux.dev> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 07:52:11PM +0800, Chengming Zhou wrote: > On 2023/7/11 19:31, Christoph Hellwig wrote: > > On Tue, Jul 11, 2023 at 07:06:20PM +0800, Chengming Zhou wrote: > >> Ok, will add a Fixes tag and send it as a separate patch since it's a bug fix. > > > > Btw, it's probably not worth resending patch 2 until we've figured out > > and dealt with the SATA flush regression that Chuck reported. > > Ok, I will not resend patch 2. As for the patch 1, should I resend it as a separate patch > or just put it in that series [1] before other flush optimizations ? I'd wait a bit for debugging the regression. For the worst case we'll have to revert the patch, which currently can be done cleanly, but can't be with that patch.