Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36779173rwd; Tue, 11 Jul 2023 05:45:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlGCpRHiaN5uaYSCpEg6u9oUe94KGUplHgk7KXE87piVtPwa/zl9Vk3oP1uOc2H3a0EFcnAL X-Received: by 2002:a17:907:3f0b:b0:98e:2423:708 with SMTP id hq11-20020a1709073f0b00b0098e24230708mr20640219ejc.62.1689079541713; Tue, 11 Jul 2023 05:45:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689079541; cv=none; d=google.com; s=arc-20160816; b=b2Q7UoxeMwv3F/TghBnMCbSthJFdkXkUPc/yGL+EjhWF6nEYdQNW5ndRnh3RqgMP8Z IEO2f8kd9Rfe9q2iiVvKSRF3KzefT2AWfia37opxdW2HepZSuGKcw9ftg2Yk407i3u2d HDlanD4Y4AbXIk89goLASNPsB8vuXAce0FgKitfh6mzLShWlFZxF2ZLlhWrSZNNyC07y d2WES7dygxGV0RAangwTr8x0po2jBU8Z1n6phbpN9YPuJ6GSS+pFF0CWno0Emecq+m7m i6dolO6F0df7Mdrd2p0liy5ibGBYpY2rUwW+fj3m73AxdYXLzRSIQV5NXdTfc6CEUbLw jojw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Hu/F5cIunoMaT6a9kqfbZcMI7NNurFOLxchc3V/T840=; fh=WJmoHw+mefFnb9uCfQas5jItt1+cZx6EYxsHb9LizZg=; b=B1Ep7zM5LLZjhXIrtrduA1DB8K4JA63ucpeSrHy+dzCToWU1dXw+gO+RX2jM94cYLq adbAuL8hl2Zn9UYkmIHxtozlp44s0jMENbZ9j6sHlcOnd49rC9GPAXfeLcLqorg/y22Z Gcpgq+V057SQ3zZMDvsP79bjKAtvz33FjWPlDLud0MlLo46v9DzDL3nlgarr5e64RpdI keertEzUR9NAF07Pq4K2rMT1mZ8dWvTZswYoKVwQB9CPRv6hWpDf0M3nNzVDK3HwQDxf gY9Mrp1zCUTx3T8keg5gUcEe8dWmC3O6p2q34cBrWyrNnEDajooVI1Ocv4NUxXPfhIkV BYpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Gyep6a1g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xa8-20020a170907b9c800b00992d122db36si1795856ejc.245.2023.07.11.05.45.08; Tue, 11 Jul 2023 05:45:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=Gyep6a1g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232542AbjGKMaD (ORCPT + 99 others); Tue, 11 Jul 2023 08:30:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232338AbjGKM3y (ORCPT ); Tue, 11 Jul 2023 08:29:54 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6471919A8; Tue, 11 Jul 2023 05:29:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Hu/F5cIunoMaT6a9kqfbZcMI7NNurFOLxchc3V/T840=; b=Gyep6a1gLgAdGC/Vi+oGeCj6t2 IKyL5/1RD8Tt4FNIzAW4j/atfGUaAPjhcTyA3GXH97IiwjxIU7Y/8B0fe9w8Muqivjaw/yL4bo5D4 5ZB6Z3jktax9ZhaYYlnpZ/6Oq2ASsc4zeolrABZ2MM6Kdwl61InYH3P9Iq/clR9bEshpkcTPgt83a HcgfknEVHsZHsbDQUQVwhK7+voDCXknT2H10c2k4CU3PIKN/myEz2CoJrRiGA1cFSqntUv8vLlRLZ MsgcNgtIOxR6kAkYIn3W2vzZiImwsqNNg3I5cIwMsUw6LmokGgjjMBQXCL8w1O5cla/0aNYRbdjkx RH8+Ud9g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1qJCTM-00FiF8-9q; Tue, 11 Jul 2023 12:28:04 +0000 Date: Tue, 11 Jul 2023 13:28:04 +0100 From: Matthew Wilcox To: Alexey Gladkov Cc: LKML , Arnd Bergmann , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, Palmer Dabbelt , James.Bottomley@hansenpartnership.com, acme@kernel.org, alexander.shishkin@linux.intel.com, axboe@kernel.dk, benh@kernel.crashing.org, borntraeger@de.ibm.com, bp@alien8.de, catalin.marinas@arm.com, christian@brauner.io, dalias@libc.org, davem@davemloft.net, deepa.kernel@gmail.com, deller@gmx.de, dhowells@redhat.com, fenghua.yu@intel.com, firoz.khan@linaro.org, fweimer@redhat.com, geert@linux-m68k.org, glebfm@altlinux.org, gor@linux.ibm.com, hare@suse.com, heiko.carstens@de.ibm.com, hpa@zytor.com, ink@jurassic.park.msu.ru, jhogan@kernel.org, kim.phillips@arm.com, ldv@altlinux.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, luto@kernel.org, mattst88@gmail.com, mingo@redhat.com, monstr@monstr.eu, mpe@ellerman.id.au, namhyung@kernel.org, paul.burton@mips.com, paulus@samba.org, peterz@infradead.org, ralf@linux-mips.org, rth@twiddle.net, schwidefsky@de.ibm.com, sparclinux@vger.kernel.org, stefan@agner.ch, tglx@linutronix.de, tony.luck@intel.com, tycho@tycho.ws, will@kernel.org, x86@kernel.org, ysato@users.sourceforge.jp Subject: Re: [PATCH v3 2/5] fs: Add fchmodat4() Message-ID: References: <87o8pscpny.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 01:25:43PM +0200, Alexey Gladkov wrote: > -static int do_fchmodat(int dfd, const char __user *filename, umode_t mode) > +static int do_fchmodat4(int dfd, const char __user *filename, umode_t mode, int lookup_flags) This function can still be called do_fchmodat(); we don't need to version internal functions.