Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36829569rwd; Tue, 11 Jul 2023 06:18:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlF27UEflReJAsp0dMDEtSbpbqbMNNEzBYoAsFon8LkSimpFxbHEV4ySnK3MNUbGsi/1VLc7 X-Received: by 2002:a05:6a20:7fa2:b0:130:f6bc:d6b8 with SMTP id d34-20020a056a207fa200b00130f6bcd6b8mr10928756pzj.16.1689081536256; Tue, 11 Jul 2023 06:18:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689081536; cv=none; d=google.com; s=arc-20160816; b=hygk8cir59nMUaBLQIz1a/Vm3oSdNtcISswtC69c3y6O+MNyRUMjy7nUOxHc3D3wZX Lllru20JBB/ZxU9SJQ9W/6YCk1xrMZgf5z+FLmN0mvPucTfAqsLMywOjcvaPfmCYcBya VUX1s4Cp8EwpFwk4ZmKAnMICUREFVUQ5qVwdhTECJsJF5Hi64jstFsImguWRy9ie7yEi hDl/bZnyNhJlQQbTSOv++NWJOqK/oXVetHcmUVu9oN5XyzKqmiA1PqnHzgPaiH0n/lFn Ez7uDVmeRdEBuGOW25hj10OY5u05AR9wP4UI97mQG6+WucYr3mcRgXdVuREmn11hPFA1 216Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/PNEFwUlTucptbvZ1pAkBkt7ZeLT636dqcuF1ZlanDI=; fh=SRXnBhg2jed6AaEQTtARWdVPqy39dZ/sIHDu66cw53w=; b=K3p+rGoFbxXqBMhVzPLyxDAugwBKEBk+bW4y8iedbigAQy1jCHb6eSyLRDGA0Pr/4u mU2XwS1yEhZs+giKBNv/WsaxAkG9NlEEKXTgCjOjb4J8PBfW0/HP3nNOJ2T9xaV6gygg 0FHiLZyORwm1S/NjMZMQDa14TtqRnJYK93tfKup+BAYfxyIUj5Yq8cgeSminGpSphTf2 gAiP5C+kwHCUSZVDZ5KNHE8Owbyp1Cz8Y+CYQIl+obK/RpD1R0B4B0rvtiYM7fq053UT yKN5SiItwvFc8RtaWYPvkulFDnYEhf0bWiolq+eXt8muBeDKKUr8Ksve0NIJQqQRP1xN PX8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cNjPPHJC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l129-20020a633e87000000b00543e355adb5si1376770pga.294.2023.07.11.06.18.41; Tue, 11 Jul 2023 06:18:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cNjPPHJC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232127AbjGKMuN (ORCPT + 99 others); Tue, 11 Jul 2023 08:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbjGKMuL (ORCPT ); Tue, 11 Jul 2023 08:50:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6AE098; Tue, 11 Jul 2023 05:50:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4A8FC614C8; Tue, 11 Jul 2023 12:50:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E36E0C433C8; Tue, 11 Jul 2023 12:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689079809; bh=dNf0h22e3NNw5WnIyQMA79RXwcCjXd4yUaNvlYSmEks=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cNjPPHJCjkBuTo31uxO23EaD7iBmnxEZwpJnZPbX4Xt0szcj8ZgyO+hFXrziDLnmJ WJfKsnZYW2NOQL3/ej8bLyiHu3o1cYgHqGtMbPw/xU5DUyrh9wH/uRCTzT6nteqM17 ih0fj7MI3xs3DsWKDpGWHK/svwtx6ndwsmveTHwe5/53fRS3olzp6tBliGqf9sdGX9 kN9/UPhMXhRiCAx1fAJd0t7sk9E2Jrj7YEssyG4k1JXRDx+YpYchn3i5vwcM7u3hPP uyPhDJtpjTnpxvOXge4E7SaouWn3esU19tKAKmZoLjNyYWqbKP+E5Cdjp80IatCv7m LrjabKUWygppA== Date: Tue, 11 Jul 2023 14:49:50 +0200 From: Alexey Gladkov To: Matthew Wilcox Cc: LKML , Arnd Bergmann , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, Palmer Dabbelt , James.Bottomley@hansenpartnership.com, acme@kernel.org, alexander.shishkin@linux.intel.com, axboe@kernel.dk, benh@kernel.crashing.org, borntraeger@de.ibm.com, bp@alien8.de, catalin.marinas@arm.com, christian@brauner.io, dalias@libc.org, davem@davemloft.net, deepa.kernel@gmail.com, deller@gmx.de, dhowells@redhat.com, fenghua.yu@intel.com, firoz.khan@linaro.org, fweimer@redhat.com, geert@linux-m68k.org, glebfm@altlinux.org, gor@linux.ibm.com, hare@suse.com, heiko.carstens@de.ibm.com, hpa@zytor.com, ink@jurassic.park.msu.ru, jhogan@kernel.org, kim.phillips@arm.com, ldv@altlinux.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, luto@kernel.org, mattst88@gmail.com, mingo@redhat.com, monstr@monstr.eu, mpe@ellerman.id.au, namhyung@kernel.org, paul.burton@mips.com, paulus@samba.org, peterz@infradead.org, ralf@linux-mips.org, rth@twiddle.net, schwidefsky@de.ibm.com, sparclinux@vger.kernel.org, stefan@agner.ch, tglx@linutronix.de, tony.luck@intel.com, tycho@tycho.ws, will@kernel.org, x86@kernel.org, ysato@users.sourceforge.jp Subject: Re: [PATCH v3 2/5] fs: Add fchmodat4() Message-ID: References: <87o8pscpny.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 01:28:04PM +0100, Matthew Wilcox wrote: > On Tue, Jul 11, 2023 at 01:25:43PM +0200, Alexey Gladkov wrote: > > -static int do_fchmodat(int dfd, const char __user *filename, umode_t mode) > > +static int do_fchmodat4(int dfd, const char __user *filename, umode_t mode, int lookup_flags) > > This function can still be called do_fchmodat(); we don't need to > version internal functions. Yes. I tried not to change too much when adopting a patch. In the new version, I will return the old name. Thanks. -- Rgrds, legion