Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3b085b09-bff9-7b71-6984-3dfd27a235a6@axis.com>
Date:   Tue, 11 Jul 2023 15:05:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v4 2/2] Input: cap11xx - add advanced sensitivity settings
Content-Language: en-US
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
CC:     <krzysztof.kozlowski+dt@linaro.org>, <devicetree@vger.kernel.org>,
        <linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <robh+dt@kernel.org>, <u.kleine-koenig@pengutronix.de>
References: <20230627065316.1065911-1-jiriv@axis.com>
 <20230627065316.1065911-3-jiriv@axis.com> <ZJyEpuat1A8Z+Ft4@google.com>
From:   Jiri Valek - 2N <jiriv@axis.com>
In-Reply-To: <ZJyEpuat1A8Z+Ft4@google.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUdkM0dOR3JrN0hIRUxDd1hUQjNIMWRGWGdzMHlhbU9sak9ZK254WHViMWNY?=
 =?utf-8?B?a1BUa3c4MlRkZlk0S2ZSRHI5MElnc0JmK3FLSkxyVWgrWW53TCs2Skh4MkdH?=
 =?utf-8?B?aW9xUUY0VW9ZU2RTRnI1bjF1dE1PRHpoOVR2bU80RVFNVkJNTVByUGZDK21r?=
 =?utf-8?B?K2d0YVdHU0NhOENRbWRZR0JmZWh5MThJaXFUbWJxeVJLUlkvcm4zaDZmN21H?=
 =?utf-8?B?L3BpNHdia3pyOCtKMFNrdUhCNksxWS84ZjRmSlhMQjBWd3ZXK0NNSDFodTdw?=
 =?utf-8?B?VjhSVVBUMWdUcVk3RjR0SnFZcEdnQWVJVitJZjRsMjVIMHpLampzUDFBSHNT?=
 =?utf-8?B?cFgwMlZCUnpoV3htTFJUSWhLQ2U1a2dWMlIzWlNpMGJNVUJEZlZaWGs4cHR5?=
 =?utf-8?B?QkpXVVVPck55NnlUbVorYWJWQ21pQVc3UVd0NTVhcjhhZ1VMRStlOUJnQ1BF?=
 =?utf-8?B?NjlkZ1J1bC8wQ1ZzRHFZem5WQmZjaTBBVFk3bjQvdm1EWXlIWVdZbzJEVHJp?=
 =?utf-8?B?TGNCZkNQcGtPcThKR2hvbjRTOGlhSjVjSHFLYVBraTY2eXNSOTgrVitJNXpk?=
 =?utf-8?B?ckxKUFNmM1ZlaWZKUEFPakR5bHhNUm5RWEEzVGwxWVJoeURwdEJCZEg1OWVs?=
 =?utf-8?B?dWQxN2IxTVNBVXgxanpYVnJZNGpwcXpoYUl0OFA4MHFXTFNZa2dXa1lIOXFH?=
 =?utf-8?B?ODF4cUVKRVZ5alpmbjRzWW5zUG1jU1E4NWw4MHhaNDgza3QvNWFOSG1mU1lU?=
 =?utf-8?B?bG10MDRsUHl3QU5KT3pDK1pPZ3FNbm1DMTRzSnJ6K2RqbU5yd04zU1dRWGl4?=
 =?utf-8?B?NHRaVnk3U1NOSy9ueXNIZ1laSjZoOEtLZmFWcHpHQ3g4Q2NJTGFKV01RWlFW?=
 =?utf-8?B?N0NSc1d5SUwzVDNkZGpOYmVjcFJIbDFUZm5vekthSFZFSGpjbzZKMTlmM2Ji?=
 =?utf-8?B?UzczbXVLUUxqSHVsNWIvL1V2ZGVJSzdGSU9jRzFDcFllWGJlQkNpV0VYMkF5?=
 =?utf-8?B?enVBSENVR3VOeEZlR0dmUmdPUnJHMlg1NTBkODNYVlNBRlh6TkU0Mm5EaSt5?=
 =?utf-8?B?cGNIK0VtVWdDT1lZU25LZ1R0TWV0ejVKa3Iyc2hXNlVWYUNhZVl0QXc3NHkz?=
 =?utf-8?B?bzFIVytqTmtNTlAxRnI4NmFjY2syZ09KYW9mS2RmdzJCRWxLRzVabTdzcmtC?=
 =?utf-8?B?aGtkY3NncUVIYjNkL1crN25QVFJ3WlloZXkyMFVJZU5CWHZvR2l5NVQ3MWty?=
 =?utf-8?B?RnlHRW1laHREK0FvK0xwcC85OCswYzIwTCtob0g4ZERNL1RaaDdJcFNwaGQ5?=
 =?utf-8?B?U3VKdFI2WW96aFVZRVZqVVZWTzBJczg5d2h4OS9DcURNUFI4THlUdHhrR0Iz?=
 =?utf-8?B?NHIrblAvTnVqek9vN0tvVU5TcnYzcTdRQnQxcG1tZlpWSlpZR3YveVlxRGVj?=
 =?utf-8?B?VWluYzFwcWRlVnJEbzVmOEN2SThSSE9NUUhzVlZodXQ3WExBalByenZBUFdr?=
 =?utf-8?B?SUs4d2ltZVZrdThzZHFGUW1iSlMrR0JJa1hMV1lGL3B6SGhmS3N0bTdTLzVP?=
 =?utf-8?B?MDVGb09WSjZGanQ4QmtGUmFpZXhZdFBhRnMweWZ4ZkxMSnVzZ3did09zQjRx?=
 =?utf-8?B?R0wvUFRpREFFMkVBbXd4K2lGQ2tJYnppTmluSzhmR2xsQk8raTNadlFoNnpz?=
 =?utf-8?B?dmYwRzNWdTFEU2xyM0c3NHUwZmVmZW9yd2cxVHNEUGd3OXV0ZlQ1MVJxbFhL?=
 =?utf-8?B?NXI0REgwT1pkOWxRalNnVDRGc2hVMnlYUHZLN2MvTHZLNGE4T0Vhc2NiYStR?=
 =?utf-8?B?cm8rVzcyNHEyME0zTTcya2dLZnVOTnRHNEZHWHlEUWFhT1dwMi90MFAwUkVE?=
 =?utf-8?B?b2hWOEtWVVFMdXBpQk8zWlk4S1pxOFBCRUFjSzNKZ3NUM3JOWjY5bHlZdFBF?=
 =?utf-8?B?QkZBT2tnRUxsRFkvMkxwK3h0QTRWbWlCeGpHeWtBMlV5QXVGdHY2M1NFTC90?=
 =?utf-8?B?V3dUL2U5RXJtU3ZTK3FzVTNLYm0rdlBiZW1rbC9Bbng1bWNUSHhhWjRzaGt6?=
 =?utf-8?B?ZjhRNEFxV2RiS0pHRzlNL2lDVmZzblpCelhWdktUcVZMNzhBYVFKY1h5QlZV?=
 =?utf-8?Q?K5Rp/tAf4W4japsKXTkNOhaDu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 366858dc-d03f-46aa-f554-08db820f8e77
X-MS-Exchange-CrossTenant-AuthSource: PAXPR02MB7263.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 13:05:53.0550
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jD8YNCP01XG1onPZPEytCbJR+j2ZSFmbEkGnCGWSNjjOGJWOy7tVAIR7WvjNRWUd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR02MB10165
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/28/23 21:06, Dmitry Torokhov wrote:
> Hi Jiri,
> 
> On Tue, Jun 27, 2023 at 08:53:16AM +0200, Jiri Valek - 2N wrote:
>> @@ -439,7 +589,7 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
>>  	priv->idev->id.bustype = BUS_I2C;
>>  	priv->idev->evbit[0] = BIT_MASK(EV_KEY);
>>  
>> -	if (of_property_read_bool(node, "autorepeat"))
>> +	if (of_property_read_bool(dev->of_node, "autorepeat"))
> 
> It would be good to have this driver switched from of_property_*() to
> device_property_() API.

Yes, I do this after my changes.
> 
>>  		__set_bit(EV_REP, priv->idev->evbit);
>>  
>>  	for (i = 0; i < cap->num_channels; i++)
>> @@ -474,14 +624,8 @@ static int cap11xx_i2c_probe(struct i2c_client *i2c_client)
>>  	if (error)
>>  		return error;
>>  
>> -	irq = irq_of_parse_and_map(node, 0);
>> -	if (!irq) {
>> -		dev_err(dev, "Unable to parse or map IRQ\n");
>> -		return -ENXIO;
>> -	}
>> -
>> -	error = devm_request_threaded_irq(dev, irq, NULL, cap11xx_thread_func,
>> -					  IRQF_ONESHOT, dev_name(dev), priv);
>> +	error = devm_request_threaded_irq(dev, i2c_client->irq, NULL,
>> +					cap11xx_thread_func, IRQF_ONESHOT, dev_name(dev), priv);
> 
> I would prefer this change be a separate patch.

Agree, I will prepare separate patch

> 
> Thanks.
> 

BR
Jiri