Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cfa28818-9eaf-0dc9-cb4a-1b3de318e627@leemhuis.info>
Date:   Tue, 11 Jul 2023 15:09:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Reply-To: Linux regressions mailing list <regressions@lists.linux.dev>
Subject: Re: [PATCH] HID: logitech-hidpp: rework one more time the retries
 attempts
Content-Language: en-US, de-DE
To:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Bastien Nocera <hadess@hadess.net>
Cc:     Greg KH <gregkh@linuxfoundation.org>,
        =?UTF-8?Q?Filipe_La=c3=adns?= <lains@riseup.net>,
        Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20230621-logitech-fixes-v1-1-32e70933c0b0@redhat.com>
 <2023062156-trespass-pandemic-7f4f@gregkh>
 <qbvmv3eexohswyagmllfh3xsxoftwa3wbmsdafmwak2bxlnlft@jz74dijlfxlz>
 <31ce32e018a9fa410e9e1f3e5900621b16a56091.camel@hadess.net>
 <CAO-hwJLFSUJaGK5DAOz30+YyC1hGgHnbeJbc5iQ47jxBcbRSCg@mail.gmail.com>
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@leemhuis.info>
In-Reply-To: <CAO-hwJLFSUJaGK5DAOz30+YyC1hGgHnbeJbc5iQ47jxBcbRSCg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 26.06.23 16:02, Benjamin Tissoires wrote:
> On Sun, Jun 25, 2023 at 10:30 AM Bastien Nocera <hadess@hadess.net> wrote:
>> On Fri, 2023-06-23 at 10:37 +0200, Benjamin Tissoires wrote:
>>> On Jun 21 2023, Greg KH wrote:
>>>> On Wed, Jun 21, 2023 at 11:42:30AM +0200, Benjamin Tissoires wrote:
>>>>> Make the code looks less like Pascal.
>>>>>
>>>>> Extract the internal code inside a helper function, fix the
>>>>> initialization of the parameters used in the helper function
>>>>> (`hidpp->answer_available` was not reset and `*response` wasn't
>>>>> too),
>>>>> and use a `do {...} while();` loop.
>>>>>
>>>>> Fixes: 586e8fede795 ("HID: logitech-hidpp: Retry commands when
>>>>> device is busy")
>>>>> Cc: stable@vger.kernel.org
>>>>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>>>>> ---
>>>>> as requested by
>>>>> https://lore.kernel.org/all/CAHk-=wiMbF38KCNhPFiargenpSBoecSXTLQACKS2UMyo_Vu2ww@mail.gmail.com/
>>>>> This is a rewrite of that particular piece of code.
>>>>> ---
>>>>>  drivers/hid/hid-logitech-hidpp.c | 102 +++++++++++++++++++++++--
>>>>> --------------
>>>>>  1 file changed, 61 insertions(+), 41 deletions(-)
> [...]
> 
> Some people on the Bz were able to reproduce with multiple reboots.
> But it's not as urgent as previously, and we were close to the 6.4
> final when I sent it. I'll make sure this goes into 6.5 and gets
> proper stable backports FWIW.

Did that happen? Doesn't look like it from here, but maybe I'm missing
something. Where there maybe other changes to resolve the remaining
problems some users encounter sporadically since the urgent fixes went in?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.