Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36862723rwd; Tue, 11 Jul 2023 06:41:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlGwzYTy7T1qKRqJbwBp3bfWUQ/qumVqyM2N+Ass4Ns/qZDHRHnyRoKB3VqwZ1vrkuD2q500 X-Received: by 2002:a17:90b:255:b0:262:f579:41db with SMTP id fz21-20020a17090b025500b00262f57941dbmr11227618pjb.6.1689082909029; Tue, 11 Jul 2023 06:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689082909; cv=none; d=google.com; s=arc-20160816; b=IqAP8c8BYo7nPXpWVrwGaeXf4gn1faoVTYxydtnPEByWb7EZYq2N/6kpMWxY/S9Cl4 0yE6YR5GgjTMHu6vmgv+s0SGeDsNP2UuHKAHc3g41lLsgWxVWyKGxWWOeMM+vZ2xbBEQ VrwPzmq6VW+atgLVYSd4DLgv72qG7yhLYnZpRVDwTx16qtKbkJATSn18PaO2pvJVJkie MeJzwrkrvKdU7iQvZ4i5L4cuFS0Aw5CllnOuMOKUr9p8Ehx2LozG3YVFois666DAkdk7 U/X4nTfOAdznwqRmVY33HPK4sWGoXi/y2tGLKlXmzICo+fctyqVb+CIu8rp9w6zsBOAl V7PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=CcJYk6OSmAh/ZRlDaYkuV0Et2MLWaOhRgR+ej3SaWJc=; fh=5uIZJ0APLh4qR1PQDEBNid7MRVP/4Ht3jpfBiAh7CPM=; b=SUUXhHYkh0xcbsPOdmb5WMeqhKSx0NZOY/yhjNYgLaazjaqy/PvLGZXDY6f6gypNAf jLDRJ06GXZ2ZFrYiGEfK2m5riPxKqA2quvQUVx7hZn1D6QncZk7tFQCxEPb6KsP2p/VC 3xDDxIWZkUIeb5/7tyRLPQfBkrNDcjZWAQqEW5sYvuj8aIyEm4SnzNYF/X8If227k8ns SMS4HmryC0ym8HCJHckgE7THTvINjXIGIbwqP/Q1fOjHy0TIN7ozhfuMwtGKGNFhcjY4 rk/aVb0gx+X1hAvPZ5nBNC2WTGsFN8VwN+GGLtOOO7Sfu4Ulq9OnrZ/uNSLSckrJMTvo 8/LQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=8MfxHLPn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ls12-20020a17090b350c00b00263a826ec3esi1726069pjb.52.2023.07.11.06.41.36; Tue, 11 Jul 2023 06:41:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@foss.st.com header.s=selector1 header.b=8MfxHLPn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbjGKNC2 (ORCPT + 99 others); Tue, 11 Jul 2023 09:02:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232643AbjGKNC0 (ORCPT ); Tue, 11 Jul 2023 09:02:26 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FF5C10F9; Tue, 11 Jul 2023 06:02:05 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36B9Sx2x026949; Tue, 11 Jul 2023 15:01:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=CcJYk6OSmAh/ZRlDaYkuV0Et2MLWaOhRgR+ej3SaWJc=; b=8MfxHLPnPm+POlrdjBx/RA/yUfCPOH39vHMbTd1S2+R/VXraTD7dXMVTtQNwMZJ8ZHaC eCMcTe1cxl+mAhZqaatOdWOmxwMIZ+q+t2VOp4cj4lzgFhoh0pmhCsQi7PMqkXbKbjfa z0TSvldsQCmuBz6BSPD7cGTiyjvCvFpyTXJ7OFdPQYeplLEkuBACbFjb0WZFAWmufPFp CixPugFKuJ2J4io6bnbdheD5s/FPR/KrN6ippp7I/lkVhtg/ZryKVxLjgTz/1mSDsqt2 J3zpIgCesTzBhZjq8t3canoc+iejYg3nMei9GIbjfVwaH46RjgBpAmkBtapfYsMjagKe lw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3rrs59dfe2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jul 2023 15:01:03 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B663E100070; Tue, 11 Jul 2023 15:01:01 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id A5194226FAE; Tue, 11 Jul 2023 15:01:01 +0200 (CEST) Received: from [10.201.21.122] (10.201.21.122) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 11 Jul 2023 15:01:00 +0200 Message-ID: <531a282f-9a0d-cb64-d1d1-ebaf9356b717@foss.st.com> Date: Tue, 11 Jul 2023 15:00:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 8/8] ARM: dts: stm32: Add Octavo OSD32MP1-RED board Content-Language: en-US To: Sean Nyekjaer , , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin CC: , Olivier Moysan , , , , References: <20230621063339.1361073-1-sean@geanix.com> <20230621063339.1361073-8-sean@geanix.com> From: Alexandre TORGUE In-Reply-To: <20230621063339.1361073-8-sean@geanix.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.21.122] X-ClientProxiedBy: EQNCAS1NODE3.st.com (10.75.129.80) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-11_07,2023-07-11_01,2023-05-22_02 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sean On 6/21/23 08:33, Sean Nyekjaer wrote: > Add support for the Octavo OSD32MP1-RED development board. > > General features: > - STM32MP157C > - 512MB DDR3 > - CAN-FD > - HDMI > - USB-C OTG > - UART > > Signed-off-by: Sean Nyekjaer > Reviewed-by: Olivier Moysan > --- You must update Makefile if you want I build it :). In the same time you could also ordering your phandle nodes by alphabetic order. It makes the file easier to read. Regards Alex > Changes since v1: > - Fixed comments from Ahmad > > .../arm/boot/dts/stm32mp157c-osd32mp1-red.dts | 226 ++++++++++++++++++ > 1 file changed, 226 insertions(+) > create mode 100644 arch/arm/boot/dts/stm32mp157c-osd32mp1-red.dts > > diff --git a/arch/arm/boot/dts/stm32mp157c-osd32mp1-red.dts b/arch/arm/boot/dts/stm32mp157c-osd32mp1-red.dts > new file mode 100644 > index 000000000000..f840b7faf02a > --- /dev/null > +++ b/arch/arm/boot/dts/stm32mp157c-osd32mp1-red.dts > @@ -0,0 +1,226 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > +/* > + * Copyright (C) Geanix ApS 2023 - All Rights Reserved > + * Author: Sean Nyekjaer > + */ > + > +/dts-v1/; > + > +#include "stm32mp157.dtsi" > +#include "stm32mp15xc.dtsi" > +#include "stm32mp15xx-osd32.dtsi" > +#include "stm32mp15xxac-pinctrl.dtsi" > + > +#include > +#include > + > +/ { > + model = "Octavo OSD32MP1 RED board"; > + compatible = "oct,stm32mp157c-osd32-red", "oct,stm32mp15xx-osd32", "st,stm32mp157"; > + > + aliases { > + serial0 = &uart4; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + led-controller-0 { > + compatible = "gpio-leds"; > + > + led-0 { > + label = "heartbeat"; > + gpios = <&gpiod 11 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > +}; > + > +ðernet0 { > + status = "okay"; > + pinctrl-0 = <ðernet0_rgmii_pins_a>; > + pinctrl-1 = <ðernet0_rgmii_sleep_pins_a>; > + pinctrl-names = "default", "sleep"; > + phy-mode = "rgmii-id"; > + max-speed = <1000>; > + phy-handle = <&phy0>; > + st,eth-clk-sel; > + > + mdio0 { > + compatible = "snps,dwmac-mdio"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy0: ethernet-phy@3 { > + reg = <3>; > + }; > + }; > +}; > + > + > +&i2s2 { > + clocks = <&rcc SPI2>, <&rcc SPI2_K>, <&rcc CK_PER>, <&rcc PLL3_R>; > + clock-names = "pclk", "i2sclk", "x8k", "x11k"; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&i2s2_pins_b>; > + pinctrl-1 = <&i2s2_sleep_pins_b>; > + status = "okay"; > + > + i2s2_port: port { > + i2s2_endpoint: endpoint { > + remote-endpoint = <&sii9022_tx_endpoint>; > + format = "i2s"; > + mclk-fs = <256>; > + }; > + }; > +}; > + > +&iwdg2 { > + timeout-sec = <32>; > + status = "okay"; > +}; > + > +&pwr_regulators { > + vdd-supply = <&vdd>; > + vdd_3v3_usbfs-supply = <&vdd_usb>; > +}; > + > +<dc { > + status = "okay"; > + > + port { > + ltdc_ep0_out: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&sii9022_in>; > + }; > + }; > +}; > + > +&i2c1 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&i2c1_pins_a>; > + pinctrl-1 = <&i2c1_sleep_pins_a>; > + status = "okay"; > + i2c-scl-rising-time-ns = <100>; > + i2c-scl-falling-time-ns = <7>; > + /delete-property/dmas; > + /delete-property/dma-names; > + > + hdmi-transmitter@39 { > + compatible = "sil,sii9022"; > + reg = <0x39>; > + reset-gpios = <&gpiog 0 GPIO_ACTIVE_LOW>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + interrupt-parent = <&gpiog>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <<dc_pins_e>; > + pinctrl-1 = <<dc_sleep_pins_e>; > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + sii9022_in: endpoint { > + remote-endpoint = <<dc_ep0_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + sii9022_tx_endpoint: endpoint { > + remote-endpoint = <&i2s2_endpoint>; > + }; > + }; > + }; > + }; > +}; > + > +&sdmmc1 { > + pinctrl-names = "default", "opendrain", "sleep"; > + pinctrl-0 = <&sdmmc1_b4_pins_a>; > + pinctrl-1 = <&sdmmc1_b4_od_pins_a>; > + pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>; > + cd-gpios = <&gpioe 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; > + disable-wp; > + st,neg-edge; > + bus-width = <4>; > + vmmc-supply = <&v3v3>; > + status = "okay"; > +}; > + > +&sdmmc2 { > + pinctrl-names = "default", "opendrain", "sleep"; > + pinctrl-0 = <&sdmmc2_b4_pins_a &sdmmc2_d47_pins_d>; > + pinctrl-1 = <&sdmmc2_b4_od_pins_a>; > + pinctrl-2 = <&sdmmc2_b4_sleep_pins_a &sdmmc2_d47_sleep_pins_d>; > + non-removable; > + no-sd; > + no-sdio; > + st,neg-edge; > + bus-width = <8>; > + vmmc-supply = <&v3v3>; > + vqmmc-supply = <&vdd>; > + mmc-ddr-3_3v; > + status = "okay"; > +}; > + > +&uart4 { > + pinctrl-names = "default", "sleep", "idle"; > + pinctrl-0 = <&uart4_pins_a>; > + pinctrl-1 = <&uart4_sleep_pins_a>; > + pinctrl-2 = <&uart4_idle_pins_a>; > + /delete-property/dmas; > + /delete-property/dma-names; > + status = "okay"; > +}; > + > +&m_can1 { > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&m_can1_pins_d>; > + pinctrl-1 = <&m_can1_sleep_pins_d>; > + status = "okay"; > +}; > + > +&usbh_ehci { > + phys = <&usbphyc_port0>; > + phy-names = "usb"; > + status = "okay"; > +}; > + > +&usbh_ohci { > + phys = <&usbphyc_port0>; > + phy-names = "usb"; > + status = "okay"; > +}; > + > +&usbotg_hs { > + vbus-supply = <&vbus_otg>; > +}; > + > +&usbphyc { > + status = "okay"; > +}; > + > +&usbphyc_port0 { > + phy-supply = <&vdd_usb>; > +}; > + > +&usbphyc_port1 { > + phy-supply = <&vdd_usb>; > +}; > + > +&rtc { > + status = "okay"; > +}; > + > +&crc1 { > + status = "okay"; > +}; > + > +&dts { > + status = "okay"; > +};