Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Heiko Stuebner <heiko@sntech.de>
To:     Vinod Koul <vkoul@kernel.org>,
        Kishon Vijay Abraham I <kishon@kernel.org>,
        Yangtao Li <frank.li@vivo.com>
Cc:     Yangtao Li <frank.li@vivo.com>, linux-phy@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] phy: rockchip: phy-rockchip-typec: Use
 devm_platform_get_and_ioremap_resource()
Date:   Tue, 11 Jul 2023 15:39:28 +0200
Message-ID: <4152701.ElGaqSPkdT@phil>
In-Reply-To: <20230705090126.26854-2-frank.li@vivo.com>
References: <20230705090126.26854-1-frank.li@vivo.com>
 <20230705090126.26854-2-frank.li@vivo.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Am Mittwoch, 5. Juli 2023, 11:01:24 CEST schrieb Yangtao Li:
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>

Though I guess we should check if the res variable can be removed
too.

devm_platform_get_and_ioremap_resource() checks for its "res"
parameter to be not-NULL. So if nothing in the driver itself
is using the actual resource, res could be removed and get
replaced by "NULL" when calling devm_platform_get_and_ioremap_resource()


Heiko

> ---
>  drivers/phy/rockchip/phy-rockchip-typec.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c
> index 8b1667be4915..4efcb78b0ab1 100644
> --- a/drivers/phy/rockchip/phy-rockchip-typec.c
> +++ b/drivers/phy/rockchip/phy-rockchip-typec.c
> @@ -1116,8 +1116,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  	}
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	tcphy->base = devm_ioremap_resource(dev, res);
> +	tcphy->base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>  	if (IS_ERR(tcphy->base))
>  		return PTR_ERR(tcphy->base);
>  
>