Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758431AbXJXMh0 (ORCPT ); Wed, 24 Oct 2007 08:37:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753254AbXJXMhQ (ORCPT ); Wed, 24 Oct 2007 08:37:16 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:59261 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756172AbXJXMhP (ORCPT ); Wed, 24 Oct 2007 08:37:15 -0400 Date: Wed, 24 Oct 2007 14:36:50 +0200 From: Ingo Molnar To: Avi Kivity Cc: Jeff Garzik , Adrian Bunk , LKML , akpm@linux-foundation.org, Linus Torvalds Subject: Re: [patch] kvm: fix !SMP build error Message-ID: <20071024123650.GA31562@elte.hu> References: <20071023223640.EADF31F81AC@havoc.gtf.org> <20071023224455.GY30533@stusta.de> <471E79E2.2090204@garzik.org> <471F03F5.7090608@qumranet.com> <20071024123258.GA28653@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071024123258.GA28653@elte.hu> User-Agent: Mutt/1.5.14 (2007-02-12) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.1.7-deb -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1538 Lines: 56 * Ingo Molnar wrote: > i have triggered this and fixed it the right way - see the patch > below. This fixes the 2.6.24-rc1 build error. and this followup patch is needed too if my patch is applied. Ingo -------------------> Subject: x86: fix build error in arch/x86/kernel/cpu/mtrr/main.c From: Ingo Molnar ipi_handler() must be available on !SMP too. Signed-off-by: Ingo Molnar --- arch/x86/kernel/cpu/mtrr/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) Index: linux/arch/x86/kernel/cpu/mtrr/main.c =================================================================== --- linux.orig/arch/x86/kernel/cpu/mtrr/main.c +++ linux/arch/x86/kernel/cpu/mtrr/main.c @@ -139,13 +139,12 @@ struct set_mtrr_data { mtrr_type smp_type; }; -#ifdef CONFIG_SMP - static void ipi_handler(void *info) /* [SUMMARY] Synchronisation handler. Executed by "other" CPUs. [RETURNS] Nothing. */ { +#ifdef CONFIG_SMP struct set_mtrr_data *data = info; unsigned long flags; @@ -168,9 +167,8 @@ static void ipi_handler(void *info) atomic_dec(&data->count); local_irq_restore(flags); -} - #endif +} static inline int types_compatible(mtrr_type type1, mtrr_type type2) { return type1 == MTRR_TYPE_UNCACHABLE || - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/