Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp36918547rwd; Tue, 11 Jul 2023 07:18:13 -0700 (PDT) X-Google-Smtp-Source: APBJJlE+IiGNU8weFTHW01RARzdhqL15nlvfvEfcsnx/sCSkU8yCD55/nZpoqNdWGnq3i31zqsJx X-Received: by 2002:a19:6508:0:b0:4f9:69b8:1e7c with SMTP id z8-20020a196508000000b004f969b81e7cmr11854591lfb.46.1689085092504; Tue, 11 Jul 2023 07:18:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689085092; cv=none; d=google.com; s=arc-20160816; b=AkTk/SHKgAUjAK4BdAUT41ChifYi7eJ+NEltx+apxt/er9A9c6qpZeMjXR8lX1Zx4c 97N+hZKNn7eAo43MGfYPG4wnma3PFk0ISFuW9UmqmLu0OB3VPIFVpycF83o/BSlrNzfV iyGx7q7NAjuyvDniU5V3rXmj034emDE/qtJ0hJoXkRHwsgWLW4CIcmufzlYIsIWpWvgv rUxY3CU8cF4BSEyaxhq9JONxoSwVN0dqHTT0/mTKgzUJ8w9cK/qI5etA3PhocuiBM7kN UwmPwIz3WG1wTYp0wELm04aKnuodB7mlM20EicnZlyixwE9ZlKm6XKphF/FIid6IccHf 3Y3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=NSee2d1OSPo2Hm+GehkAJUs9ucl3Ob/Im5prTS+CLLY=; fh=pSvO4/6cYTtA0p4yUVp9lG8YrNiOIvVLQhpKTj7mBNw=; b=HbiRM0BVo1BouZdXvbzOfXGzvhIpodOZtK6AKYtXR8UDeN6djsITRSa4UYuc+spqcW 7ZdtN6pZkkSKSox1Kh/gMFOs+/aB9UgIUMJhqxSNAIWfl87cBrXJCoJedfvhscOiw22I V38dTAoR5HMs5qOK+dGzkB5dne/BsoU/Pasdosoj2E9QmosDA+4UWqKA9EtiohpEn8da 0RW4ap/05+WRoa6ieyPuHAy7O7uM/hADSjRy6jdQvGLJkF7MIb2pGbrBhfWn5udsFVIb P1mJ7ES8c9ZOJRRuz2qtwGkHvzEzCGTihskWjomjpa5IzNRKgMbO1fRX36SBrsV4KDkA Y89g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cvytjGdv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p15-20020aa7d30f000000b0051e0e397ae5si2292247edq.215.2023.07.11.07.17.48; Tue, 11 Jul 2023 07:18:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cvytjGdv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233122AbjGKN4f (ORCPT + 99 others); Tue, 11 Jul 2023 09:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233116AbjGKN4d (ORCPT ); Tue, 11 Jul 2023 09:56:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2E5B10C7 for ; Tue, 11 Jul 2023 06:56:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6CA7B61509 for ; Tue, 11 Jul 2023 13:56:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58008C433C8; Tue, 11 Jul 2023 13:56:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689083789; bh=qXZaYifrGUQeoLHM3DrN40jfqkcENYlJOULXTr7bL58=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cvytjGdvzrWapWKJcPPm6KysqJl/k0pfkT+QBiYVsuAFaYSx/WXQVyHNHwa1Yn8K9 3Fje5S9+D9qILv/6gqEu8AcOxZArpJXIsdYUIuPBIVGhJj/DMQyYR1XKzUjQU88zyb vDUK2iskiVWVVEPohO5VR0Fzo0LrcSlquH5mjTu0GJOqaMfPkbk0YbJmp2b2qcp2Ac VnkEdLXDlV4JCrFuRa7xEHV26JDvy30mlCFCR1YvgvFoKk9gRwvAzAs/g5b4USTfay fY2YxsixmG1n7DvDJOp9zHGzyv+BEnhSfeFpRLWaebPX9qE5TZSfCqYZA92V/LE1lq PEsbHOaDjsasQ== Message-ID: <56c3e00b-d383-105d-29a3-570d94df4801@kernel.org> Date: Tue, 11 Jul 2023 21:56:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] erofs: avoid unnecessary loops in z_erofs_pcluster_readmore() when read page beyond EOF To: Chunhai Guo , xiang@kernel.org Cc: huyue2@coolpad.com, jefflexu@linux.alibaba.com, linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20230710042531.28761-1-guochunhai@vivo.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20230710042531.28761-1-guochunhai@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/10 12:25, Chunhai Guo wrote: > z_erofs_pcluster_readmore() may take a long time to loop when the page > offset is large enough, which is unnecessary should be prevented. > For example, when the following case is encountered, it will loop 4691368 > times, taking about 27 seconds. > - offset = 19217289215 > - inode_size = 1442672 > > Signed-off-by: Chunhai Guo Reviewed-by: Chao Yu Thanks,