Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b050086-07c5-add6-6002-d7368d532566@quicinc.com>
Date:   Tue, 11 Jul 2023 19:43:58 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/6] dt-bindings: thermal: tsens: Add nvmem cells for
 calibration data
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <amitk@kernel.org>,
        <thara.gopinath@gmail.com>, <rafael@kernel.org>,
        <daniel.lezcano@linaro.org>, <rui.zhang@intel.com>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <quic_varada@quicinc.com>
References: <20230710103735.1375847-1-quic_ipkumar@quicinc.com>
 <20230710103735.1375847-2-quic_ipkumar@quicinc.com>
 <09e33a89-c060-69b1-b94f-b21c45d1d249@linaro.org>
 <59ea653e-c5da-71cb-eb85-1aa3c72e2089@quicinc.com>
 <37aa7ae8-206e-3a48-b90d-22d49e86c675@linaro.org>
From:   Praveenkumar I <quic_ipkumar@quicinc.com>
In-Reply-To: <37aa7ae8-206e-3a48-b90d-22d49e86c675@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/11/2023 3:22 PM, Krzysztof Kozlowski wrote:
> On 11/07/2023 11:39, Praveenkumar I wrote:
>> On 7/11/2023 1:40 AM, Krzysztof Kozlowski wrote:
>>> On 10/07/2023 12:37, Praveenkumar I wrote:
>>>> Add TSENS V2 calibration nvmem cells for IPQ5332
>>>>
>>>> Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com>
>>>> ---
>>>>    .../bindings/thermal/qcom-tsens.yaml          | 26 +++++++++++++++++--
>>>>    1 file changed, 24 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>>> index 27e9e16e6455..8b7863c3989e 100644
>>>> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>>> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
>>>> @@ -91,7 +91,7 @@ properties:
>>>>        maxItems: 2
>>>>    
>>>>      nvmem-cells:
>>>> -    oneOf:
>>>> +    anyOf:
>>>>          - minItems: 1
>>>>            maxItems: 2
>>>>            description:
>>>> @@ -106,9 +106,13 @@ properties:
>>>>            description: |
>>>>              Reference to nvmem cells for the calibration mode, two calibration
>>>>              bases and two cells per each sensor, main and backup copies, plus use_backup cell
>>>> +      - maxItems: 17
>>>> +        description: |
>>>> +          V2 of TSENS, reference to nvmem cells for the calibration mode, two calibration
>>>> +          bases and one cell per each sensor
>>> I think this is already included in one of the previous entries.
>>> Otherwise, are you sure that all new devices will have exactly 17 entries?
>> Previous entries does not support TSENS version 2.X.X QFPROM. TSENS V2
>> QFPROM has mode, base0, base1 and s[0-15]+_offset.
>> Ideally it should be like,
>> - minItems: 4
>> - maxItems: 19
> I see it covered:
> minItems: 5
> maxItems: 35
>
> I think 17 is between 5 and 35.
Okay, will remove the nvmem-cells entry.
>
>> But dt binding check fails in oneOf / anyOf condition. So added the
>> IPQ5332 properties which is exactly 17.
>>>>    
>>>>      nvmem-cell-names:
>>>> -    oneOf:
>>>> +    anyOf:
>>>>          - minItems: 1
>>>>            items:
>>>>              - const: calib
>>>> @@ -205,6 +209,24 @@ properties:
>>>>              - const: s9_p2_backup
>>>>              - const: s10_p1_backup
>>>>              - const: s10_p2_backup
>>>> +      - items:
>>>> +          - const: mode
>>>> +          - const: base0
>>>> +          - const: base1
>>>> +          - const: s0_offset
>>>> +          - const: s3_offset
>>>> +          - const: s4_offset
>>>> +          - const: s5_offset
>>>> +          - const: s6_offset
>>>> +          - const: s7_offset
>>>> +          - const: s8_offset
>>>> +          - const: s9_offset
>>>> +          - const: s10_offset
>>>> +          - const: s11_offset
>>>> +          - const: s12_offset
>>>> +          - const: s13_offset
>>>> +          - const: s14_offset
>>>> +          - const: s15_offset
>>> Don't introduce new naming style. Existing uses s[0-9]+, without offset
>>> suffix. Why this should be different?
>> As I mentioned above, s[0-9]+_p1 / s[0-9]+p2 is for TSENS V1. TSENS V2
>> QFPROM layout is different from the existing one.
> I know, I did not write about p1/p2.
>
>> I would like to add mode, base0, base1 and 16 patterns
>> '^s[0-15]+_offset$'. But DT binding check is failing in oneOf/ anyOf
>> condintion.
> This does not explain why you need different style - this "offset" suffix.
In QFPROM, the BIT field names are s0_offset, s3_offset to s15_offset. 
s1_offset and s2_offset not present in IPQ5332.
Hence used the same "offset" suffix here. May I know in this case, which 
nvmem-cells-names you are suggesting to use?

--
Thanks,
Praveenkumar
>
> Best regards,
> Krzysztof
>