Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <23267466-dc1e-5f39-ce6c-45f0f61f281c@infradead.org>
Date:   Tue, 11 Jul 2023 07:50:14 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text
Content-Language: en-US
To:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Tejun Heo <tj@kernel.org>,
        Lai Jiangshan <jiangshanlai@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>
Cc:     linux-kernel@vger.kernel.org
References: <5fc042e1d3c5d63b9367a1e1587dcf6b548087ff.1689071768.git.geert+renesas@glider.be>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <5fc042e1d3c5d63b9367a1e1587dcf6b548087ff.1689071768.git.geert+renesas@glider.be>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/11/23 03:38, Geert Uytterhoeven wrote:
> There exists no parameter called "cpu_intensive_threshold_us".
> The actual parameter name is "cpu_intensive_thresh_us".
> 
> Fixes: 6363845005202148 ("workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  lib/Kconfig.debug | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index c8371502b4b2e678..5da00849edebafdd 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1200,7 +1200,7 @@ config WQ_CPU_INTENSIVE_REPORT
>  	help
>  	  Say Y here to enable reporting of concurrency-managed per-cpu work
>  	  items that hog CPUs for longer than
> -	  workqueue.cpu_intensive_threshold_us. Workqueue automatically
> +	  workqueue.cpu_intensive_thresh_us. Workqueue automatically
>  	  detects and excludes them from concurrency management to prevent
>  	  them from stalling other per-cpu work items. Occassional
>  	  triggering may not necessarily indicate a problem. Repeated

-- 
~Randy