Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b17104fe-a743-e933-288b-9245887b3a2c@intel.com>
Date:   Tue, 11 Jul 2023 08:28:13 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.12.0
Subject: Re: [PATCH v2] ACPI: NFIT: limit string attribute write
To:     Ben Dooks <ben.dooks@codethink.co.uk>, <nvdimm@lists.linux.dev>
CC:     <linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lenb@kernel.org>
References: <20230711093708.23692-1-ben.dooks@codethink.co.uk>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230711093708.23692-1-ben.dooks@codethink.co.uk>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkhFbUs4YTc5L2Jyd0Y2azIzU1RkZ0tXQ2x5aGRTVzNFcXFqTUxvOVdyNU1q?=
 =?utf-8?B?cForNi9GSW1YUzY1OGpJN05aTndyQnRMejNsZzRIbTBTaDMvZnNVZ3cvYWtw?=
 =?utf-8?B?Q1BDOHRxaEJZYmE5SWFoRDR6ajh5bk5CWUhVYTlSUXp0eXMvb2swNEcyQXBC?=
 =?utf-8?B?SzBPQnVsTzhsaGFaNFJxMEx2USswSnJmdjkxSFRzZXlZN3dKREZRUGRzeEk0?=
 =?utf-8?B?cDhvYUtuMmM4Z2xUTkR3Q3NRdTZtVlVwSURZYVVwOEExZXFKQ0F6OHBsVE10?=
 =?utf-8?B?bmR5WFhSTHAxTmNsMzBKSkt3ajhYTG5vS013SHoya2RJQloyWERaeGdmVncv?=
 =?utf-8?B?eGZOMnRLVVVMbmMvTWhYOTI2b1QrcU9lYUFhaXllbnNUa1FJV3BSZGVkWGFS?=
 =?utf-8?B?WjRFTEVMcTNFN1VIblVQUjNMd0dQc2JCNTBPa0JPRnRZSDZqMEdEM1hPZmxV?=
 =?utf-8?B?bjBMVmU1OXBOM3JDVHk4TDJjSGhqSGRYc2I2ZU5JWk1WTEJMcks4QUhEeTJW?=
 =?utf-8?B?L3ZEaFBHekVFcXhaQ05qV25HRW9zRjJiR0M3cHRGWlphUDdGMkU4Qk8yaVNa?=
 =?utf-8?B?WWQ3MENvMmpiYUFzTG5CbVB6clh4QWFoUW94T3k2TmZ6Q2NjYWJKYTVKbmJN?=
 =?utf-8?B?cmNYTS9lNXQ0M3hmRkJKdEdzNVlLQlFVM1VZMU92dWRZNzBUY0ZJQS9qaEtD?=
 =?utf-8?B?QUJNU0hITkpWeStCS2VDbjl1dW5JcVpmMlhXdGZCZVJYYStyZzFNMUREelMw?=
 =?utf-8?B?UWlEd29TTFFzc2tYNFpNaDNUMUNlbEFENExITHBzR2RPcGFML1Q2S2RUQXFT?=
 =?utf-8?B?NU1HV3l5UTJrMW1NM1RYRFRrWVdvUGEzNnJoU2hWdUljRWF0ZFVOK2V1YzJH?=
 =?utf-8?B?cEJaK0FtRUdEcVpmcmREek5YUkFOTGtybHgvcGczZmZvSUFqYVdoTmZqUU1j?=
 =?utf-8?B?MENJRDNTU2k4dnJBTXdBcDhxMFFEU2NBV3h6d1pCSSs0NFM4bUtxd0RVdTRh?=
 =?utf-8?B?aERFVi9DUGwzNTdqUE5SYmlaY1pjNCtSRDdpc1NmL3o1VUZMQTFCNEJDc0I2?=
 =?utf-8?B?TUc3TVlwZEozRWoyV0JaMGhuZzVxN09HSXRrMDI1YzJ5WDJmcmY3aHVHMmU1?=
 =?utf-8?B?b1cvUG84dllVZmk1Z1NDclpiV1l2bEZGTExDVDBMSGp6T0NJaGo1UkhaWDNY?=
 =?utf-8?B?TUFGckxHeWlWV3Nud1BsTDkyL1ZJM2plenlmUFEzeWx5VVZlbjAzT3IvSkVj?=
 =?utf-8?B?c0VzL29uNHlVa2N3dDRvdDRxbUdldjBPcG1McldiMTJqVlpIaGlaZ1NnZ0FY?=
 =?utf-8?B?VVlCNGJCZlZVRkdTRXpWQStXNllENnB4ay9KQVZuc2xWUmMwZWpjd3FRZWE0?=
 =?utf-8?B?bzNZMUhJRGFiWGNYaklYOVEyTG9wVG9xWGswa1BZNjhIakJWb29YYVp6TFFB?=
 =?utf-8?B?SVpJek1aUXJ0dFd5bkY0OEprVlRmVlcxeU1ZZDh4UGlWMU4wR1pXdE9EVitz?=
 =?utf-8?B?ZHNmbUdTTzlzb2R3ZDhxRWZ4U1Rhc2VISHFoazIwczFZMmt0NzFoNnhFa3FU?=
 =?utf-8?B?RTR5RlZuU3VYK0JmL0JNbEdhQlMwakVGK3JSaHNVSHFHejZHR0d3QmRYd3dP?=
 =?utf-8?B?cFNGRmhGMHI3M1NiRUNGZ1RTcHd5TVo4MXZxbHVZdGpZdWRmemdRSUlmYmdC?=
 =?utf-8?B?dE1XaFdna2RBVzhrSGpRbjFpY3RueW5mUnpwd3g1TXFaWjRzcXRZVnVCWXBN?=
 =?utf-8?B?djJFZDBZbDZpSXlLaHZlNmpyM2tJVnRWdktLTjRBYzdGMVR6Z0Y5a3hVTUNB?=
 =?utf-8?B?NWFxaytSV0NDWkRiMTZTUCtoZ0Ird2FkMW9SSlFUTzBNVVZvTkpHcDRGZ0JT?=
 =?utf-8?B?d2V2TDZ5Nm1pYkZMTHJ4R1J0Ynlsd2lnZENYS0ZtR1R1NmVuWFVkQXFjUThh?=
 =?utf-8?B?R1lKZGxoemhQcHRyN3hjbTdWQWRxcHNIcmZPZGpnbjRkaXJ1NTYxL0xaN25Z?=
 =?utf-8?B?akpZRDNldys4Q1Vid0JUekZISm9nMHdVdVcrU0pCZm9aWXJhaWMzKzAvUGdH?=
 =?utf-8?B?OXM3YWp5ZDV0ZEVRWE9OM1hucWYzclZuSjVsSjhKZFYrRTg3VTI5d3JJWDZo?=
 =?utf-8?Q?4z+hDf1NTpmdkyWjCC1NAWBcb?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 27eabd39-36fb-4329-a0d6-08db822372c6
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 15:28:16.7166
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hUAWmpRDf+68cuAmaiW44RpVUnzZtjm50yhyTi8Uxqb5WwmX/e9P+oM7wGlRU+GQftM15LjJtMf1ys9qMCI/rA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6963
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/11/23 02:37, Ben Dooks wrote:
> If we're writing what could be an arbitrary sized string into an attribute
> we should probably use sysfs_emit() just to be safe. Most of the other
> attriubtes are some sort of integer so unlikely to be an issue so not
> altered at this time.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> v2:
>    - use sysfs_emit() instead of snprintf.
> ---
>   drivers/acpi/nfit/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 9213b426b125..d7e9d9cd16d2 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1579,7 +1579,7 @@ static ssize_t id_show(struct device *dev,
>   {
>   	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
> -	return sprintf(buf, "%s\n", nfit_mem->id);
> +	return snprintf(buf, PAGE_SIZE, "%s\n", nfit_mem->id);

Doesn't look like you updated your patch with your new changes....

>   }
>   static DEVICE_ATTR_RO(id);
>