Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Jul 2023 11:27:34 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Ryan Roberts <ryan.roberts@arm.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        maple-tree@lists.infradead.org
Subject: Re: [PATCH v4 18/49] mlock: Convert mlock to vma iterator
Message-ID: <20230711152734.hith252qxjbnz4bt@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Ryan Roberts <ryan.roberts@arm.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        maple-tree@lists.infradead.org
References: <20230120162650.984577-1-Liam.Howlett@oracle.com>
 <20230120162650.984577-19-Liam.Howlett@oracle.com>
 <50341ca1-d582-b33a-e3d0-acb08a65166f@arm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <50341ca1-d582-b33a-e3d0-acb08a65166f@arm.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zg7bGf1PFakdrTGeCJL39deB1vfpHb1y2p+CScOfPdiCnep6dNAPTOzrA1bA?=
 =?us-ascii?Q?5pxxjmVi7l9XqHUANy11DdXiMs60mQiCe1gyDJsRELWlnuizcig6vi0hGLYs?=
 =?us-ascii?Q?J6X/VIQOwDCXC/EAPYhxUMh9BsRwbYFFmQDH7/LBxJC7myZIefWntMNLmTTR?=
 =?us-ascii?Q?SbLc7WOaF1Bce9/4MXY19ECT8uSay2FRfbDKV9rWCWs/Dzr61UqCCawmnbFX?=
 =?us-ascii?Q?l2Ptv7P37HS5IqNLX8GS0VPXE1JmrJ8GQTJ7DGVA8hrxEf2Xr/6KbsrG0MpY?=
 =?us-ascii?Q?wSKd7YxOSoUWRmHi0HwHgOkzTohqK4wSEE1SthHyp802IQDcHHqF7yQ104eu?=
 =?us-ascii?Q?d7wWHvJBMgEdUhNvdbCtbd1bI7jrHY0blHUlsZJTzc5J81GPCClWMyOBdA6O?=
 =?us-ascii?Q?Wt0wHAgOBGGE7W9CG51wqg0uoHMOEcXXTvqKHTwe8Z9SBuJrnFg/uPRCA3Am?=
 =?us-ascii?Q?sfBnKLIBCrmuZ4I6C7JcEZHXbVUA0CSPSQoy/PHUutzBSclB7WLrTP6EL/sd?=
 =?us-ascii?Q?BJ4lyik9oxjQh+JBxoEXPWm5tpKAd++rDTQaG6Gf5l40Z2YvIROWVpKON3B+?=
 =?us-ascii?Q?VUqLkmZy4+0JpAGX0ilMc4nvbmmrXvcQjw1SCbmxwIBoaVAjxOAh4wvtV/nR?=
 =?us-ascii?Q?dH4oidNaAvuTmY3J96LhzwWj2zevtdpbERFkh7t/lesDsbsEJnbAW32zbx7V?=
 =?us-ascii?Q?LwOj9auSnW6GMfiL54ymLqkjR85xvbRdb9IwAYTuj74Gc/e1IdY04qFUcnJ4?=
 =?us-ascii?Q?ucCt7p0y0MfJEbknR6H9bsC1AB4U/rJ4ACQAonr9Ej02A95gVf9WgJwe2y7C?=
 =?us-ascii?Q?wM6O+XEB2nk02cXNp6IcfXBpfMB8iuXxKQ4MFvNxOzGOdRahgVjZMd9rs7NA?=
 =?us-ascii?Q?6pa9HOZS+hfXI5DsRar++Ea8xuNafB/14wgvDTVFFzDQlgeNgs+HlBpVN6Zn?=
 =?us-ascii?Q?xIHzMIs+d1MnzW6ek8JZeVw1yD63bnonVBQqyO5g70C/a0vKQF0gByAIAzpm?=
 =?us-ascii?Q?3tuLcMnDuv14PW8tdScLycCBIeQRu6qDKSyr8l8brCc5YFtU86faTe2prVRg?=
 =?us-ascii?Q?5iHjPMMtgn+cV7GegECM8ZIO1ZWpOwQr9Sg619YvyR8yPLFQmFRkok7E6tBt?=
 =?us-ascii?Q?pMsqxbew/jqUEQKF6LiLW2StjwAqFhV2DhNDFkMleVjwWxknYz23aisHsJ3X?=
 =?us-ascii?Q?urCUG/obAlPoCUJ36fMkNw9vCnh25Ly9ELkUgeeQwCxVTcGSvcNSgdFMH/af?=
 =?us-ascii?Q?hWExPEypNXoBJJgdRAvkJBF3Nn0lkZ/Y8jc9gbcpf9W3X1viFSNuYilRQaa2?=
 =?us-ascii?Q?VsBKai1nHbWt5OYIvrDIWuuJ+Zg7AYqqdi6Exu3rEHPg6vVr73jymEG5+XwX?=
 =?us-ascii?Q?svR7sy5h0GF0BCdKqXIjq1GGYYNN8LdJQDTVOUnF37U/vB2J5zHO3bsBtD3X?=
 =?us-ascii?Q?mnX8+05eBVuCxh1et9jq80UUB+vE+UlBIquHVArnUMgSezUv9CmotOSgx9AX?=
 =?us-ascii?Q?tYwmI+tP3d1fCLih6TT07o+QxSbeB6AzMMJQybtHnCzqqWZZAdSWAxeS1R5T?=
 =?us-ascii?Q?utCqsQ0FD7JsqMa9TIvKwOI5FfeoT1rSgdFF52RCJfBVPTgWWhcNv6cebNgl?=
 =?us-ascii?Q?Yw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vJOtDlmJTEZculMkrVsH7dOVK4LqPEPqkgNIsTBCup4uWvJ/yG5SEdZvAp6jEejRIyffHshJk0Opepfg/ASDW1Gwmf6GXdBlE6Vu2/sS7wAcXB7eZDRxKHEB5JD+HO/MP7Rh//ZN9DMdv0kMl5m0EvOmY0t27rT3HP9HwyJn+BstPCZEs8o4cseocq/KJfYNics7MxEe9aa08QZPYJqS7IIaGtztfjnzr7bXVp3JS0fEjZ7QTIbyVioK76a1H30pHhojOKWdRUyagHAhqqd2mVNpNoWntiMsqJKGW9rG+zsKGtOIYxun7UWIYwEqGnP/m6suSILw4lqVk+4ofYVvfEdePt4utbAkb7a06P8GO+S/8hhtsv7N27UbcRF/RuUsmKJh3MPVZJcPDWpZehAWxQgDpTISPK4tN3cB2P7I5YvZndGDR+2thmmkLgZVpActKpz/g3L+WNC+J2uT+5I022hYk8ZG8oPnue1crrhL1jd//jWFvIoJ6oG5n36knbLmNtq3POKZskMbPbTTUgk3qt28ICVSU3u9RrDQHss4MBBeExkNXo1X/6Wr7fhaefUDanqvbsDH+6mJtESTf2YMi4A5BxfMrYoxMB8zLHFdvHVBjyJ1dxuybPVxMMJ2Dpvy4MpZadd42K85B5snH7HLI0qOTKOvbM+OIEdgz2y4Zv0fVtIXMXLZKRMWR+LMtdij0YFEf7b/JHhWz8o905BMr7V54k4c6Mn23BbTrig00BfPOey/AAsH0j34ECayITxHqxzsapHwlAPwgd/mxenn1Tv9Q/T0LkU2+MPh250WuVE7UjbAgAcR9f2+rTgQ9D0K1K24qn7GFqPG/XDBU8WhVxMgGDRtvxGZ5doV7RipzxB//otK0qXlmzJAR0//D2anW3EAisHJ/QtVXqLwQ3n3UeqVIYUctW/3aqz1mlWbAtc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 79cc0f04-d18d-4dd4-9566-08db82235b27
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 15:27:36.9755
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SXaPuTojyxb5P/ouOGSKVMnlithJrzfCcf9HCopWj8t6QJVpp59e9pEdyvAAlccuUMXe/qLsvbLnqfHp/FPwpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR10MB7841
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-11_08,2023-07-11_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 spamscore=0 mlxlogscore=707 suspectscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000
 definitions=main-2307110138
X-Proofpoint-ORIG-GUID: BOHp6hyewLokpqhrfDSdb6bzizk_dSTc
X-Proofpoint-GUID: BOHp6hyewLokpqhrfDSdb6bzizk_dSTc
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Ryan Roberts <ryan.roberts@arm.com> [230711 10:09]:
> On 20/01/2023 16:26, Liam R. Howlett wrote:
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> > 
> > Use the vma iterator so that the iterator can be invalidated or updated
> > to avoid each caller doing so.
> 
> Hi,


Hello!

> 
> I've bisected 2 mm selftest regressions back to this patch, so hoping someone can help debug and fix? The failures are reproducible on x86_64 and arm64.

Thanks!  That is a big help.  Where did you start your bisection?  I
assume 6.4?

> 
> 
> mlock-random-test:
> 
> $ ./run_kselftest.sh -t mm:mlock-random-test
> TAP version 13
> 1..1
> # selftests: mm: mlock-random-test
> mlock() failure at |0xaaaaaaab52d0(131072)| mlock:|0xaaaaaaacc65d(26551)|
> not ok 1 selftests: mm: mlock-random-test # exit=255
> 
> This mallocs a buffer then loops 100 times, trying to mlock random parts of it. After this patch, the test fails after a variable number of iterations; mlock() returns ENOMEM. If I explicitly munlock at the end of each loop, it works.
> 
> 
> mlock2-tests:
> 
> $ ./run_kselftest.sh -t mm:mlock2-tests
> TAP version 13
> 1..1
> # selftests: mm: mlock2-tests
> munlock(): Cannot allocate memory
> munlock(): Cannot allocate memory
> not ok 1 selftests: mm: mlock2-tests # exit=2
> 
> Here, a 3 page buffer is mlock2()ed, then the middle page is munlocked. Finally the whole 3 page range is munlocked, and after this patch it fails with ENOMEM. If I modify the test to split the final munlock into 2, one for the first page and one for the last, the test passes.
> 
> 
> Immediately prior to this patch (2286a6914c77 "mm: change mprotect_fixup to vma iterator"), both tests pass.
> 
> From a quick scan of the man page, I don't think it explicitly says that its ok to call mlock/munlock on already locked/unlocked pages, but it's certainly a change of behavior and the tests notice, so I'm guessing this wasn't intentional?
> 
> I'm not familiar with this code so it's not obvious to me exactly what the problem is, but I'm hoping someone can help debug?

I think I see the issue and I'm working on a fix. I appreciate the
analysis and report, it really helps narrow things down.

Regards,
Liam