Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Jul 2023 17:45:40 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Guiting Shen <aarongt.shen@gmail.com>
Cc:     claudiu.beznea@microchip.com, u.kleine-koenig@pengutronix.de,
        nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
        linux-arm-kernel@lists.infradead.org, linux-pwm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in
 bootloader
Message-ID: <ZK15JNtBFU_7l30o@orome>
References: <20230710144214.63343-1-aarongt.shen@gmail.com>
 <ZKwdHUWzXujfVk0R@orome>
 <d3f07a74-3fce-2310-a1fc-239aa1a25024@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="B8pxxDeV9zU7sDZJ"
Content-Disposition: inline
In-Reply-To: <d3f07a74-3fce-2310-a1fc-239aa1a25024@gmail.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--B8pxxDeV9zU7sDZJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 11, 2023 at 10:30:54AM +0800, Guiting Shen wrote:
> On Mon, Jul 10, 2023 at 23:00:45PM GMT+8, Thierry Reding wrote:
> > On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote:
> >> The driver would never call clk_eanble() if the pwm channel already
> >> enable in bootloader which lead to dump the warning message of "the pwm
> >> clk already disabled" when poweroff the pwm channel.
> >>
> >> Add atmel_pwm_enanle_clk_if_on() in probe function to enable clk if the
> >> pwm channel already enabled in bootloader.
> >=20
> > You've got multiple spelling errors in the commit message. Also, PWM is
> > an abbreviation and so should be all uppercase (except for the subject
> > prefix). I also prefer spelling out terms like "clock" in the commit
> > message. This is text that is supposed to be readable. It's not code.
>=20
> Got it, Thank you. How about this commit message:
>=20
> The driver would never call clk_enable() if the PWM channel was already
> enabled in bootloader which lead to dump the warning message "the pwm
> clock already disabled" when turn off the PWM channel.
>=20
> Add atmel_pwm_enable_clk_if_on() in probe function to enable clk if the
> PWM channel was already enabled in bootloader.

s/clk/clock/ but otherwise looks good.

Thierry

--B8pxxDeV9zU7sDZJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmSteSQACgkQ3SOs138+
s6Ewmw/+Jw6LqxW+nhesVM4WtgxXisrH0NZjNWnHnpN5oBoqgBSAVwdXgCPJKu4S
L5GBmquR2ovzDLFCrn7Rkmis9FGeTu+kwFtcQY3ni47JCb6sg+oNM2qHmjC3O/Ad
PpQMLLGaTsrCeSKYOiW1kSQXfB/O121aFdpDSuV2T/CZZWLeeFuCpPS6exjv7pCq
GesJT7F1ZyeCH6kLrNN+5aciCSa+uOiSmvfjcZPsKbQcwiVxILIGIKCz1m2bKghE
/7aA55I/l0G3DOkKk1JbY75tRVcyJDvldB39FMtY/vluqRxA2g/rWJ2EdGd9+IUr
obHvnvsKUKD1MvNhgNe3qBmZg8HUrimB/YLBvth4yhEDbr4jgTwiPK/++Yx8lXdK
CMbWdafBPsUingZ+N2oPfmYpm0zj91b7YR/dx43nqyQF4dfUi2NMw+eHZ/60jkst
dv7hEbNFTd4OTcKkHjHWVC4fSrrT59YjoDt286WkFV04cKmwq7TK6Vev1m4o0Pfb
zaMVQbja7A5Z+qQsPgIi8bFh0gzm0a7cZ1WsiDi7mSXkH3XoMcWyWrqlM6D7Z9BR
kpiMJ4nH2ZGNIMiU3R0OZdr8GZ+SS0suhefHnosHsGVmxDUXoHqei6PfI3AsYERd
QVsDLgy9kUM4ig4NAiZ7gHVB71Eb3DfnCi0A16fvfv/5w7h5kTY=
=frzs
-----END PGP SIGNATURE-----

--B8pxxDeV9zU7sDZJ--