Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759164AbXJXNen (ORCPT ); Wed, 24 Oct 2007 09:34:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758858AbXJXNeb (ORCPT ); Wed, 24 Oct 2007 09:34:31 -0400 Received: from ts.adaptec.com ([162.62.93.58]:54507 "EHLO mail-gw3.adaptec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757919AbXJXNea convert rfc822-to-8bit (ORCPT ); Wed, 24 Oct 2007 09:34:30 -0400 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Subject: RE: [PATCH -mm 11/11] aacraid: use pci_set_dma_max_seg_size Date: Wed, 24 Oct 2007 09:34:23 -0400 Message-ID: In-Reply-To: <20071024173019I.tomof@acm.org> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH -mm 11/11] aacraid: use pci_set_dma_max_seg_size Thread-Index: AcgWK3TGCpPeROWUQnWJeHYO1VFt+QAFQRHg References: <67bb10d9f4e9473ddc84d9839114602c1966f19f.tomof@acm.org> <20071024173019I.tomof@acm.org> From: "Salyzyn, Mark" To: "FUJITA Tomonori" , Cc: , , , "AACRAID" , Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2144 Lines: 67 ACK Based on the presence of the call. 2.6.22, for instance, does not have this capability... I did not test this change, just accepting on the principals. How much testing of the change did you do Fujita? Sincerely -- Mark Salyzyn > -----Original Message----- > From: FUJITA Tomonori [mailto:tomof@acm.org] > Sent: Wednesday, October 24, 2007 6:49 AM > To: akpm@linux-foundation.org > Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; > James.Bottomley@SteelEye.com; AACRAID; fujita.tomonori@lab.ntt.co.jp > Subject: [PATCH -mm 11/11] aacraid: use pci_set_dma_max_seg_size > > This sets the segment size limit properly via pci_set_dma_max_seg_size > and remove blk_queue_max_segment_size because scsi-ml calls it. > > Signed-off-by: FUJITA Tomonori > --- > drivers/scsi/aacraid/linit.c | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/aacraid/linit.c > b/drivers/scsi/aacraid/linit.c > index 038980b..04d6a65 100644 > --- a/drivers/scsi/aacraid/linit.c > +++ b/drivers/scsi/aacraid/linit.c > @@ -435,9 +435,6 @@ static int aac_slave_configure(struct > scsi_device *sdev) > else if (depth < 2) > depth = 2; > scsi_adjust_queue_depth(sdev, MSG_ORDERED_TAG, depth); > - if (!(((struct aac_dev > *)host->hostdata)->adapter_info.options & > - AAC_OPT_NEW_COMM)) > - > blk_queue_max_segment_size(sdev->request_queue, 65536); > } else > scsi_adjust_queue_depth(sdev, 0, 1); > > @@ -1045,6 +1042,12 @@ static int __devinit > aac_probe_one(struct pci_dev *pdev, > if (error < 0) > goto out_deinit; > > + if (!(aac->adapter_info.options & AAC_OPT_NEW_COMM)) { > + error = pci_set_dma_max_seg_size(pdev, 65536); > + if (error) > + goto out_deinit; > + } > + > /* > * Lets override negotiations and drop the maximum SG > limit to 34 > */ > -- > 1.5.2.4 > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/