Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp37126921rwd; Tue, 11 Jul 2023 09:46:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlGKzQrr6pWrAy4+n9uFkLFI5XSCo/R7x5JphLH/6Z/VKJitqTGM8NNyy8p5GdG0SJwAlPY5 X-Received: by 2002:a05:6a20:13c7:b0:12f:dc60:3ffb with SMTP id ho7-20020a056a2013c700b0012fdc603ffbmr16621758pzc.37.1689093959940; Tue, 11 Jul 2023 09:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689093959; cv=none; d=google.com; s=arc-20160816; b=Uj5e2B37nXG1zc0lhJn/wQLrstHlahVziWFp7L/NkaV8OgqJjcyxOAu/a95d1Og5cr hg0pLnKcQrkQ698TLxmSTZ2Pb/8LXdiuym30TMluo6TYnnnEaR+x+swAfzm4WNl0OFUX XrFulApjVs0abuF7+MbzE0/Ducl34DzsIFVxzL0br9er4MSXh9Kov2z5Lp/ZpkVVI3J4 0m7bZ1XU0gIA+8cEYawPra7Gjt0Y2qZ+42G8QZv5Bg4HRKGX4LqqJh3IjjyzoGAfVNoq TG5zF3uJdHeo99gvfWlrf3J2jNQcP0sFDNsIFerkeVGypFRr5iTP2E2E1vGcH55VLDYK Mixw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:thread-index:thread-topic :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date; bh=CBjFZwDCggbS6jJsnp5Irc8q0UTGiSVvzr/0uo6LPp4=; fh=2qd8CV9CA/R6vH+FxsC95K/+o5a38/YZDrDEgvba9x4=; b=XjXTGrG+vzaOCL/qyEGfZeCg8nga+prPnWI0QxFJX8mZkTF8N+BUTmC48OteLWtf3N fEbrYJDPn+sAV2Mizxd8WVQy0V3ibf+TQZFzWz4Ly7G3IXVt25IkEkmzTxL7Fs5R70a7 Ryq8CBwpTKv1CBaEG7kVFLuSbxl0tENvkwR0URlwVaVamJ1ZRkY6tikJhsQ7k8yVvQ3a MPubQ+Dl6d0s2vA4kBjE1pjJLiGX2wA9XXhbjlmBjG9xDvAihdg64SDe1sxstlcm4rEm zAiyUNIIXnOrV9KAyixCrHVXhAscdsqXAZunZsUJQ8T3jyKmMfMosC80ucEuursVhGur rryg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h190-20020a6383c7000000b0055336060fa0si1663584pge.378.2023.07.11.09.45.27; Tue, 11 Jul 2023 09:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231496AbjGKQbC convert rfc822-to-8bit (ORCPT + 99 others); Tue, 11 Jul 2023 12:31:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230344AbjGKQbA (ORCPT ); Tue, 11 Jul 2023 12:31:00 -0400 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF9ABE60; Tue, 11 Jul 2023 09:30:54 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 30D7962F2910; Tue, 11 Jul 2023 18:30:52 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8R4yn2ky6m_j; Tue, 11 Jul 2023 18:30:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 9C74861A7038; Tue, 11 Jul 2023 18:30:51 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id u99T18Ks9BIc; Tue, 11 Jul 2023 18:30:51 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id 6400E61989ED; Tue, 11 Jul 2023 18:30:51 +0200 (CEST) Date: Tue, 11 Jul 2023 18:30:51 +0200 (CEST) From: Richard Weinberger To: Markus Elfring Cc: Yang Rong , linux-mtd , kernel-janitors , Miquel Raynal , =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Vignesh Raghavendra , opensource kernel , linux-kernel , Lu Hongfei Message-ID: <2014273324.2321953.1689093051254.JavaMail.zimbra@nod.at> In-Reply-To: <743f4445-31a6-0e51-f432-08033bdcaf20@web.de> References: <20230711020752.2344-1-yangrong@vivo.com> <743f4445-31a6-0e51-f432-08033bdcaf20@web.de> Subject: Re: [PATCH v3] mtd: core: Fix resource leak in a for_each_child_of_node() loop MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: core: Fix resource leak in a for_each_child_of_node() loop Thread-Index: O0iikkkuA+X93639t1xDfOZiQ6wdMQ== X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE, T_SPF_TEMPERROR autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Markus Elfring" >> v2: https://lore.kernel.org/all/20230710061412.2272-1-yangrong@vivo.com/ >> The modifications made copared to the previous version are as follows: > > How do you think about the omission of a line here > (so that a repeated typo can be avoided)? > > Would the subsequent enumeration look a bit nicer if each text item > will be delimited by a space character? Markus, just stop it. Thanks, //richard