Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Jul 2023 18:17:07 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org,
        eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org,
        derek.kiernan@amd.com, dragan.cvetic@amd.com,
        linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com,
        linus.walleij@linaro.org, tsbogend@alpha.franken.de,
        joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de,
        maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
        robh+dt@kernel.org, frowand.list@gmail.com,
        kernel test robot <lkp@intel.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM
Message-ID: <ZK2Ok5i2m7zS6Uq0@corigine.com>
References: <20230707135852.24292-1-bhe@redhat.com>
 <20230707135852.24292-6-bhe@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230707135852.24292-6-bhe@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FyMOOjTMyF56Pc4KZ/E/2IYwWosT50YsCN/SO73ls4XWDVv6wCKk4yjR+1I4?=
 =?us-ascii?Q?4e9tm5IQj23Csn8NpDyJ63ie1zJBbK7Lwf3rwKUkg7KRRhRDcZO3hgXxAHPl?=
 =?us-ascii?Q?yiVva8Bk2G+cmbRi58/TvhH63yWC2v5E4Ey58Vr24umpNOmF6pIyiwII2VLs?=
 =?us-ascii?Q?CGy0IdqDhyDCGnIuYmSTplAxjuuZJsbknwzJUEVgIJIt+LMQljl4oWzoY+6I?=
 =?us-ascii?Q?FiE81qim8O+M/qKMA8bS4vvEZ9P6E9qPUpvSCA1zYLNNxWe3DyCNYSxvO9Q4?=
 =?us-ascii?Q?YumngkkhZiOJMUVDinF4PHRPP/rryF+Mjf5woammUPbS1TsiiiC5FxO9HKvk?=
 =?us-ascii?Q?XYWw1jqMFnYl+MgnP0bs4ilYz7HXNE4Si/CKEt+ybn+PIYBe7hBeKeGEA0rt?=
 =?us-ascii?Q?iU0Ar3pQxJA2/2uYKh4TiriyvLNEJGzBKxCV+NXy1xp51vvaFCtFBAYrdqsN?=
 =?us-ascii?Q?SD9rv+GpT/2TXLeNc0aUsHHQlLKdJaZ4bKIceRphLbf3hEUJ4o3hdtKFLX4N?=
 =?us-ascii?Q?IeC0ByKzOYSg+m2uGQ5aTtaz3x2uIETkdpJS7BPGABkIRlTXv4owtnxAWA1C?=
 =?us-ascii?Q?LpAnyuf5j8UMgLNsS1KTs2iVHrEWrI3j6Tqw3cFdq1hZ6KMzwh+91G7P824+?=
 =?us-ascii?Q?K/+tKbnAqy87ph7dPzX8lUqBPnh9aiPGjVfvjwHjpDj791OXmX0NuPZ1NBfm?=
 =?us-ascii?Q?7SmiE30p6tPuz4aTFz2+HztH2uhdV4S2RImIv5o7Mlcdf1SzzfF06pZxdA5z?=
 =?us-ascii?Q?2q2niQtLFpo3S8pHdp73M5PbI+Navj/0qfy7QBibczCagFGItGN0fD0aOJqb?=
 =?us-ascii?Q?4uWmFvNif4JGvYMsp0LUvivAgxoTSqVJeZm9aoZn6nKlGFaOFQtohHm1t/3O?=
 =?us-ascii?Q?CZWPFU/wCrsmAYj7Nw0YlrcXCcBqCVEMP8xK/QnzZOdg4R7XQSqEEkxpKMYa?=
 =?us-ascii?Q?M8N1/KqeAxLgomrxmyWADEbJxpygfe0tyl6hwxFHTkXtudGvBjoGZ6FxnUvU?=
 =?us-ascii?Q?/gY4FbHlaiMVxfMVCGZC3WPYUXb7IE4fXqeFKoDS/0uNeP1tGvNrifKUyrZr?=
 =?us-ascii?Q?J/cGvs/jNn2Pb3LhAh4WzMIobHw6kY7dBmsSUK0DL8fhZw8eLo7e2oiAnD5R?=
 =?us-ascii?Q?lu7o79tav5WT7W9/T42e99cK40C31E7CsoOIzeNmTgL4hac1NX49eujQ8SEr?=
 =?us-ascii?Q?FQco71tSeJWR4gmMBJxVE8ppz3a/kgToXWRLj+wqFyaAKUstj2TXJ0jVTPNl?=
 =?us-ascii?Q?ruIcjVw1HX3hPF5zA3J4a3j8x8UWXMu98jW36mSkKUJ1y4V7ggMMCytifmG4?=
 =?us-ascii?Q?+Fk/tQqhdeAf4hkj9G/aKeBQZx9y2hgUILDKB7wZjYsBoaV/dLf8LYdu3yWS?=
 =?us-ascii?Q?djjChoaxO326Udc79O0VEENbu8hJ1oh2XW4vTVyid4kE54RvNMYzQAgGmXAM?=
 =?us-ascii?Q?NMSOtiNbM/2+eHbAgNPM4WaZejS8Z7SLLf8qLy3g/WTJytNLhhEkv8KH4FGo?=
 =?us-ascii?Q?Y1W5XK9REa6FMy1XsyjLgtWyCiGZ27B0jRm5Ry6u/9N5GP8TS4jqwb4yaTy0?=
 =?us-ascii?Q?a0TCrPGSm+ymwMBTOrBTFlu/qb5qsjh+PbaZm56yNku4xEFEEM0wfendcKES?=
 =?us-ascii?Q?Qw=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66873dbd-2086-4a91-cae6-08db8232ad7a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 17:17:17.5200
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fvOI87SIPaSqhfle6VJqV1sty6nDP4dI2qc+BaMZ7FyPfozjs/FMaNsB6nXu18psGQgXzrOhYGDXJh9adipvjLfUOkVGienUcH2u5YXOX3I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5594
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote:
> On s390 systems (aka mainframes), it has classic channel devices for
> networking and permanent storage that are currently even more common
> than PCI devices. Hence it could have a fully functional s390 kernel
> with CONFIG_PCI=n, then the relevant iomem mapping functions
> [including ioremap(), devm_ioremap(), etc.] are not available.
> 
> Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built
> to cause below compiling error if PCI is unset:
> 
> ------
> ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined!
> ------
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/
> Signed-off-by: Baoquan He <bhe@redhat.com>


Reviewed-by: Simon Horman <simon.horman@corigine.com>
Tested-by: Simon Horman <simon.horman@corigine.com> # build-tested

I wonder if this should also have:

  Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig")