Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Jul 2023 18:25:12 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     linux-kernel@vger.kernel.org,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Kalle Valo <kvalo@kernel.org>, linux-wireless@vger.kernel.org,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net] wifi: airo: avoid uninitialized warning in
 airo_get_rate()
Message-ID: <ZK2QeBZKWi0Q6vuW@corigine.com>
References: <20230709133154.26206-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230709133154.26206-1-rdunlap@infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?08hegpWuPylQG49MBfGzD+gfs3N3I9Q8jtrDhjDzEEx/gTQI3/P9p2waUo0N?=
 =?us-ascii?Q?03bx2z523RWAO0LMOkvAmitpJohVmrNhCpSW4xr4pevUSLWJ8K1KZE95CSR9?=
 =?us-ascii?Q?O9cYiCORxT6xoLsZoa+1w4mhcOYYuF3qqRi3sjLlliZ2oIifjeOVSSaef7xS?=
 =?us-ascii?Q?YKbHrdRs7UmnF6C8v15Y3SaUxMroaDkr275cg14qwBmQj6YCxatRyusggAcM?=
 =?us-ascii?Q?xhiAdSxHPYuZ71KcN83chbdq6ALNSp7NitdI/+i/uxHZsBwVwf9NiSHCH8T8?=
 =?us-ascii?Q?Xw66aMOuMcwMW92CCz3O1Pt4pX7C3XozR9vNRsB0yMg2tw2nov+nqj+Dvcoi?=
 =?us-ascii?Q?FVIl0vtNOfMxVZlU9iwdF4gQkcR8nQS9o4xQK25uJh6G79I4tpzq1tFYW4ee?=
 =?us-ascii?Q?FKMH5GIZ6umrzNt06qn27APQnQC4SkFc3YRCVUdvHRJvK6eVtyD+8uBOxIaG?=
 =?us-ascii?Q?pphWwA64oDFUp9jtFAjB+NgO7+yG1yaeRzixcIypkjCD0zBL0rpxcKqheo0l?=
 =?us-ascii?Q?twyVKXrnBqSeYtu8s8t/azTESafeeTUp86nCXDUfUdCDuzDtmQi95WFqKDDM?=
 =?us-ascii?Q?XYDNkzaYHuQipdfPECkeSvftrhUOL18RpwbbTIszn+f/ylwv/amAbtpL8Jfq?=
 =?us-ascii?Q?9dx9u5a4ElHtMrwbZOPtVZGH+uAr+FsJ5e9fkQuLlpssyMtuhFanRXlNfPL+?=
 =?us-ascii?Q?biXCRl1fiBtAGL0Bf2RHY1P3sk63twosF9Y6alfbuDbY2qcGibmX26dtCoLX?=
 =?us-ascii?Q?RFHMAcvJcWcwg6BlfXxDFvUkKhbxj7DOGNGeM8WyPfz/J4aZuhsyaoOSXKB9?=
 =?us-ascii?Q?wlLveQIVGDWMS5mqDDHWUDW0NpfzyouMzI1sQlY8njddPVnmyu6StuNJ+hbp?=
 =?us-ascii?Q?XkxLjX6JsD9ZXIfhabE7IbtMzT1N2z7c0AJ5/v9iFN2ordPf2Ows8jjDb3W6?=
 =?us-ascii?Q?OltcU9j/vjuqq9TX+if1ubadMpwVbju2nsO2xPANql4Frmh+HHpcqP6SonBr?=
 =?us-ascii?Q?LkzZCgf1BACtkuBA4V8Q5vm6b39DVtBZFOWs6zYcxiVL2qkhl8DgpS/cPKI2?=
 =?us-ascii?Q?Vx6u0DbpmVfAwIw4/06SM3CDTsw0wsFUX3HOlDEx9nqXQCbchcTeKKv85p0M?=
 =?us-ascii?Q?8eF61A0quWTo4on06Ah8HUFLb9GIKyAkmdS0E9VC3AnJLlVWq8zYFFMYTo7p?=
 =?us-ascii?Q?E/HHkyCAoorxm3koAl/BxTWEjF8WVYFv6AM1fHd+0N3XBXSujTe855KamzUy?=
 =?us-ascii?Q?HXcHk65ec1TTcpg0NUTLM8MNZeREt7i1MR69MpidBWemeA7gwfA7KFoP/0IK?=
 =?us-ascii?Q?FXtZx7LhOleSCsiJNabcKix8mzLmdpd3hPPUyI9UGELMarYd5yb/oqr/wQl2?=
 =?us-ascii?Q?ZxqgJ5o+COb1f5QvjG8iRgxHKW/e0LLiEmLoM3ter6/Hzfzx4zlubs5JeTs2?=
 =?us-ascii?Q?lizaoTGwFRiEpKUdLCafkJsq6OOowWv8RGqIkPZIfLv5NwhgMTty/wBh2P9+?=
 =?us-ascii?Q?rLkrSd1jmg1gyZXBTxpV3JAcCo3GrVm3hX1leVNcRsyP1Pn1AHhSIic/KA/D?=
 =?us-ascii?Q?5SKmYS+1zUQljs8QIIPCvsZ651BqWQgtl4bw/ddI+61xcBAxFqbaE1XpIaQ8?=
 =?us-ascii?Q?vA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09da4e10-b299-44a1-64f4-08db8233cc6a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 17:25:18.9384
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eagEkZKewLFtqcINSaRLVytw2pXDcs1RYqKBod7F8PPKMV/NlrReFwUPVfzvcMSfyRCVws7REFQLrWRHzYxEkeGQw7Bwp8Okceitrp+x1U8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4884
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jul 09, 2023 at 06:31:54AM -0700, Randy Dunlap wrote:
> Quieten a gcc (11.3.0) build error or warning by checking the function
> call status and returning -EBUSY if the function call failed.
> This is similar to what several other wireless drivers do for the
> SIOCGIWRATE ioctl call when there is a locking problem.
> 
> drivers/net/wireless/cisco/airo.c: error: 'status_rid.currentXmitRate' is used uninitialized [-Werror=uninitialized]

Hi Randy,

There seem to be other calls to readStatusRid() in the same file
with similar properties. Perhaps it would be best to fix them too?

> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Link: lore.kernel.org/r/39abf2c7-24a-f167-91da-ed4c5435d1c4@linux-m68k.org
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> ---
>  drivers/net/wireless/cisco/airo.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff -- a/drivers/net/wireless/cisco/airo.c b/drivers/net/wireless/cisco/airo.c
> --- a/drivers/net/wireless/cisco/airo.c
> +++ b/drivers/net/wireless/cisco/airo.c
> @@ -6157,8 +6157,11 @@ static int airo_get_rate(struct net_devi
>  	struct iw_param *vwrq = &wrqu->bitrate;
>  	struct airo_info *local = dev->ml_priv;
>  	StatusRid status_rid;		/* Card status info */
> +	int ret;
>  
> -	readStatusRid(local, &status_rid, 1);
> +	ret = readStatusRid(local, &status_rid, 1);
> +	if (ret)
> +		return -EBUSY;
>  
>  	vwrq->value = le16_to_cpu(status_rid.currentXmitRate) * 500000;
>  	/* If more than one rate, set auto */
>