Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230706063440.54189-1-sandipan.das@amd.com> <CAP-5=fVdVSL4H1qWLZMiU3H2-bOJ0RkFOfq4Jxz1qw0-8EoYFw@mail.gmail.com>
 <ZK1sb4tPizTzWq7q@kernel.org>
In-Reply-To: <ZK1sb4tPizTzWq7q@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Tue, 11 Jul 2023 10:34:18 -0700
Message-ID: <CAM9d7ci5owtM9h_PjsLo6hNz=kZKDT8PcPFOWX41Vf9g+SnpEQ@mail.gmail.com>
Subject: Re: [PATCH v2] perf vendor events amd: Fix large metrics
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Ian Rogers <irogers@google.com>,
        Sandipan Das <sandipan.das@amd.com>,
        linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
        peterz@infradead.org, mingo@redhat.com, mark.rutland@arm.com,
        alexander.shishkin@linux.intel.com, jolsa@kernel.org,
        adrian.hunter@intel.com, ayush.jain3@amd.com,
        ananth.narayan@amd.com, ravi.bangoria@amd.com,
        santosh.shukla@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Jul 11, 2023 at 7:51 AM Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
>
> Em Thu, Jul 06, 2023 at 06:49:29AM -0700, Ian Rogers escreveu:
> > On Wed, Jul 5, 2023 at 11:34 PM Sandipan Das <sandipan.das@amd.com> wrote:
> > >
> > > There are cases where a metric requires more events than the number of
> > > available counters. E.g. AMD Zen, Zen 2 and Zen 3 processors have four
> > > data fabric counters but the "nps1_die_to_dram" metric has eight events.
> > > By default, the constituent events are placed in a group and since the
> > > events cannot be scheduled at the same time, the metric is not computed.
> > > The "all metrics" test also fails because of this.
> > >
> > > Use the NO_GROUP_EVENTS constraint for such metrics which anyway expect
> > > the user to run perf with "--metric-no-group".
> > >
> > > E.g.
> > >
> > >   $ sudo perf test -v 101
> > >
> > > Before:
> > >
> > >   101: perf all metrics test                                           :
> > >   --- start ---
> > >   test child forked, pid 37131
> > >   Testing branch_misprediction_ratio
> > >   Testing all_remote_links_outbound
> > >   Testing nps1_die_to_dram
> > >   Metric 'nps1_die_to_dram' not printed in:
> > >   Error:
> > >   Invalid event (dram_channel_data_controller_4) in per-thread mode, enable system wide with '-a'.
> > >   Testing macro_ops_dispatched
> > >   Testing all_l2_cache_accesses
> > >   Testing all_l2_cache_hits
> > >   Testing all_l2_cache_misses
> > >   Testing ic_fetch_miss_ratio
> > >   Testing l2_cache_accesses_from_l2_hwpf
> > >   Testing l2_cache_misses_from_l2_hwpf
> > >   Testing op_cache_fetch_miss_ratio
> > >   Testing l3_read_miss_latency
> > >   Testing l1_itlb_misses
> > >   test child finished with -1
> > >   ---- end ----
> > >   perf all metrics test: FAILED!
> > >
> > > After:
> > >
> > >   101: perf all metrics test                                           :
> > >   --- start ---
> > >   test child forked, pid 43766
> > >   Testing branch_misprediction_ratio
> > >   Testing all_remote_links_outbound
> > >   Testing nps1_die_to_dram
> > >   Testing macro_ops_dispatched
> > >   Testing all_l2_cache_accesses
> > >   Testing all_l2_cache_hits
> > >   Testing all_l2_cache_misses
> > >   Testing ic_fetch_miss_ratio
> > >   Testing l2_cache_accesses_from_l2_hwpf
> > >   Testing l2_cache_misses_from_l2_hwpf
> > >   Testing op_cache_fetch_miss_ratio
> > >   Testing l3_read_miss_latency
> > >   Testing l1_itlb_misses
> > >   test child finished with 0
> > >   ---- end ----
> > >   perf all metrics test: Ok
> > >
> > > Reported-by: Ayush Jain <ayush.jain3@amd.com>
> > > Suggested-by: Ian Rogers <irogers@google.com>
> > > Signed-off-by: Sandipan Das <sandipan.das@amd.com>
> >
> > Acked-by: Ian Rogers <irogers@google.com>
>
> Thanks, applied.

If I'm not too late..

Tested-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung