Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20230711114821.1273-1-a3at.mail@gmail.com> <20230711120806.GA27809@lst.de>
In-Reply-To: <20230711120806.GA27809@lst.de>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 11 Jul 2023 20:01:09 +0200
Message-ID: <CAJZ5v0gJcMKbwjrwwnMi7OD59DoOTm3EKZrdr4eYs05qP10v6A@mail.gmail.com>
Subject: Re: [PATCH] Fix writing maj:min to /sys/power/resume (fixes
 hiberation with systemd)
To:     Christoph Hellwig <hch@lst.de>, Azat Khuzhin <a3at.mail@gmail.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

On Tue, Jul 11, 2023 at 2:08 PM Christoph Hellwig <hch@lst.de> wrote:
>
> On Tue, Jul 11, 2023 at 01:48:12PM +0200, Azat Khuzhin wrote:
> > resume_store() first calls lookup_bdev() and after tries to handle
> > maj:min, but it does not reset the error before, hence if you will write
> > maj:min you will get ENOENT:
> >
> >     # echo 259:2 >| /sys/power/resume
> >     bash: echo: write error: No such file or directory
> >
> > This also should fix hiberation via systemd, since it uses this way.
>
> Looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Applied as 6.5-rc material, thanks!