Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230707191721.1.Id08823b2f848237ae90ce5c5fa7e027e97c33ad3@changeid>
 <20230708174832.0af1d974cf67805dfc8ad655@linux-foundation.org>
In-Reply-To: <20230708174832.0af1d974cf67805dfc8ad655@linux-foundation.org>
From:   Raul Rangel <rrangel@chromium.org>
Date:   Tue, 11 Jul 2023 12:15:34 -0600
Message-ID: <CAHQZ30CUjYHuP126wUtAw6iz7=qF+gUxdHYnOsg_o7XGt1MQsw@mail.gmail.com>
Subject: Re: [PATCH] init: Don't proxy console= to earlycon
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org, mario.limonciello@amd.com,
        kramasub@chromium.org, Alexander Potapenko <glider@google.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        "Jason A. Donenfeld" <Jason@zx2c4.com>,
        Li Zhe <lizhe.67@bytedance.com>,
        "Liam R. Howlett" <Liam.Howlett@oracle.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Will Deacon <will@kernel.org>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Zhou jie <zhoujie@nfschina.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jul 8, 2023 at 6:48=E2=80=AFPM Andrew Morton <akpm@linux-foundation=
.org> wrote:
>
> On Fri,  7 Jul 2023 19:17:25 -0600 Raul E Rangel <rrangel@chromium.org> w=
rote:
>
> > Right now we are proxying the `console=3DXXX` command line args to the
> > param_setup_earlycon. This is done because the following are
> > equivalent:
> >
> >     console=3Duart[8250],mmio,<addr>[,options]
> >     earlycon=3Duart[8250],mmio,<addr>[,options]
> >
> > In addition, when `earlycon=3D` or just `earlycon` is specified on the
> > command line, we look at the SPCR table or the DT to extract the device
> > options.
> >
> > When `console=3D` is specified on the command line, it's intention is t=
o
> > disable the console. Right now since we are proxying the `console=3D`
> > flag to the earlycon handler, we enable the earlycon_acpi_spcr_enable
> > variable when an SPCR table is present. This means that we
> > inadvertently enable the earlycon.
> >
> > This change makes it so we only proxy the console=3D command if it's
> > value is not empty. This way we can correctly handle both cases.
> >
>
> I hope someone understands this ;)

Is there a more specific list I should send this patch too?

>
> Please "grep -r earlycon Documentation" and check for suitable places
> to update our documentation.
>

The documentation is correct, this just makes the code match the
documentation :)