Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0837a34c-f66e-aa04-d4a7-b032d3dbab7a@intel.com>
Date:   Tue, 11 Jul 2023 20:37:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [6.5.0-rc1] unchecked MSR access error: RDMSR from 0xe2 at rIP:
 0xffffffff87090227 (native_read_msr+0x7/0x40) (intel_idle_init_cstates_icpu)
To:     Peter Zijlstra <peterz@infradead.org>,
        Bruno Goncalves <bgoncalv@redhat.com>
CC:     <arjan@linux.intel.com>, <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <CA+QYu4qSBdhEgFURu+ouAf2d_JNPbZgCSUaxCLoGzMqDQOLWsQ@mail.gmail.com>
 <20230711112421.GI3062772@hirez.programming.kicks-ass.net>
 <CA+QYu4qzJgiiU1qsjtWb9OU3=C=hb_c-Ag5Y4c=Xp_ObfGH=hg@mail.gmail.com>
 <20230711125557.GM3062772@hirez.programming.kicks-ass.net>
 <20230711132553.GN3062772@hirez.programming.kicks-ass.net>
Content-Language: en-US
From:   "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <20230711132553.GN3062772@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1lObURuR2k2YTc0RHkzRzVSV2JLTnZOaTBHdytiLzZocE9MMXpUdkU5aW9Q?=
 =?utf-8?B?OFliS29KSW43bUtxcFlvdUEzVjZHREpRZFhFYTAvaEZ0U29hbXV2amdzTVA4?=
 =?utf-8?B?Y3E5NXpoeW9GRmQ4NFplc0wxNU90TU1tN1NhZWYzZzZFUHlzQmVIQlpXV2RB?=
 =?utf-8?B?VUtUYVMvNzdIVjlmNU5XVlp4cmxaL3kwZFVUaENzNGVkdzVHakYyOTA5ekFs?=
 =?utf-8?B?QkUzeG1lNEVXd0Z1ZGFWR3pGYlZVNmt1QjR3VDNoZTRxTTI4MkFKeGV6NVRy?=
 =?utf-8?B?UWRWdEtobS9DZjdXa1RxdUZ4MGVHTnZPT3h4Rmt6dXdKTHFjY29zVDNKN3oy?=
 =?utf-8?B?R3JiRk02ZHpBcUFacWJmZWZxRzczWGpranJCVG9SelZ1bmNFS3VTSUJwVncr?=
 =?utf-8?B?clJBbkM4T0MvTzhBWk0xVjY5TWpKR1ArSGt1b005R3ZKQ2pGMWx6L0RwR3Rk?=
 =?utf-8?B?Q3ZPS0ZScTdsN0h1YWFaTlp0aVJBZk0wc1hDV0tQL1ljOFB2c3o5a2tSaXhJ?=
 =?utf-8?B?OXVyL0dKWHdhcXVsTFB6eEpQM0w4dUc3azJ0M2VVMUVsMDkrTlAzS1U5cWFx?=
 =?utf-8?B?L253cXJNR01KNTNkRmczT1FJM3FXNlZza1hDRXZmQlJXeEpkS0NxL0dTUkJt?=
 =?utf-8?B?UHpPQWdwdmZDdHlMU2g3d3F0QmVpbkwvc1FJcUhJdDFKTkNUU3d5VjViZGM3?=
 =?utf-8?B?RjNVWDI3YUNzNTBwVVFaYTB1NEhVZ0RSRE9HUzVLaXZYR3BRSHM4UnU2dlh0?=
 =?utf-8?B?dWRPNzhwN0hqMExHaW5EeDJvT1dhVWh4cTlLYVZwTnFYaEt3djFVaU5KM3Rv?=
 =?utf-8?B?NTIvTGN0dDJsME5SQWNmRUd2Y1J5OGM4a0YzOUhVRjAwMzRPK0liQzJKZlVn?=
 =?utf-8?B?RVJLR0o5d0s4NUZ5TmdlenROTFN1ZFBoVWRGZW43cGt5VzArYzBPWCtuQUF1?=
 =?utf-8?B?VFBOZ3VQSUJsQVZ0a2dHYWFxWkNxcGJ6NndkRmdXeXl2bS9zR1d1NmZnRmdG?=
 =?utf-8?B?RWdsRWpWVzAvYW1Yby9nWTdHc2VIMzdVM0lHQXZpWTQ1MjZzYkVNWmVqU0I3?=
 =?utf-8?B?SDdXaCsrMHNyOVRnV1drTVVXdGtHNU5SelB2Nmh4ZjJMQ25weEt5U1gwUnVy?=
 =?utf-8?B?UHo2ZENyb1ZOVFRDdGphL2c4SHB3eVEvR0NsdnBBaXdTL0lYWTZWTExqenJs?=
 =?utf-8?B?b3E3cXo4U0xiY3hPelVLcGxrUE11elU2UlRoT2E2YkZza2E3U0lSaVpRekdo?=
 =?utf-8?B?bXRqZlArWGxJTkd4L2hkVU9rd3RxYlk1ekxIYU9Xa0hLeVBXRWRPRTBINmp1?=
 =?utf-8?B?UmxPTGlIbngwMElUWmo1ME9oK3dOcnl2RmdhVlh0QlY4ek05eXpnNy9ZYVE2?=
 =?utf-8?B?M0FXa05lU1pvRWkvbnNYZEovcC9lbkVpcFo3UG9rTURDY29ESzU5U25GamtB?=
 =?utf-8?B?bmZOMk1kdFJjcGdJRXBKZE9TU1J2VjcxSjhaQ0hsNzBOVWJ3dWFyM2ZtTFhZ?=
 =?utf-8?B?OStRYkN4Q0N4K1gxOUkzWDE3L0QzV2tvVU1BWFlzbXVBLzJaQUNIMHlWMEZC?=
 =?utf-8?B?ZGNCeE5wMllnNXRHdzRmTy9ERE5ENGc3QW8zekdScjRQY1VtNmpiRHZCekNG?=
 =?utf-8?B?QytDeWxmOEhQdURSeG1zUE4zOFRjYlZSWThyS2x3QVhOdFV5SzZTa3NXVEpj?=
 =?utf-8?B?K3BjS3FSRytyZzdOU2JNZG1rSkZPVWIwZ0lkeWpLQ3NzZVZqMkY4ZHIzUklz?=
 =?utf-8?B?VEhXamZpbDJMb2VYU0FDaTFlaUNiUmFTb1E0UHdyNmM0QjRaSTJkNGMzVzNp?=
 =?utf-8?B?ZW5GczZHenNXb3JpMXc1eDNaRWdhd0FYK1VjeDIxdXc2UGZuYlAwdjlOZjND?=
 =?utf-8?B?VE5qV00wT1ExMkxJZ0RWMFhYOVhXeWNuME13MCtUd2NLcWM0K3dITVRkR2du?=
 =?utf-8?B?WE1vbFp0MUpnTm00MCtIdnFFU0QrQ2R3cHU0T0dEWS9xMzhZcXJvZVhkcVU3?=
 =?utf-8?B?UERkc1ZmUjhEZkQzY0VRZm0yQStxem1MWXRTWFc2M2QyNWdQQ1gwbFJRSGFs?=
 =?utf-8?B?N1Rwb2l4SHYwa3FMbHljZVBaaEtqckF2RlE3TE0zNHdpc2d0d3hqckRvektj?=
 =?utf-8?B?blpJRFMzdlVLN3RlWTZmL0d6OThnTFBGTlBLUWRJaUhSdHZva003NGtRN0dG?=
 =?utf-8?B?THc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c0755ea2-678e-4512-c788-08db823df25f
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 18:37:57.6750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yLlsq4NzS5TDYL051bF9XtaA0MPmSVZW8AaI7R6L9AccL9p8TLVGDEaJ/pLohEMgRrrX1jbAjoq5MwmEC1NrTPVAjJFMcrf1ZNZObPdhY8M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4816
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/11/2023 3:25 PM, Peter Zijlstra wrote:
> On Tue, Jul 11, 2023 at 02:55:57PM +0200, Peter Zijlstra wrote:
>
>> Oohh, this vm-guest mode is new :/ But it doesn't make sense, that
>> commit babbles something about waking CPUs from idle to do TLB
>> invalidate, but that shouldn't be the case, that's what we have
>> kvm_flush_tlb_multi() for, it should avoid the IPI and flush on
>> vcpu-enter.
>>
>> Arjan, what is the actual problem you're trying to solve any why hide
>> this in intel_idle ?
>
> static __always_inline int __intel_idle_hlt(struct cpuidle_device *dev,
> 					struct cpuidle_driver *drv, int index)
> {
> 	raw_safe_halt();
> 	raw_local_irq_disable();
> 	return index;
> }
>
> Which does:
>
> 	STI
> 	HLT
> 	CLI
>
> static __cpuidle int intel_idle_hlt_irq_on(struct cpuidle_device *dev,
>                                     struct cpuidle_driver *drv, int index)
> {
>         int ret;
>
>         raw_local_irq_enable();
>         ret = __intel_idle_hlt(dev, drv, index);
>         raw_local_irq_disable();
>
>         return ret;
> }
>
> That is nonsensical code; because now you have:
>
> 	STI
> 	STI
> 	HLT
> 	CLI
> 	CLI
>
> And that makes sense how?
>
> Rafael, can we please just pull these patches and try again later?

I think you mean "revert"?

That can be done, but maybe it can be fixed instead?