Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp37350202rwd; Tue, 11 Jul 2023 13:02:12 -0700 (PDT) X-Google-Smtp-Source: APBJJlFx4NFYC0EbgxYRvzh3bVpK88gErW7tAynd/pr+Byu5ZT5IzPW52nzsY4ToEyZU3aP/cXSr X-Received: by 2002:a05:6a21:999a:b0:12f:dce2:b392 with SMTP id ve26-20020a056a21999a00b0012fdce2b392mr21474631pzb.6.1689105731989; Tue, 11 Jul 2023 13:02:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689105731; cv=none; d=google.com; s=arc-20160816; b=USsjSbik9LmQVZzo9qhLQmuPJuUO9+5muGAs0SUep2kTc8mIZgX2il3es5011uptVt Ch9vKOcF30gg17XvDANgWJJ7mO1zfObtEFcFX8dBUieEbq1We6GaWTouKprnNoaE/2TQ Gn9tliKbAdBSD88nl8MUPCvOstAxIgr0hg5oQkZcDPyk90Dyy4mic+zDfcot7atdrnyU yyI3X5pZb6xh1zXB/FUfstSlpJDRlpDzUu0SuW2chV14RnxysoLLuBa41L6bmuambUCo gQSJ8uxqdyZ43MpUwqrO572YSYgRsJzOgUXlYbrzS8GcirxY/5AKqCTx3RrwL1bUEILF qaNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=tWqMQ6zndsnWXxc5QlSqUDcy3iitASWBvYGdWlMZ5/I=; fh=Xe3LoAlsGPKvxuAtawe4nf3R4RPL2hxDG0j4imBoV1o=; b=InOqLt8iFZHNaNiXSDLvQMkrT7wdA/aOR9QKQQmsLzcMdATXf/AI9s/vBbH9aOGUAk F0fWob5uXzzBuco6++yJ3AGx42gtnXN3jVRhF2zCFppncegoFYB8clh6FhVqF8zUh8ZL EXQ4F86fCs+QO0rpIGO4E0iAkccc7KVXzjdcbBCj029X23PLb2uwC5iixAFIKEthq+Gy AY6Rv22dZhVy1J9H3IZCrPGRaoxRGvMJgq2GCM8do4JTC7qOrXjRmmzj7sKZmMTG+CVE h6xDOt8bn2Rkq3WnTjaou4mr1Xrj9D4mAbc0uJ8iMzJ+jl3kLuKnJhICNc/WUSm2F2F4 LMEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=a2ZSyKfk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g17-20020a63fa51000000b00553a50c5d85si1786530pgk.510.2023.07.11.13.01.58; Tue, 11 Jul 2023 13:02:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=a2ZSyKfk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbjGKTct (ORCPT + 99 others); Tue, 11 Jul 2023 15:32:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbjGKTcs (ORCPT ); Tue, 11 Jul 2023 15:32:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42A410D2 for ; Tue, 11 Jul 2023 12:32:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 430BE614E4 for ; Tue, 11 Jul 2023 19:32:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5584AC433C8; Tue, 11 Jul 2023 19:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1689103966; bh=WbGGH319GGiAliOny1Q0FGLHKF8BtHi4+zSqoKNuvBQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a2ZSyKfkoLOLhvWO8FGdNVPfSyG27ErAEjli61nTXq9TEUiz31rUOWB0Bwa24zBlR bWe9aFNV2pjACx1jIHzhbZyXmky5VZTfH1HqoKDdAhDacDOYXhwg2HKVzoEwh3vrQ4 niTbR3LtGB2DB9HZ5LfrLHt4N7Sh8KFYbEt0tX0c= Date: Tue, 11 Jul 2023 12:32:45 -0700 From: Andrew Morton To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, songmuchun@bytedance.com, mike.kravetz@oracle.com, david@redhat.com Subject: Re: [PATCH v2 1/1] mm/filemap: remove hugetlb special casing in filemap.c Message-Id: <20230711123245.473400853fd1227459017650@linux-foundation.org> In-Reply-To: <20230710230450.110064-2-sidhartha.kumar@oracle.com> References: <20230710230450.110064-1-sidhartha.kumar@oracle.com> <20230710230450.110064-2-sidhartha.kumar@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Jul 2023 16:04:50 -0700 Sidhartha Kumar wrote: > Remove special cased hugetlb handling code within the page cache by > changing the granularity of each index to the base page size rather than > the huge page size. Adds new wrappers for hugetlb code to to interact with the > page cache which convert to a linear index. folio_more_pages() was just removed by "filemap: add filemap_map_folio_range()" (https://lkml.kernel.org/r/20230710204339.3554919-35-willy@infradead.org). It looks like simply dropping that hunk is OK, but please check. I'll be pushing this all out in a couple hours I expect. However the series which contains "filemap: add filemap_map_folio_range()" might be about to be dropped because of possible s390 breakage. Also, I don't think it's necessary to have a [0/N] intro for a single patch. Maybe crunch all the (useful) info into the single patch's changelog? Thanks.