Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5469d33c-8b23-79b0-3815-163908cffb40@infradead.org>
Date:   Tue, 11 Jul 2023 12:33:11 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2] lib:Fix more error checking for debugfs_create_dir()
Content-Language: en-US
To:     Wang Ming <machel@vivo.com>, linux-kernel@vger.kernel.org
Cc:     opensource.kernel@vivo.com
References: <20230711111727.2672-1-machel@vivo.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20230711111727.2672-1-machel@vivo.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 7/11/23 04:16, Wang Ming wrote:
> In case of failure, debugfs_create_dir() does not return NULL,
> but an error pointer.  Most incorrect error checks were fixed,
> but the one in test_fpu_init() was forgotten.
> 
> Fix the remaining error check.
> 
> Signed-off-by: Wang Ming <machel@vivo.com>

You need to send this to some maintainer who can merge it,
so please an appropriate maintainer to send it to.

Thanks.

> ---
>  lib/test_fpu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/test_fpu.c b/lib/test_fpu.c
> index e82db19fed84..5d6aa4691b4a 100644
> --- a/lib/test_fpu.c
> +++ b/lib/test_fpu.c
> @@ -69,7 +69,7 @@ static struct dentry *selftest_dir;
>  static int __init test_fpu_init(void)
>  {
>  	selftest_dir = debugfs_create_dir("selftest_helpers", NULL);
> -	if (!selftest_dir)
> +	if (IS_ERR(selftest_dir))
>  		return -ENOMEM;
>  
>  	debugfs_create_file_unsafe("test_fpu", 0444, selftest_dir, NULL,

-- 
~Randy