Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <30b63f35-1839-6870-d81b-1e8bff88dc70@intel.com>
Date:   Tue, 11 Jul 2023 13:50:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v2 0/7] x86/resctrl: Add support for Sub-NUMA cluster
 (SNC) systems
Content-Language: en-US
To:     "Luck, Tony" <tony.luck@intel.com>,
        "Shaopeng Tan (Fujitsu)" <tan.shaopeng@fujitsu.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Peter Newman" <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        "x86@kernel.org" <x86@kernel.org>
CC:     James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20230621174006.42533-1-tony.luck@intel.com>
 <TYAPR01MB6330B9B17686EF426D2C3F308B25A@TYAPR01MB6330.jpnprd01.prod.outlook.com>
 <SJ1PR11MB608331B7F85320DD4CD93448FC25A@SJ1PR11MB6083.namprd11.prod.outlook.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <SJ1PR11MB608331B7F85320DD4CD93448FC25A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVJuc3FIWDRKdDNQMHZZaU5xQ21hS1c0andkckl0NGw4MnFQTmpsOEpyUzZN?=
 =?utf-8?B?azh2eWozNkdnZ3V1SGxiQnZXOGYzcG02RU5DZ3MvZGVVbDEvOUdlQjVOZHdt?=
 =?utf-8?B?c3ZReXVDUnkzWGQ1YXh1REwveWM3azlBY04rM3JGL3BCQ1ZSSE1xN1d1VkFv?=
 =?utf-8?B?UGxIQTBXSXJZekN3TEpWdnJsZi9HZTBMc3AzaXBLSmJ3L2JLcWZUQXNBMnhX?=
 =?utf-8?B?QTZSU1NPSXJhRDNlRExqUWZEUUV0dEYwUjZOZ2dabzFid29McjhyRzdYUG04?=
 =?utf-8?B?LzU5bGR2UGV6UHBVaWFQdnRrQzVGaFpTb3gzR1hxT2gvUnFMNUlNYmRlY0ZY?=
 =?utf-8?B?cDZ1WXNPcFAwd2x6N2psUzY1Q3p2blVhblVUSWVzVWdIKzlxaWZsZEIxcXVF?=
 =?utf-8?B?bUxmdzhkOVgzTDhDYTRITkF2UmN5R0NzaDU4L0VUM2lheUdSTVJrdW5MQ3c3?=
 =?utf-8?B?d240MWVZY0lzWmY4eUVpMHIxWWY3L0YzSURGWFkzUThXSkcySi95aTNqbkxk?=
 =?utf-8?B?Uk9kc25aZjBhQmV5OWhLZ1d2NG84N1c3ZllxbHQ1eXZPSnNkUjUwQm1CbkE2?=
 =?utf-8?B?YjhCaURhV09sQXB5dTBER3MzOUFkOEVaV1ZKR1lFeWx2TkdmdTlzNFZsQW9k?=
 =?utf-8?B?c3JURGd6dWl6cnNCdWpxVTJZdmp2bmxLcjJmNWhaTllSd0FVMlpBbzh2WlY0?=
 =?utf-8?B?NklwVXl1ei9kQTJNeXo1a1VybitSK1RjQzJTam9wcmJPa0ZyQlNjOUk5VUww?=
 =?utf-8?B?aURlUjlqNEptd2lBN0hPc2tvYjNha0dua0VwNkpNa2RaZjYyVTRxcHBOTHpS?=
 =?utf-8?B?eUJ2TFllVG1KZStKSVg5eVl4S2ZTWFFsMElldDZYVndBK2E4YjFDM0JMZGly?=
 =?utf-8?B?L2g1NTdXNllPTkplVFJTV2MzaFlreUZ5emRrMmVrdUtTSTZYZFBzU3VsMXNm?=
 =?utf-8?B?WWMybHgzejFCYStsbmE4WmRJZ21OcnAxTzJYYjgwd3hmK25jYWpqS1ZuK2Vx?=
 =?utf-8?B?aW8vdEU3bjJtNFFlZmViM0h5UDBsNUNzcTNMaktBbVFGL1MxbWRxZm4xbmJu?=
 =?utf-8?B?MDJXelJjNG4wN05BamUrMDRHV1pIWERXTTdKempTSEFiU3hpckl5ZGNZVWR0?=
 =?utf-8?B?bHdBYlQ4bXdrUzJ4cCtCQ0pIc2kyUXM0NWRVeHNkL09qUUx0b1lNNU10Lytj?=
 =?utf-8?B?MGxPT0V5RjJwaDEwMHZaKzZiNG8ySDRIclhucGkzUjRWVXU1Vmx4aHVNLzJ0?=
 =?utf-8?B?aVVRbmpQZGNBdWZjZXovM1RKMHE3NWdsaERud1hnbXlyV0JPek9BTENGVUVN?=
 =?utf-8?B?YnNJNlVaaXdycjZqMmk2MWxIbERtRUw5WE1BTFZIcWhNT0xDcWlxWW9oVkll?=
 =?utf-8?B?TkJjTGlCMWsrREowQ2h4SEppWlAvS3BTWHFBRnJxZzVNc3NIRkRZdTR5WXpB?=
 =?utf-8?B?T0NUTmVKeVdpZzNadEU3YjZqYTBGRTZBZ1U2cUFmUmw4cGtCQUM2a3ByRjdE?=
 =?utf-8?B?RkRQTm9rTjI2YmJmeFBIQlB2SVdycnczYXhlNHNlOS9SNEltV3ppeDNpRERj?=
 =?utf-8?B?NUYyQVB6UzdRSExBeWMyQTJPWkpIT2ZUcFRRbmFjUFZqYzhTY2J6ajRYY3Vn?=
 =?utf-8?B?UDRHbnVzR1F0aUVIQlVGRzhFaEpoK2tzYi9iblRsditrWDNhMlZ6QkUveEta?=
 =?utf-8?B?bFVZMVNtTFcrck1nc1JwalVIRk9na1hBZDAvMXBGL2ozMU9EdmUvMTNsLzBo?=
 =?utf-8?B?M05IaXV5VU1sRjZrZGE2dUhyUnlZNDV1YWVDL25SNjRXWUxMZWtuZmczTVQ1?=
 =?utf-8?B?M2hqNVB0eG5lOXpTOXVGUngwNWU2YURERnJHb3pxK3E4SUJuM1VkOTFrYnl2?=
 =?utf-8?B?ZEQza2tBUWdYRjA4dTlVMHV6S3dERHBVVmI2WE9FSmlTZGx4TDFyVHVWdlNy?=
 =?utf-8?B?Zm9JV1FKbWpUUXMraEFhOWp3MkNCQjI4M2NYNjYrdUJ2eTJiNjRyUkxmMTJu?=
 =?utf-8?B?eE9lYXZJQ0N0Smo2SDlvL0xPS29hT1JVYjJYUTVNMnpaVlZETTdJZm1Yemt2?=
 =?utf-8?B?dUZTSzJkYXpFWk15ODJxa3NSVzNmdVh3U2gwZmtKMDgyc3dQcklEZ1pVRWZn?=
 =?utf-8?B?RFBvYUZLTnRPb25PcVZmdStYTUJGKysxekRZM0NKeEhFQkdDVGhxWHh5ejB3?=
 =?utf-8?B?K1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dd14d848-8fc5-43e2-0d8b-08db825067b3
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 20:50:05.3486
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dFTjUJPeLwuQYGJOSjtyhoRkrQMgwE40CW949yxRt/BwC5Zw2C9KkRtTlFd7FFrPf6Asv94VEJh4ELeBRYqw2viAc9ZC9vMkHcA9oOwsUlg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8147
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Tony,

On 6/29/2023 9:05 AM, Luck, Tony wrote:
>> I ran selftest/resctrl in my environment,
>> CMT test failed when I enabled Sub-NUMA Cluster.
>>
>> I don't know why it failed yet,
>> I paste the test results below.
>>
>> Processer in my environment:
>> Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz
>>
>> $ sudo make -C tools/testing/selftests/resctrl run_tests
>> # # Starting CMT test ...
>> # # Mounting resctrl to "/sys/fs/resctrl"
>> # # Mounting resctrl to "/sys/fs/resctrl"
>> # # Cache size :25952256
>> # # Benchmark PID: 8638
>> # # Writing benchmark parameters to resctrl FS
>> # # Checking for pass/fail
>> # # Fail: Check cache miss rate within 15%
>> # # Percent diff=21
>> # # Number of bits: 5
>> # # Average LLC val: 9216000
>> # # Cache span (bytes): 11796480
>> # not ok 3 CMT: test
> 
> This is expected. When SNC is enabled, CAT still supports the same number of
> bits in the allocation cache mask. But each bit represents half as much cache.
> 
> Think of the cache as a 2-D matrix with the cache-ways (bits in the CAT mask)
> as the columns, and the rows are the hashed index of the physical address.
> When SNC is turned on the hash function for physical addresses from one
> of the SNC number nodes will only pick half of those rows (and the other
> SNC node gets the other half of the rows).

If a test is expected to fail in a particular scenario then I think
the test failure should be communicated as a "pass". If not this will 
reduce confidence in accuracy of tests. Even so, from the description
it sounds as though this test can be made more accurate to indeed pass
in the scenario when SNC is enabled?

Reinette