Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp37474424rwd; Tue, 11 Jul 2023 15:04:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlH++MKG+S27gI+2C+WqrUfvCY74WER0cIiP+AeTlFlMZdSP2beW0dTg6BkCMOWRSEHNffoN X-Received: by 2002:a17:90a:d710:b0:263:484c:f173 with SMTP id y16-20020a17090ad71000b00263484cf173mr16283170pju.2.1689113041289; Tue, 11 Jul 2023 15:04:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689113041; cv=none; d=google.com; s=arc-20160816; b=inHaSWkye6mgOM5L6OWggxPkxxNfE8IGw1AKch7jdAa7cTedpwDzDenBufiCYqD+W3 XU27I02KFbXC2ioxCLQJUuCDy++QaszHWkexwBcoVE70FY5z7m0+k4RkgSoeHwoDiaj9 AWfEu7nvRlMihw5N3moMW6L66Z4AgtDaFRnpuHzIuO8E1l576Wi++6ufo7CO2eiOhuf2 ETnc/9zECYc756Fstw/3xMROrMe6bASaowHnrb4deOuTgYZyd6D86y9aFVce6R6lpx4P drZRY5jwOrmbXRrgjJEwN4T3GOvolWfYwNhTN8IEu+POA97oXlWda7mI5yQ/huIngE/g bGsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vppmwRRbyi5GVcqEuzCwPvW7VSP+pm8Knc+bGCD6gFQ=; fh=s+24io6Vteq8U9Jvo2ibACpgDYIEYSnnTvp2JscmQ1Y=; b=K9v49/u0JQ29n/Wmvy+SGa1h4mS8wN4SD2ydaDDbofCgG/0sPp2YHoBNQdyJaKsyJr BQ+GYsbg9dzSgVE4F5lp0heTTE5EAjME9U4UK/JxX20wvOlLPjOJtEZ0iOpC3c7ojasZ pRwRWHXenq6mXVM8IWQigfKGFXIaZMExDGQ7GtpsujSL3RYuEWwApIbHLd1dyyT1xCup Oim8RebibR5t7DlgtL2uWso2OgCIZrJr2nX6lHbSINZ6vcYwnF1RjGW5Yiy4atGTO/RR YTwjE9fMoc4KLMcjoWJsc5qukuIBKktEfx8Xo5LUPbT/rZBjLXxrrvwoqjRnpAfHcVFD Eltw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=juHvMnq0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l16-20020a635b50000000b005578994f212si1914187pgm.425.2023.07.11.15.03.44; Tue, 11 Jul 2023 15:04:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=juHvMnq0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230133AbjGKVae (ORCPT + 99 others); Tue, 11 Jul 2023 17:30:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjGKVad (ORCPT ); Tue, 11 Jul 2023 17:30:33 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A7D11B for ; Tue, 11 Jul 2023 14:30:32 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1b9d80e33fbso17746205ad.0 for ; Tue, 11 Jul 2023 14:30:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689111032; x=1691703032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vppmwRRbyi5GVcqEuzCwPvW7VSP+pm8Knc+bGCD6gFQ=; b=juHvMnq0uCdj1HrRrOHCtvwCA9TetWPKCCAqRCWccouGKKaqd02BVbQ7UQ36p5PJt5 iv7CfkmNlhEj7Bgo8J/R+bjVipGnHcitAhpid5NVPXlIMYXs0xfCSMhiil55sQ2gx1FY 6PX1x5/5QqPiZLJITUBToOOzNPzNKyvODmJjA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689111032; x=1691703032; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vppmwRRbyi5GVcqEuzCwPvW7VSP+pm8Knc+bGCD6gFQ=; b=jfUTvaaz2V8+jU/p5F2BoeWXYlceQG1EYktpZ/oeYjVdTpU+sEfMvInXwAgrEXCz+m pV08OtMFMyS1v1+t2IbpLOuCKQ+GEzD41t8tDc5YxFEp//ih6+sfSgaYVhXcVhY5keui olsfjV2DX+vHcrQGY0B0bO74Dop1xwYXAYSd6yxYnM0/bO6/A5zF06HPMR0lLRcsD4t5 e7dbSjgKsf5cozshhBSXPeWYRh1/9T5g1GwH1IbNt8T3y/G4wkFv/nyM55AlzZdEt34p ctHduqNI2eZf+BL9HSRakNBj5J2OcfsaPNIHYu86wp9RcNl7Uqn8hR4tcew3ZCNaoXIb axGg== X-Gm-Message-State: ABy/qLY2tHACPma0WYDv+Q4bkiRS8zZ3esBV/lG8rfFGdp7s0L6401qJ fSQuiQhco+r7LZnlqyEai83+99OpBoOAxTp028c= X-Received: by 2002:a17:902:da89:b0:1b8:5541:9d5b with SMTP id j9-20020a170902da8900b001b855419d5bmr14314325plx.17.1689111031869; Tue, 11 Jul 2023 14:30:31 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id h2-20020a170902f7c200b001b9c5e07bc3sm43847plw.238.2023.07.11.14.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 14:30:31 -0700 (PDT) From: Kees Cook To: arnd@arndb.de, Petr Pavlu Cc: Kees Cook , will@kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vmlinux.lds.h: Remove a reference to no longer used sections .text..refcount Date: Tue, 11 Jul 2023 14:30:22 -0700 Message-Id: <168911102014.3161793.10168759191370577926.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230711125054.9000-1-petr.pavlu@suse.com> References: <20230711125054.9000-1-petr.pavlu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Jul 2023 14:50:54 +0200, Petr Pavlu wrote: > Sections .text..refcount were previously used to hold an error path code > for fast refcount overflow protection on x86, see commit 7a46ec0e2f48 > ("locking/refcounts, x86/asm: Implement fast refcount overflow > protection") and commit 564c9cc84e2a ("locking/refcounts, x86/asm: Use > unique .text section for refcount exceptions"). > > The code was replaced and removed in commit fb041bb7c0a9 > ("locking/refcount: Consolidate implementations of refcount_t") and no > sections .text..refcount are present since then. > > [...] Applied, thanks! [1/1] vmlinux.lds.h: Remove a reference to no longer used sections .text..refcount https://git.kernel.org/kees/c/5fc522485598 Best regards, -- Kees Cook