Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Jul 2023 15:11:22 -0700
From:   Isaac Manjarres <isaacmanjarres@google.com>
To:     Mark Brown <broonie@kernel.org>
Cc:     Russell King <linux@armlinux.org.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
        Saravana Kannan <saravanak@google.com>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
        Amit Pundir <amit.pundir@linaro.org>,
        John Stultz <jstultz@google.com>, stable@vger.kernel.org,
        Catalin Marinas <catalin.marinas@arm.com>,
        kernel-team@android.com,
        Russell King <rmk+kernel@arm.linux.org.uk>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] regmap-irq: Fix out-of-bounds access when allocating
 config buffers
Message-ID: <ZK3TiuPZr0A8iaNN@google.com>
References: <20230711193059.2480971-1-isaacmanjarres@google.com>
 <8e5fba54-9ec7-45a7-8dd6-6ea63d853907@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8e5fba54-9ec7-45a7-8dd6-6ea63d853907@sirena.org.uk>
Precedence: bulk

On Tue, Jul 11, 2023 at 08:50:08PM +0100, Mark Brown wrote:
> On Tue, Jul 11, 2023 at 12:30:58PM -0700, Isaac J. Manjarres wrote:
> 
> > [   14.033877][    T1] ==================================================================
> > [   14.042507][    T1] BUG: KASAN: invalid-access in regmap_add_irq_chip_fwnode+0x594/0x1364
> > [   14.050796][    T1] Write of size 8 at addr 06ffff8081021850 by task init/1
> > [   14.057841][    T1] Pointer tag: [06], memory tag: [fe]
> > [   14.063124][    T1]
> > [   14.065349][    T1] CPU: 2 PID: 1 Comm: init Tainted: G        W   E      6.4.0-mainline-g6a4b67fef3e2 #1
> > [   14.075014][    T1] Hardware name: Thundercomm Dragonboard 845c (DT)
> > [   14.081432][    T1] Call trace:
> 
> Please think hard before including complete backtraces in upstream
> reports, they are very large and contain almost no useful information
> relative to their size so often obscure the relevant content in your
> message. If part of the backtrace is usefully illustrative (it often is
> for search engines if nothing else) then it's usually better to pull out
> the relevant sections.

Hi Mark,

Thanks for your feedback. I'll go ahead and send out a new version of
the patch with a trimmed down commit message.

Thanks,
Isaac