Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Jul 2023 08:46:13 +0800
From:   Baoquan He <bhe@redhat.com>
To:     Simon Horman <simon.horman@corigine.com>
Cc:     linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
        linux-mm@kvack.org, schnelle@linux.ibm.com, vkoul@kernel.org,
        eli.billauer@gmail.com, arnd@arndb.de, gregkh@linuxfoundation.org,
        derek.kiernan@amd.com, dragan.cvetic@amd.com,
        linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com,
        linus.walleij@linaro.org, tsbogend@alpha.franken.de,
        joyce.ooi@intel.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, tglx@linutronix.de,
        maz@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
        robh+dt@kernel.org, frowand.list@gmail.com,
        kernel test robot <lkp@intel.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM
Message-ID: <ZK331Ru27wiRApF2@MiWiFi-R3L-srv>
References: <20230707135852.24292-1-bhe@redhat.com>
 <20230707135852.24292-6-bhe@redhat.com>
 <ZK2Ok5i2m7zS6Uq0@corigine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZK2Ok5i2m7zS6Uq0@corigine.com>
Precedence: bulk

On 07/11/23 at 06:17pm, Simon Horman wrote:
> On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote:
> > On s390 systems (aka mainframes), it has classic channel devices for
> > networking and permanent storage that are currently even more common
> > than PCI devices. Hence it could have a fully functional s390 kernel
> > with CONFIG_PCI=n, then the relevant iomem mapping functions
> > [including ioremap(), devm_ioremap(), etc.] are not available.
> > 
> > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built
> > to cause below compiling error if PCI is unset:
> > 
> > ------
> > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined!
> > ------
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> 
> 
> Reviewed-by: Simon Horman <simon.horman@corigine.com>
> Tested-by: Simon Horman <simon.horman@corigine.com> # build-tested

Thanks, Simon.

> 
> I wonder if this should also have:
> 
>   Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig")

Agree, it's worth having Fixes tag.