Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp37655829rwd; Tue, 11 Jul 2023 18:11:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlE4mh/lsgPtiwu81bYDo2/bF3viM7ucZ2q6HkqhQwp0RPeFFvxk0NuyGuXZXGNS4K1X/Xwi X-Received: by 2002:a17:902:da83:b0:1b8:811:b079 with SMTP id j3-20020a170902da8300b001b80811b079mr21752143plx.0.1689124310852; Tue, 11 Jul 2023 18:11:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689124310; cv=none; d=google.com; s=arc-20160816; b=k8rYKLMguY4w6yearVJ1FTuKODHqReuTSHb7JHEsZ2d1Mh1q2U5FsVBwyfImqfC1F2 o7NIKtrl5HO6cU41LbgebHXIOHBcXqNZNg4Xji05T+pX/iLVNcQgYGCfi/bBJ/mpIc6y KlqEUnoSuYr7Zavw3b3PUBsJikfNZoDY6WJBRTs5qRuLC6Gnsx1RAO2jL2x3UIrv41xn f8vQGS7eoQRzJ2Wq+Iws7O164k6JSRg04eezLUaM3cRXT98o1w+qX1x00JBcfx/cFmVs hXPjkU0a9xnSzDbdcJgBgeL+lenmQALCO0dFfY0R337uj4TfRJzO/wjOLBkhBSMla/sG 81Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=1SJ1j4maM2XxXJItaD7UXJ0dJsCEccMcu8OTpfjikzA=; fh=bWL6BeFKyiNf/dXrU77UZ8uwce3/WtoMugPBn465n8o=; b=gD1QnKZghFM77Ud4mhTwUckAUpem8gRKCgrByYW6OF28rhivPqiC5yLcAm2fElAEEb oRHBZbAPEY75udPvkJXpcaCxHx2l9xCZBLofVtU+L1pojuiXhrWbHJFqMzb6bFJn4CSp zSwsd4ygqOhVgGWvsN5cpBGhdvlVDI2V4miF5BT+Cm4DVehwpknjkNt3pfyo2A1xS/ES Ril3ZljYY4kWUbRt/2/lFsh3Y/Xe68hyJsC0Bf14b2hsob+DQuSU4naU1P25hMU2U3Fv g4Fyk3LAG4xXpxvOrZbAMZMp/h2gbQsvd6iTPh6HHpYm9h11kQ/8AXRqH3VXk209D2Ab 6E8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mwTt0Zwr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l4-20020a170903244400b001b864e1a02asi2488192pls.393.2023.07.11.18.11.37; Tue, 11 Jul 2023 18:11:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=mwTt0Zwr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230482AbjGLAnO (ORCPT + 99 others); Tue, 11 Jul 2023 20:43:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230505AbjGLAnN (ORCPT ); Tue, 11 Jul 2023 20:43:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A30A210CF for ; Tue, 11 Jul 2023 17:43:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3557061646 for ; Wed, 12 Jul 2023 00:43:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71293C433C7; Wed, 12 Jul 2023 00:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689122591; bh=3axPrmw4y+Z5QNRDwLTeMrlIrd2WntruvKqrhdFFYmM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mwTt0ZwrbSwt6DgNqES8kDj+5RMcNhfrQrbiWg0dVFfvUkMt0HKJWl6p2R8Kie5mT D6dnVGoSIFngz+BxVvaxkZNE2Rza1kdSPp6calPGoldzViiWnkS6L7J3KG7j7CMO5Z lk+d1pzgL061te0QQLJqjnOm4w6UGxUH4TKTV7eKWdOtx17Rvx2j8PLmtUpz2nbyOd /pDGiZ0F2YiZO6K0EaITAa4PfkVdkKr/G2M4XIE0vzZrMT7aUWSP5mmsaPEW/out3w EVz6Sq1xySXp6gzoper8xpSruI/hqhbKaRfpUtfaoBJ+U5C8UsUZ2WfYWoMGXKSlL+ dp0sDmQyr3VcQ== Date: Tue, 11 Jul 2023 17:43:10 -0700 From: Jakub Kicinski To: Andy Shevchenko Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni Subject: Re: [PATCH net-next][resend v1 1/1] netlink: Don't use int as bool in netlink_update_socket_mc() Message-ID: <20230711174310.081a2574@kernel.org> In-Reply-To: <20230710100624.87836-1-andriy.shevchenko@linux.intel.com> References: <20230710100624.87836-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Jul 2023 13:06:24 +0300 Andy Shevchenko wrote: > The bit operations take boolean parameter and return also boolean > (in test_bit()-like cases). Don't threat booleans as integers when > it's not needed. I don't have a strong opinion on the merit. But I feel like the discussion is a waste of everyone's time, so to discourage such ambivalent patches I'm going to drop this. -- pw-bot: reject