Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 11 Jul 2023 20:54:42 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        John Hsu <John.Hsu@mediatek.com>, stable@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH stable v6.1] mm/mmap: Fix extra maple tree write
Message-ID: <20230712005442.r5ehzbkcxu73whvb@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Greg KH <gregkh@linuxfoundation.org>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        John Hsu <John.Hsu@mediatek.com>, stable@vger.kernel.org,
        linux-mm@kvack.org
References: <20230706185135.2235532-1-Liam.Howlett@oracle.com>
 <2023070748-confiding-abnormal-b7e3@gregkh>
 <20230707164507.mfekysya2jyupghp@revolver>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230707164507.mfekysya2jyupghp@revolver>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KMxq/8yF2Vi5co9feTUEMClrFucdytLC6BxR8QhWCMdBatOoMnp2bL3Y5HES?=
 =?us-ascii?Q?HA1IVekZKOhY1Ka89klJWDhlRcYx2kSKI3xLyhbxUNgB+gRDNzpO+mQ8gO4O?=
 =?us-ascii?Q?7lhS5zH4LYYCctOADsUtdAE35J4xLyhOB8PLp9Gd7sKIfkIXMlzxj+3wk27Q?=
 =?us-ascii?Q?mp6fTE+FjgN+Re/oiFbr5eqghlI1zNRnk4Kh9vaQbZODAKQaEsP1jMbkmP/H?=
 =?us-ascii?Q?diMTlvLVCjX7gJAL3HMeJ0+1QU/Z8BH1GTnXUh/7y9Yj0IB0HsAVA6lpdFVf?=
 =?us-ascii?Q?ETGlTWHiZeDmMnKwww1z/4j8jikMqdWIahTQR4cifqN2AETE1q4RmCN1YxJQ?=
 =?us-ascii?Q?iKHx2cPKPSrZk1UffduoSa8zZZzzoytU7oNu1GFAghwOvM1bPVG+2i0gAHRK?=
 =?us-ascii?Q?zhwYmkPWx0Q7qcv1zMgsGpv4OhjqCmv8u6pMNtXmQYUMBU7eLJA0zVWMbpXC?=
 =?us-ascii?Q?Zlah6Sq0Ap7UkLfDtace2deJqp+tu5RHt3wGoI3WPeOiS/gzbZXOXTFPp14T?=
 =?us-ascii?Q?Q2ejnXxn9PNMU4f95ZH2AzNFYvK/+jSHSJXaVEsTxcplhEG67omXh/oX9pze?=
 =?us-ascii?Q?Ujb7mnHXm+6t38YOGjnuzhBxV7Nj8RqOEWXNZ90rL/bluzrYlPWkAdolNPdw?=
 =?us-ascii?Q?iWJCT5iqdXT9iosLvhw0ZE8LEuLxpfbKT8W8pFBKun+cuw5+BBkKIeM1f/U4?=
 =?us-ascii?Q?zRF/ATVcg1wKHf6o6JNaojh5unOrTDEPAJjKkbRZ2WT1KD31HeK+u+Tqhzzn?=
 =?us-ascii?Q?t7RpysuaqU4KjYB9C2fpSjSAHFUOwi6NIX+p8bG8utdLlR2oDX75WeorTnYS?=
 =?us-ascii?Q?v3WwTbWHHzNQjUOvXGblbFJbtLzpHsNYOhc9/hxSMlGH9bjB99GGLsyU1dyC?=
 =?us-ascii?Q?uxbFCe7/kirGg3vlxTwuedYcbpYLYudpi1a9jBjpPrEOngdGqwI1jME9i1KC?=
 =?us-ascii?Q?EkZVgfAGdTvQRFR95EN2bioZAZvSMVytEfxGSaU2y9Xcv37AnDsmwQyR83Ow?=
 =?us-ascii?Q?7rrr99L7ibILkCM7uBRjw4W85Yb1V8+LHH/Fn6dAsj3ORTzjQElKPnkE8wuE?=
 =?us-ascii?Q?PVmw4pLH3VnhGRPbnA8xqWnSZ9fCZXSxCBz33PjM4/rP9+KBA06PWVkL9H02?=
 =?us-ascii?Q?YPYsc0eEdtSzoY9SQoywEVFIZdo07bv6vMGpSFq5v+enCAw08/TNczL2Y40F?=
 =?us-ascii?Q?/DAvSGF6saVEjC/aw1BD2I7j1bp8D0OkUfQFLIpZO6QTTsHR/N+qGKdiQzIx?=
 =?us-ascii?Q?DlBUoplU95HwJzSC0HjKJUgc1Y6IijEqcWwuiy72bOICZtC7PGxdCOsk9by0?=
 =?us-ascii?Q?fep/eo2v1mcTjpsM0yvqEhUNqPsi+K3d1+lUOxqCLRuwq/cYVXax2LCIB2PM?=
 =?us-ascii?Q?NiMlmXRNVJ3LhO+ITvz9kgZDuyXvuv6di0kEClQcbhI3kc5kOaru4oeaBd/j?=
 =?us-ascii?Q?Ba/9Br/qmfmZCAf40liFcE1aQ7Bw++wh4H6/b+GNJexrTf7AHrOeCclx8H95?=
 =?us-ascii?Q?pDWiN2h+MDDGrInYadnL84BkthyIFOlUL70lxIKzSDul/3z/aiAxJkz3MtWZ?=
 =?us-ascii?Q?9FMzyKz12gY2KU3si7gCyVB3+Utb+iKMUkiURdKwtBf9q3GK39PGil8LlUlB?=
 =?us-ascii?Q?3A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?3s5I6i6IufgsmdJLI/pS1QOnk9O/uE3zaSO3ZmRHl6b3vQ1GTHv8TmSPft3z?=
 =?us-ascii?Q?5LbKV7oPkNOTvC7ukgDX3GQvJXAHL96ZO8R++ek7d4h0V6Hvn6L1QBBESpsL?=
 =?us-ascii?Q?RyufsPcMOlycvtSVGKaNLSTmuwlLUq0lQxgqsK0HL6W/qymRNgIQQUe+MGd7?=
 =?us-ascii?Q?i56zLDR/q+o8ZNclNPS1lelhGf+SHne35a04Lz80wmY13ofismeqbUcbT8Ao?=
 =?us-ascii?Q?2lQQJ/A2eu2fCylo3DktbqTFB5BQsb85wpcmyTteIw2QpAuYYoLeDBkErE4T?=
 =?us-ascii?Q?hysRc+oABKO9A21IH8r2vdrDY3luXn+7zN9CQnq2hDnwa5OEgug+W0CNLtxg?=
 =?us-ascii?Q?hL1WJ5ovwmLZ0S8h8MDk5r8c5pCzYoeZpHW/py1xCT32Nvjnoq8hNDY3N5GO?=
 =?us-ascii?Q?YzexoAqa7TKD2Bfj3At3hw5RHha5Lz024evq2tJ8Om2NlB1f05rJ6lJVdV/8?=
 =?us-ascii?Q?4+aKbCIL/Mg4syXzi3B1ploPlttXGbmmZFgU9gChyxxc7rpqD8V4CVg6T0V0?=
 =?us-ascii?Q?tvXHnGI9F2cAxngf/+FdMT+P/r2RzIm8aAbfxwsJQrTMHS/UCLMhm1sq1SL6?=
 =?us-ascii?Q?EavdXKeo9f3ywiqRltOTZP+uQ2SR2AwHaqdIb1BTQUBs8WnjDhxKFPNAcDOW?=
 =?us-ascii?Q?I2QgBdJ/0WztabxmALmAPvpjGKM0q9FR3E0Zm3UsvVH2djh8axTIhdHEsw02?=
 =?us-ascii?Q?qxrZWkAwZY06XElJJseMXvQrEspmfokCxJyfhAA+WXTuDRui8jxCVuJV4IEh?=
 =?us-ascii?Q?yIOIGUq+DTSI687RxzxyARcbZxlSBd59MuMj8DEj+Wa5jof1a6Og+URX+ML6?=
 =?us-ascii?Q?S8KQaJmP2X/Fp4QYv6l9l69RDI2cSs/jqctr7RUk1d3zCXPu2G5La1LJtuGh?=
 =?us-ascii?Q?JCY+pjLz70r3g3Vl8Ph1JWWuTHNjphbnwhV146RWf0qHW9qp6K9Fj5APUv91?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 670ff1a7-3abd-40f7-d3bc-08db827295a2
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2023 00:54:45.5418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 04maT3div4bJ/WmJCgfTHBmhzTIe2RNnrwe7JPDt/ykweKFNNDeSpc2ZdbPdbsBfXkSu/NuS9UuSdJ+pP9x/nQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB7534
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-11_14,2023-07-11_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=872
 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2307120005
X-Proofpoint-GUID: Zo9nULkzfFC624Owi2V4BL4XUpvdcSZu
X-Proofpoint-ORIG-GUID: Zo9nULkzfFC624Owi2V4BL4XUpvdcSZu
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Liam R. Howlett <Liam.Howlett@Oracle.com> [230707 12:45]:
> * Greg KH <gregkh@linuxfoundation.org> [230707 11:55]:
> > On Thu, Jul 06, 2023 at 02:51:35PM -0400, Liam R. Howlett wrote:
> > > commit 0503ea8f5ba73eb3ab13a81c1eefbaf51405385a upstream.
> > > 
> > > This was inadvertently fixed during the removal of __vma_adjust().
> > > 
> > > When __vma_adjust() is adjusting next with a negative value (pushing
> > > vma->vm_end lower), there would be two writes to the maple tree.  The
> > > first write is unnecessary and uses all allocated nodes in the maple
> > > state.  The second write is necessary but will need to allocate nodes
> > > since the first write has used the allocated nodes.  This may be a
> > > problem as it may not be safe to allocate at this time, such as a low
> > > memory situation.  Fix the issue by avoiding the first write and only
> > > write the adjusted "next" VMA.
> > 
> > Are you sure this is the same git id?  The one you reference above is
> > _VERY_ different from your 2 line change below.
> > 
> > And the changelog text is not the same.
> 
> Yes, but I am not sure I've indicated what happened correctly.
> 
> The bug exists in the older __vma_adjust() function, but I removed
> __vma_adjust() and inadvertently fixed the bug.  So the bug doesn't
> exist upstream *because* of that commit:
> 
> 0503ea8f5ba7 ("mm/mmap: remove __vma_adjust()")
> 
> My comment after the commit id indicates what happened, but the
> documentation wasn't clear to me on how to specify what happened.
> 
> Does this answer your question?

Friendly ping on this one?

Thanks,
Liam