Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a7885677-68ef-59c8-0639-579a688fcdad@kernel.org>
Date:   Wed, 12 Jul 2023 11:42:40 +1000
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2 2/2] riscv: support the elf-fdpic binfmt loader
Content-Language: en-US
To:     Kees Cook <keescook@chromium.org>
Cc:     linux-riscv@lists.infradead.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, palmer@dabbelt.com,
        viro@zeniv.linux.org.uk, ebiederm@xmission.com, brauner@kernel.org
References: <20230711130754.481209-1-gerg@kernel.org>
 <20230711130754.481209-3-gerg@kernel.org> <202307110852.E093C93F@keescook>
From:   Greg Ungerer <gerg@kernel.org>
In-Reply-To: <202307110852.E093C93F@keescook>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Kees,

On 12/7/23 01:53, Kees Cook wrote:
> On Tue, Jul 11, 2023 at 11:07:54PM +1000, Greg Ungerer wrote:
>> Add support for enabling and using the binfmt_elf_fdpic program loader
>> on RISC-V platforms. The most important change is to setup registers
>> during program load to pass the mapping addresses to the new process.
>>
>> One of the interesting features of the elf-fdpic loader is that it
>> also allows appropriately compiled ELF format binaries to be loaded on
>> nommu systems. Appropriate being those compiled with -pie.
>>
>> Signed-off-by: Greg Ungerer <gerg@kernel.org>
> 
> ELF stuff looks fine to me. If the RISC-V folks are happy with the rest,
> this looks good.
> 
> Acked-by: Kees Cook <keescook@chromium.org>
> 
> Please feel free to carry this in the RISC-V tree. If you'd rather it go
> via execve tree, please let me know. :)

Thanks for the feedback, much appreciated!

Regards
Greg