Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230706094635.1553-1-luhongfei@vivo.com>
In-Reply-To: <20230706094635.1553-1-luhongfei@vivo.com>
From:   Ian Rogers <irogers@google.com>
Date:   Tue, 11 Jul 2023 22:02:58 -0700
Message-ID: <CAP-5=fWs+19O-tHUVtxY79svL-oFjKDO-0-bF1Kdn2+VObxxaQ@mail.gmail.com>
Subject: Re: [PATCH] tools: perf: Two typos have been corrected
To:     Lu Hongfei <luhongfei@vivo.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        opensource.kernel@vivo.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Jul 6, 2023 at 2:46=E2=80=AFAM Lu Hongfei <luhongfei@vivo.com> wrot=
e:
>
> When wrapping code, use ';' better than using ',' which is more
> in line with the coding habits of most engineers.
>
> Signed-off-by: Lu Hongfei <luhongfei@vivo.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-diff.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
> index e8a1b16aa5f8..57d300d8e570 100644
> --- a/tools/perf/builtin-diff.c
> +++ b/tools/perf/builtin-diff.c
> @@ -1915,8 +1915,8 @@ static int data_init(int argc, const char **argv)
>                 struct perf_data *data =3D &d->data;
>
>                 data->path  =3D use_default ? defaults[i] : argv[i];
> -               data->mode  =3D PERF_DATA_MODE_READ,
> -               data->force =3D force,
> +               data->mode  =3D PERF_DATA_MODE_READ;
> +               data->force =3D force;
>
>                 d->idx  =3D i;
>         }
> --
> 2.39.0
>