Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp37941096rwd; Wed, 12 Jul 2023 00:17:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlG+H6DI1suQBU6Z/2szoEZUq0LsPoc3EHR/L9QGsChOEB6ZcaZT50bCBXdn5YzjLwTYWRvT X-Received: by 2002:a05:6358:724a:b0:130:ebb9:4283 with SMTP id i10-20020a056358724a00b00130ebb94283mr17390643rwa.22.1689146249492; Wed, 12 Jul 2023 00:17:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689146249; cv=none; d=google.com; s=arc-20160816; b=eXeOCr51fZB/glqhRpQqjwFl7Ry1DjOXeeFsSuHYkroBAt9sRWoNHp+gbgih35Wo48 WZvGpBu1TI2a+53FgAhx4nujz5b8BKwQ+XEW9efhywxP98tlaS9+DW3Up4e6woCzHYnQ L4XDwhuHJJDhuN4uW9hucfOYjXRN6vPtvvqkzarV8KKJg7KJIR/Uq/sjDTk0qJp6Cequ QJNmTHCBWX8YKuG3k0qAhuoDe05n/bIFi0lQtZFe40VEieSTeabaKfiUW/Pb0KAvRJgV EdT7J5LnouCOmsCQLvYJSQJqK+leDX0IZwsJ4ILAKPQQMvJso6Q16FiecZfkQZr6nL7v Cogg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=tUJlXfHGfo3x5z+xERqWOPEPG3lN8FOJE4GJzec3oY8=; fh=GYvHHjGkWcz+XW9azSpDRkiZj2cmagJT82XXTKQw028=; b=pxFVcImtANws8lchwisf/cb6o6Q0k1jLUkJULa2iCCgkVPcRBG7pVM1gDiXsuYFna/ kvY2DnhBx4HHihqUYMV/BREbIlTlz1cUuykc1Yd3ixfdHDOfWbEIh/brQSlXOiSbyO9A VItGHGTH1cYj4bq9oWeAgqI6PVd/IGCe+DxT2CPv09PqT6t0b+0XE51o7E2Pqs3AyqQW ENA9yN6VyDIKg1+etOSU8vgWAlbcVKWpsxh2hYq5cnpNTVDgpnXbYa+LHoakokJAc0Z0 hniBh+6u2BnoRd8Wz/bEMXbNmglln0u7qjw0ZxnTjk7L77falW00HSJvTq44W/t8wFFc mNsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="Hz6WfZq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i8-20020a639d08000000b0055bce775e67si2695839pgd.159.2023.07.12.00.17.17; Wed, 12 Jul 2023 00:17:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b="Hz6WfZq/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231689AbjGLGv2 (ORCPT + 99 others); Wed, 12 Jul 2023 02:51:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbjGLGv0 (ORCPT ); Wed, 12 Jul 2023 02:51:26 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6C5D1703; Tue, 11 Jul 2023 23:51:23 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C05B06607014; Wed, 12 Jul 2023 07:51:21 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1689144682; bh=ZNA3nvg6eJG/Hc6v4LETHxYo8klNpKbEqdasNgN40TM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Hz6WfZq/B8W0c8j7bRzhi/YwO458dsPEPQcPLnPptua6XcAvGvof5HL2dCZpCNb/z TyFW3UHMcrrXyHj973nADh3nAilMZB0L2GeBWKu9bH8W/PqozAmSgNRgI3xIrgbo0K JyzPTzteAlphuBJ4ev+XPXjYmC7E77A8gDNHgUbf/5voO3xx/d/2CWsmkc9lZQDR8T kBoyC6Dq7XvkIxA/vBjh/bzThdghSKZOVBqTzBHbPGB/VfyIjRhEFKYamFVAknFjO4 VMlog89isIKrVpZ/4r40ceTosKKsvFqJ1FRcY5DXS6roseM0+yzBARj8aY2UQSLolG A1h8L/Pn0jinw== Message-ID: <212a4999-eacf-12d9-004c-e47f52022176@collabora.com> Date: Wed, 12 Jul 2023 08:51:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH -next] scsi: ufs: ufs-mediatek: Remove surplus dev_err() Content-Language: en-US To: Yang Li , stanley.chu@mediatek.com Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, matthias.bgg@gmail.com, linux-scsi@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abaci Robot References: <20230712064832.44188-1-yang.lee@linux.alibaba.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230712064832.44188-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 12/07/23 08:48, Yang Li ha scritto: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/ufs/host/ufs-mediatek.c:864:3-10: line 864 is redundant because platform_get_irq() already prints an error > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5846 > Signed-off-by: Yang Li Reviewed-by: AngeloGioacchino Del Regno