Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp37960560rwd; Wed, 12 Jul 2023 00:39:37 -0700 (PDT) X-Google-Smtp-Source: APBJJlGCQbZlq3UhFpv21OutPuvIk+GYyo7dedxn30eEcmtrp03k8pEgqMEGHxfAbjyivqipegXz X-Received: by 2002:a92:d5d2:0:b0:345:dd32:c61 with SMTP id d18-20020a92d5d2000000b00345dd320c61mr14273418ilq.32.1689147576996; Wed, 12 Jul 2023 00:39:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689147576; cv=none; d=google.com; s=arc-20160816; b=whP/q+7HZ+FLSJPU0kayCC3LjyHCkcabV+k5seZzF6cBriiG94gNkMpdnNayUCEVcJ m4npM2Qs9kPbYar9yVhAGKndBdgHwHKWFEJmWrH/raZv4dvcXcYu0KUezj5Z/Z8cWsyi LYWBZWKC+wHmVYIgNBNuOMzW4eFAUPHuWDPTqHC0c8tJwbeOGctiMw3dLgUeeHDSXrhm BDhSiRslytgx/p0gonca1xHU0CvzBkL+JEbjY6dljdll/Gbh8cVO6f0O3adMS+I0qeyf t6zzjcdiCfKV8b8UQiSkAeqnjvj4YDXmgHN7gbeh8tpTAq0VrbBDjueG4nm50CRSBsXJ rKDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=zYD7pC+hbxrrC5ZwShAfpO96B80I/B5J2QxRqA4HUoo=; fh=amAQvj2LNIxwhLhmdmMQ2dyrLiFKCowqMoVQk291F88=; b=zhOObyATSHfFLbI6M3I9O12q8FGkm1lRNZT7LPYwuWZyvWM3v0hdMJgj3axDV+dxgn uEe+fMCiLAVnCvALyFhu4iSr5QOKOnJZs4EIhW9rGLEJUEc2PMnxa2vOruaGiXLorNt6 6bebW4ysNzeyzbI2z884UeyP1QBOlJw6b2Aps6gvZGM2cZh1O3nfkirP2BmHSLMJCJHs 38cnHOC6dnMcbC+hrMDrDiq3FhHabMqfcEKrJpJboKlGZNutuNtA3+vcllh7sDH0FLHO VYti3kZ+AD4uluceqLRgUyo3HFsARkQeW7fzZ+9ZaDIuZcYiH2uXVoXl0xb6lr1apruH 7uWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 9-20020a630f49000000b005538cfa80desi2767776pgp.655.2023.07.12.00.39.24; Wed, 12 Jul 2023 00:39:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231472AbjGLHcm (ORCPT + 99 others); Wed, 12 Jul 2023 03:32:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbjGLHcl (ORCPT ); Wed, 12 Jul 2023 03:32:41 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F23BE5F for ; Wed, 12 Jul 2023 00:32:39 -0700 (PDT) Received: from kwepemm600013.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R18Wj6v1tztR9P; Wed, 12 Jul 2023 15:29:37 +0800 (CST) Received: from [10.174.178.46] (10.174.178.46) by kwepemm600013.china.huawei.com (7.193.23.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 12 Jul 2023 15:32:36 +0800 Subject: Re: [PATCH -next] ubifs: Fix some kernel-doc comments To: Yang Li , CC: , , Abaci Robot References: <20230712071200.78575-1-yang.lee@linux.alibaba.com> From: Zhihao Cheng Message-ID: <94b243cb-da53-a3d4-7986-60e3be65a761@huawei.com> Date: Wed, 12 Jul 2023 15:32:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20230712071200.78575-1-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.46] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600013.china.huawei.com (7.193.23.68) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2023/7/12 15:12, Yang Li ะด??: > Add description of @time and @flags in ubifs_update_time(). > > to silence the warnings: > fs/ubifs/file.c:1383: warning: Function parameter or member 'time' not described in 'ubifs_update_time' > fs/ubifs/file.c:1383: warning: Function parameter or member 'flags' not described in 'ubifs_update_time' > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5848 > Signed-off-by: Yang Li > --- > fs/ubifs/file.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c > index 436b27d7c58f..5e86ef1be698 100644 > --- a/fs/ubifs/file.c > +++ b/fs/ubifs/file.c > @@ -1375,6 +1375,8 @@ static inline int mctime_update_needed(const struct inode *inode, > /** > * ubifs_update_time - update time of inode. > * @inode: inode to update > + * @time: timespec structure to hold the current time value > + * @flags: file time flag flags: time updating control flag determines updating which time fields of @inode > * > * This function updates time of the inode. > */ >