Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH -next v2] ubifs: Fix some kernel-doc comments
To:     Yang Li <yang.lee@linux.alibaba.com>, <richard@nod.at>
CC:     <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
        Abaci Robot <abaci@linux.alibaba.com>
References: <20230712074637.129248-1-yang.lee@linux.alibaba.com>
From:   Zhihao Cheng <chengzhihao1@huawei.com>
Message-ID: <0ab0a5de-8530-7cbc-ded0-0ca9cfdfa5e9@huawei.com>
Date:   Wed, 12 Jul 2023 15:48:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20230712074637.129248-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

?? 2023/7/12 15:46, Yang Li д??:
> Add description of @time and @flags in ubifs_update_time().
> 
> to silence the warnings:
> fs/ubifs/file.c:1383: warning: Function parameter or member 'time' not described in 'ubifs_update_time'
> fs/ubifs/file.c:1383: warning: Function parameter or member 'flags' not described in 'ubifs_update_time'
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5848
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> 
> --change in v2:
> According to Zhihao's suggestion, add a more accurate description to @flags.
> 
>   fs/ubifs/file.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/fs/ubifs/file.c b/fs/ubifs/file.c
> index 436b27d7c58f..860497532555 100644
> --- a/fs/ubifs/file.c
> +++ b/fs/ubifs/file.c
> @@ -1375,6 +1375,9 @@ static inline int mctime_update_needed(const struct inode *inode,
>   /**
>    * ubifs_update_time - update time of inode.
>    * @inode: inode to update
> + * @time:  timespec structure to hold the current time value
> + * @flags: time updating control flag determines updating
> + *	    which time fields of @inode
>    *
>    * This function updates time of the inode.
>    */
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>