Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755512AbXJXPs5 (ORCPT ); Wed, 24 Oct 2007 11:48:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753064AbXJXPsv (ORCPT ); Wed, 24 Oct 2007 11:48:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:52487 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972AbXJXPsu (ORCPT ); Wed, 24 Oct 2007 11:48:50 -0400 Date: Wed, 24 Oct 2007 16:18:40 +0200 Message-ID: From: Takashi Iwai To: Matthew Wilcox Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH 3/4] sound: Use stringbuf In-Reply-To: <1193173966-3550-3-git-send-email-matthew@wil.cx> References: <1193173966-3550-1-git-send-email-matthew@wil.cx> <1193173966-3550-2-git-send-email-matthew@wil.cx> <1193173966-3550-3-git-send-email-matthew@wil.cx> User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28) (fuki) (+CVS-20070806) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1124 Lines: 34 At Tue, 23 Oct 2007 17:12:45 -0400, Matthew Wilcox wrote: > > sound/ had its own snd_info_buffer for doing proc reads, which can be > profitably replaced with stringbuf. It actually finds a bug since ->read > and ->write now have a different signature. Do you mean the assignment of snd_ca0106_proc_reg_write? I also found it out today coindentally :) Any other bugs I missed? > @@ -375,7 +375,7 @@ static void snd_ac97_proc_read(struct snd_info_entry *entry, struct snd_info_buf > > #ifdef CONFIG_SND_DEBUG > /* direct register write for debugging */ > -static void snd_ac97_proc_regs_write(struct snd_info_entry *entry, struct snd_info_buffer *buffer) > +static void snd_ac97_proc_regs_write(struct snd_info_entry *entry, struct stringbuf *buffer) > { > struct snd_ac97 *ac97 = entry->private_data; > char line[64]; This shouldn't be changed. thanks, Takashi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/